Received-SPF: pass (google.com: domain of linux-kernel+bounces-192000-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <9489c21f-d397-4d19-a1bc-81dd6078ea24@amlogic.com>
Date: Tue, 28 May 2024 17:17:53 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 3/3] arm64: dts: amlogic: a4: add power domain controller
 node
Content-Language: en-US
To: neil.armstrong@linaro.org, Rob Herring <robh@kernel.org>,
 Krzysztof Kozlowski <krzk+dt@kernel.org>, Conor Dooley
 <conor+dt@kernel.org>, Kevin Hilman <khilman@baylibre.com>,
 Jerome Brunet <jbrunet@baylibre.com>,
 Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
 Jianxin Pan <jianxin.pan@amlogic.com>, Ulf Hansson <ulf.hansson@linaro.org>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
 linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
 linux-pm@vger.kernel.org
References: <20240528-a4_secpowerdomain-v1-0-2a9d7df9b128@amlogic.com>
 <20240528-a4_secpowerdomain-v1-3-2a9d7df9b128@amlogic.com>
 <c97b12bb-8b56-4129-a292-588226a0ec42@linaro.org>
 <70083d10-483e-4daf-a408-020f0147c5cf@amlogic.com>
 <fbafc16d-d6fa-4c57-8fc8-a1db09d03e05@linaro.org>
From: Xianwei Zhao <xianwei.zhao@amlogic.com>
In-Reply-To: <fbafc16d-d6fa-4c57-8fc8-a1db09d03e05@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?eEUreHhpZzVMaW5MaHQ1dEJPYTkxRHplZDJJeUh1eTZaeCtCdFMwMHZpMmhX?=
 =?utf-8?B?b2hJMCtWRXZiTm1COHE3emRMdklOcmFVUDhFcm1wT2c4NVRkZmVMZCtpejB2?=
 =?utf-8?B?NmVtWmYwVnJSVU8xZW5oWE5pQ3dZZHp0L1pTdlFGNHFOQ1lwN3VleHBLNXRJ?=
 =?utf-8?B?R2tJUG9ETjhlZytPMXdPa2xBN05SSXdaN2dkeXE1anJVNW82VWlyNndqMThw?=
 =?utf-8?B?TlhkNDVvaFRPQWEzZllkS1ZKVGxTbTNHMFY1SGJ3RnM5QjRNTC95alFYMnoz?=
 =?utf-8?B?a0Y0ZG9UNDVwVTNHSG9QRDJQTThHRzVYdHZsaFo2bU9BZEd6WmtReGt5S0ZJ?=
 =?utf-8?B?WlMxVEFzZGlsZ0RnTnBES0U4RVVicWo0SGJVdThOcmNSNE42Zk5LajdkUFJq?=
 =?utf-8?B?Q2JtU3RkaDkySFk1V0JQb1U4MGRUUnFPMnJtQ1h0bmdWaEQyY0xEdFl4Zzd3?=
 =?utf-8?B?TzY4aUxrdTBvNUFvK1NSRzFIRGp3c1F1R25WV244WjBjTjFDc0ZIc0k4VVM2?=
 =?utf-8?B?elExTldHRysxb3NIc0tLVWdqMGpEN3BYY3gvZ3ZPOHA4cHRIWG1KeGhoYmc2?=
 =?utf-8?B?RzlNS3V2R2JpaENWWHhOdWluZVFUSXdCeHN0ZWora2VMbldZVFQ0RThoWlll?=
 =?utf-8?B?eVlNNjhRdmY2YUJiU0RWbThkaGwzWEcrOTc4ZVA4Ukd6WmdBZml5WlRuRTRP?=
 =?utf-8?B?YlZuS0hyTXNFMkgwWGpoZ0tEQmFEVDFWQkd2M2dnYXc1NldEVlZqWTU0WmNl?=
 =?utf-8?B?YkhUQzE0MURmYWhDakI4MWdnK3F1cVFDS1JtQTdNcWV0U0hpWnlEeVZGdDJB?=
 =?utf-8?B?bWRLVEZHYms1NFBXUVdMNEhnd0lsK1VXOTZ0NnYzeDJzWTZYcE02RWlWRUx5?=
 =?utf-8?B?d0JRMFU4d1p1c3RtdW9UOU9KZWxwbmJKV25jWlg0eEtsOCs2VXVpNmcwMmVE?=
 =?utf-8?B?Sjc5SkpVazRoRWxLUTREK3FGbFI4WXNIcm1jd0w2VkYzSm9GVmNwY3pUc0RB?=
 =?utf-8?B?bXVhSE1MejBDaHJvUFB3U2ZFYUhMYkZ4bHFCZjBsbFByUUJZOTd6WUg4RWE3?=
 =?utf-8?B?bzA2WFltT09Oam9mTHB2aWRZRmtNb2dGNHBHczdCMDZ6NlBmeFRrR1BlZU84?=
 =?utf-8?B?dG54UWNwbzhpWkhsUi9zVjUvY1gyMzFyN2EzL2lyMGJLMjF3UWFkUlExUzVF?=
 =?utf-8?B?YUFaZU41UHZlZU5qMStQY0lnNytmUjllOWZrY2RpRHZ1WE9nbXhRQkFPNmc1?=
 =?utf-8?B?djVoYmpTdmVCM2VVbUh5M21kUkQvRVZHMDlOOFZmMjlnUkFhWUVPNzhIY3dE?=
 =?utf-8?B?d3R3Z3M4ZlV5TmZmOUtzM3lIU0szZ3UrVEVqTVk0WkNiRHlYaHZ2N1pEaVEz?=
 =?utf-8?B?OVI5VEs4R1JiNU5NS1dRMGFXRmVDYzZBU2E3eGZwR1Bzd3dIN2dZRzUvUmtN?=
 =?utf-8?B?UVlxYU8rS2V4MnZoWXozK2tPNlh2eHpmMXFmVFJ0L0EramdXRXBwWWZJeE9x?=
 =?utf-8?B?bllTVVliWExHQ29DQnhLYWhnSjRFS2RxOHZhbVBaa2w3L3hCNlRQNURQbzRy?=
 =?utf-8?B?amJuR0s1Y2tkaUttV21SV1hlbm1qMmswYUJHVlhvREZWanBaemFLSGhvVkZZ?=
 =?utf-8?B?TVNpUXRkNWxLckxkZ0FsbkRDVWgwTmE0dFByTkVzTEtDQllWSXZpL2tTNkJH?=
 =?utf-8?B?M0VQUlVlVU45cjg5d1Y5YXZWYjAybkFVam0xZEZlSHRGd3JrQllsMU0wWXRI?=
 =?utf-8?B?NWlreEpOc29KZWt4RzBxMTBRUE9tWHQ5RFphaWJYZGtzZm5vWFZrVFZseTdw?=
 =?utf-8?B?VStXM0FkYUthSWJ4c3NxSnVxNURaeHoyYzUrNGhJc1ExSER2YVQ0cmlabzlp?=
 =?utf-8?B?bVZMb0paR2Y2aXJqclEyUWtGTlh0Uy9KK0svNUF3RGpWRmhKSlVDNXBNcTJx?=
 =?utf-8?B?dVI3eGgyY0lBRFpzRE0vMGJVazdaRWUzTmM3U2xyV3JDRVJDb3RwTm1LbzEv?=
 =?utf-8?B?T1djNVJ4YUxueTJuN2QveU5DenRoZXNSbDZUTkhCWE9zNXFGVURISC9zTkY2?=
 =?utf-8?B?UDJ1cEx5MFMrQlU1aVVQNXgwV3Z1enY2clR6Q2lIWlpRTGU4bVdhcjF4Tklo?=
 =?utf-8?B?VXVYN09tWEpDaDlVckdZYXhZV3BwdGJNNjlPSldWSUlFeUR6N0dBdjVNdHdY?=
 =?utf-8?B?aWc9PQ==?=
X-OriginatorOrg: amlogic.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7add3a97-bb49-462c-b2d8-08dc7ef710b2
X-MS-Exchange-CrossTenant-AuthSource: TYZPR03MB6896.apcprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 May 2024 09:17:58.2677
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 0df2add9-25ca-4b3a-acb4-c99ddf0b1114
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: i06XNdKrm/FzARZ7CCdg9gdoZvn6GoAx0bmamgzGviwoBSkiSNol0Kv1Vbk+QXLIZT16lk/1xPIQ0PmSQkOAYvirvPih935+QoK+RNJwARc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: JH0PR03MB7382

Hi Neil,
    Thanks for your reply.

On 2024/5/28 17:08, neil.armstrong@linaro.org wrote:
> [ EXTERNAL EMAIL ]
> 
> On 28/05/2024 11:00, Xianwei Zhao wrote:
>> Hi Neil,
>>     Thanks for your quickly reply.
>>
>> On 2024/5/28 16:46, Neil Armstrong wrote:
>>> [ EXTERNAL EMAIL ]
>>>
>>> On 28/05/2024 10:39, Xianwei Zhao via B4 Relay wrote:
>>>> From: Xianwei Zhao <xianwei.zhao@amlogic.com>
>>>>
>>>> Add power domain controller node for Amlogic A4 SoC
>>>>
>>>> Signed-off-by: Xianwei Zhao <xianwei.zhao@amlogic.com>
>>>> ---
>>>>   arch/arm64/boot/dts/amlogic/amlogic-a4-common.dtsi | 4 ++++
>>>>   arch/arm64/boot/dts/amlogic/amlogic-a4.dtsi        | 5 +++++
>>>>   2 files changed, 9 insertions(+)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/amlogic/amlogic-a4-common.dtsi 
>>>> b/arch/arm64/boot/dts/amlogic/amlogic-a4-common.dtsi
>>>> index b6106ad4a072..eebde77ae5b4 100644
>>>> --- a/arch/arm64/boot/dts/amlogic/amlogic-a4-common.dtsi
>>>> +++ b/arch/arm64/boot/dts/amlogic/amlogic-a4-common.dtsi
>>>> @@ -27,6 +27,10 @@ xtal: xtal-clk {
>>>>               #clock-cells = <0>;
>>>>       };
>>>>
>>>> +     sm: secure-monitor {
>>>> +             compatible = "amlogic,meson-gxbb-sm";
>>>> +     };
>>>> +
>>>>       soc {
>>>>               compatible = "simple-bus";
>>>>               #address-cells = <2>;
>>>> diff --git a/arch/arm64/boot/dts/amlogic/amlogic-a4.dtsi 
>>>> b/arch/arm64/boot/dts/amlogic/amlogic-a4.dtsi
>>>> index 73ca1d7eed81..917c05219b9c 100644
>>>> --- a/arch/arm64/boot/dts/amlogic/amlogic-a4.dtsi
>>>> +++ b/arch/arm64/boot/dts/amlogic/amlogic-a4.dtsi
>>>> @@ -37,4 +37,9 @@ cpu3: cpu@3 {
>>>>                       enable-method = "psci";
>>>>               };
>>>>       };
>>>> +
>>>> +     pwrc: power-controller {
>>>> +             compatible = "amlogic,a4-pwrc";
>>>> +             #power-domain-cells = <1>;
>>>> +     };
>>>
>>> pwrc is supposed to be a child of secure-monitor.
>>>
>> Considered writing it like this when I wrote this.
>>
>> Here are two approaches: one is to include secure-monitor in the comm 
>> dtsi and fill power-controller by aliases in dtsi of each chip, while 
>> the other is to directly include secure-monitor in the dtsi of each 
>> chip. Which one do you suggest?
> 
> The bindings mandates it to be a child of the secure monitor.
> 
Will fix it.
> Neil
> 
>>
>>> Neil
>>>
>>>>   };
>>>>
>>>
>