Received-SPF: pass (google.com: domain of linux-kernel+bounces-192010-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <4c68c88d-496c-4294-95a8-d2384d380fd3@oracle.com>
Date: Tue, 28 May 2024 10:21:15 +0100
User-Agent: Mozilla Thunderbird
From: John Garry <john.g.garry@oracle.com>
Subject: Re: [LSF/MM/BPF TOPIC] untorn buffered writes
To: Christoph Hellwig <hch@infradead.org>
Cc: Theodore Ts'o <tytso@mit.edu>, lsf-pc@lists.linux-foundation.org,
        linux-fsdevel@vger.kernel.org, linux-mm <linux-mm@kvack.org>,
        Luis Chamberlain <mcgrof@kernel.org>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Matthew Wilcox <willy@infradead.org>,
        Dave Chinner <david@fromorbit.com>, linux-kernel@vger.kernel.org
References: <20240228061257.GA106651@mit.edu>
 <9e230104-4fb8-44f1-ae5a-a940f69b8d45@oracle.com>
 <Zk89vBVAeny6v13q@infradead.org>
Content-Language: en-US
Organization: Oracle Corporation
In-Reply-To: <Zk89vBVAeny6v13q@infradead.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?R1kwUnF3elRCQmJzUXNyTU9xRlE5N1MxNnR3L08xbGxMUVh6WElsdG1XeXY1?=
 =?utf-8?B?SjdtT2FRK1QxSnp1YjZmYzNQN01zV1loUXVIaEVnaVNtTnc4OEpzZlYrRWJ4?=
 =?utf-8?B?NVJBa3RyTjZLbVZQUWk1Qk1oS2JlUDlBQXNMV2FsSTdOaWlWR1dSZzZKUXBL?=
 =?utf-8?B?RWdSNkpXOWhkK3YwSGVmZXVmbUllNFQzUUdrRklPMnRNQkdPZ09tais0UEdQ?=
 =?utf-8?B?NGhhOThVWXFPSlZZNi9TSzl0RFhzV2F3SFZ6ME0wMjhpR2tqdThEOHYyYW10?=
 =?utf-8?B?MjJwWGhieWdVRERuQnpoTDdUUE9TaTdBbHc2U1NIYVRJNzFLZElHV2NZMi9M?=
 =?utf-8?B?Q1k2VVdrazF3SWdjdjB1V0srRy83OTcwb1dQZzJyZ0VzZXdlMVdudmJxWE5I?=
 =?utf-8?B?Ny93TnFrWGdmbHhZQzVGaldrYjZTOEZUNEowbGU5WTV3dXpIZ3NLWGhIOGtB?=
 =?utf-8?B?M0RycWZlWHpxQXl0cjJkdXB3UUlqL255MjNDSmt3T2NUK2N6VFYzWnV3VHZK?=
 =?utf-8?B?KzlXaGVhc0lYWm5zbGxCQ05tWE1GMHVFbDZnMWpDQWhkWUpzcjdvVmRtT1Rp?=
 =?utf-8?B?M2ZHa2ZHbkc5VForYUloYlNlMENQZ1NWbU1rNUVHWkNjQ3grajY1ZHdTNXRY?=
 =?utf-8?B?YXBHRkFveElLWWJhTUs0Z3lEdGZYZVVwUG5LUXBnV0RrK0p1MGN2dC9Kc0t4?=
 =?utf-8?B?bUlybEhvQkJFa2ZGbEFmRDFOa293cDdyY3VYOUk5U3paOGppYVNIa2U0UlRU?=
 =?utf-8?B?UU54NnVVSWNmQW9uUUNHTHpTSWtWcVdSYlpiV2NDQ0pHQTZXanpuZ2JaMXU2?=
 =?utf-8?B?NFRzU2F6TVRpekNtSXdiUWVKSUpTYkFQYmFFWEJkamlWUmRjcXRmVEVURDRK?=
 =?utf-8?B?K1g0RGNQNmQyQndzS3RvN1FYSjUyVktwVUxYbE9VYjhBV0FqeWVQbjhaRnFk?=
 =?utf-8?B?S0NVUE0wTE9GR0dQRjM2bkRsTjBPUGdPbmREaFFURU1xb1hwUFNQWEpmNWVa?=
 =?utf-8?B?Sm1zVVBibG80ZVpiMit4Qnk0MHk4RmttK1NVNk00R0ZBY3pPQ0Q4TE1tUE9I?=
 =?utf-8?B?SStuVnN0VkZzaUE5NFRUVGgweUtOb2wrdTltc0s5TmNqYXZYbXBoK3BpbzBG?=
 =?utf-8?B?alNaaS9sNENQVjgyU0w2ZlErTzg4Y2owTjdXNDY2L1RscHBjYW1YS0U4Rzly?=
 =?utf-8?B?QzZscThhMStPWEtFNTZQRTZCM3N6VlRPMVdEcWExNmh0eGpMSGRDUmZjUFJP?=
 =?utf-8?B?R2tleG9qcTFYeVB5TlB3T1lFdllxdTNTMGZzalN3cU4ycWJja04xS1NVWUtu?=
 =?utf-8?B?TFVyRDZnOTRVTndDSjA4WkRFdDJaKy9UdkdRa3BMczVOWnAwdlJicUxpZ09h?=
 =?utf-8?B?dktiRlFINjlHWEZ1K2FMUlZsbFZtdTJCZW9KdDVweng2NUlGa2JXcmxUMGFk?=
 =?utf-8?B?bWFXRXVSS21KK0Z2RlF4RjdHZk53MTEyR0xNbG0waUdIK2FQamtRMldtZ2JT?=
 =?utf-8?B?N0VGTnQ0bFdsQ01EOHNocDZrUlNHcXdCWk1USHk5dUFnWUpZOEdacUdPb1ZS?=
 =?utf-8?B?UXBkalQzVFZUT2pDRURnZ21Ta3pjckhGNytsUXFDdUdQcFI2WEN3dENPS1Vj?=
 =?utf-8?B?YXhnZlpRdEJXLzhRdnlKMFEwM1pTOEZneVpPR1haSTl0c0JHY2NqQ2FISUpL?=
 =?utf-8?B?bDVEYUZha2JkRnBIbmtJT2k1Z0EvczBYYngyV1Rhb1FWa29rdHNndCtXYTBT?=
 =?utf-8?B?bmxNVDh0bWMydjJPWHJWa3FjdXNEcmY5RDE2ZG1CVFRYWml6cldoWG1CRnc4?=
 =?utf-8?B?T2x3OUppTy9ZbnIwcklOTVF3SGgzdDQ1bFEwYnFUbWJDRUFPOVllUVM4eWhI?=
 =?utf-8?B?WVRiU0k2aDBzR2UyN2ppaUtUcG9KYXhMekNsbzhEN3FXeGhBQlVKZkVIMzMr?=
 =?utf-8?B?SEJwVlRsbUlUeDk5bjZUWVM0cWF1b28weTR2aGJrVlNPNWxFckE1R0V0UEl3?=
 =?utf-8?B?Q0RWVDdTaWdac2NCVUIwNlBHWUhFYk5YdUhNdWhKa0ZnZEpMVm9jUk05Rmx2?=
 =?utf-8?B?b0kxUVBPUXZlWG9NTjYvamRZaUJBTStzNUFBVGFXUTcrbDhUVURVeHl5ZkF2?=
 =?utf-8?Q?dYf+Ps5mfoOYChm+GFIQE5mg3?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	fJtQpWYTLWhn9KmCiP996eQAkUOvatLY8dq5e0uesx33F3xL5yNDa/K5+dxbkli7fTvoDSM8dOhp5OlH9J6K/PzIBDO1BC6JNadwhHYBd7F7H/tWQeM2mZCJBCHep6OjwcPeUXk/g5OLN+AJE5xeLXDOb1aGO9XGiv/Y1CgDembc+YpCXJpVYGOekns8tj3IZQ8ZETvDj2PbN/DcKr7syKdq/p2v+b/ItZnMTpLkDMnCDsgLL3QRr9/LVczQ54FqH+IpBffwCGC8LyrhwZvynuAzYo0fSwyJF6eOs6zd1V9xD11kIZGkt9zft8CzjYl3wpYo1g0MCdsgMMxC3HKtSbCeLQsPkOJTkiwCVKdtfLv9S9EdkQci/iiUWVVlXjEcZ7oWftKTasCkJHgr8+j6o0mLFdEEuEw8K2INMu0DVjwvJ0Vx6LkbK2gDH6gcnELJeZaOASR/EYXnTLSL544z0ZqnwYBcK7G9Ee5TOKCuVUz4YNoIQaoQrQSV6SP50qmctjW8elEtmI4l2bxZyRrA3Ai5GT1odFYiXscjXF+L5p9tnCRCPr3PNnz9116A2lbhKHBkk/paP/WACTTfYdkDs9pZUFZaw/aV/NYk9XJvjUI=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a5db7ca1-ee11-45ba-50e6-08dc7ef788b7
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 May 2024 09:21:19.7569
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: E6ExEWnNiWchx7amEsV/M9DVG3rhJVAlIqALYq9BklUXwFvBTXYwdKGrcnYLA52X+6borJ8ChV4CDVEPDhjhlA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR10MB7861
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.12.28.16
 definitions=2024-05-28_05,2024-05-28_01,2024-05-17_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 malwarescore=0
 spamscore=0 adultscore=0 mlxscore=0 phishscore=0 suspectscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2405010000 definitions=main-2405280069
X-Proofpoint-ORIG-GUID: UeDExh4DSpT2Dds5o5BV7fQrLUocXVWe
X-Proofpoint-GUID: UeDExh4DSpT2Dds5o5BV7fQrLUocXVWe

On 23/05/2024 13:59, Christoph Hellwig wrote:
> On Wed, May 15, 2024 at 01:54:39PM -0600, John Garry wrote:
>> On 27/02/2024 23:12, Theodore Ts'o wrote:
>>> Last year, I talked about an interest to provide database such as
>>> MySQL with the ability to issue writes that would not be torn as they
>>> write 16k database pages[1].
>>>
>>> [1] https://urldefense.com/v3/__https://lwn.net/Articles/932900/__;!!ACWV5N9M2RV99hQ!Ij_ZeSZrJ4uPL94Im73udLMjqpkcZwHmuNnznogL68ehu6TDTXqbMsC4xLUqh18hq2Ib77p1D8_4mV5Q$
>>>
>>
>> After discussing this topic earlier this week, I would like to know if there
>> are still objections or concerns with the untorn-writes userspace API
>> proposed in https://lore.kernel.org/linux-block/20240326133813.3224593-1-john.g.garry@oracle.com/
>>
>> I feel that the series for supporting direct-IO only, above, is stuck
>> because of this topic of buffered IO.
> 
> Just my 2 cents, but I think supporting untorn I/O for buffered I/O
> is an amazingly bad idea that opens up a whole can of worms in terms
> of potential failure paths while not actually having a convincing use
> case.
> 
> For buffered I/O something like the atomic msync proposal makes a lot
> more sense, because it actually provides a useful API for non-trivial
> transactions.

Is this what you are talking about:

https://web.eecs.umich.edu/~tpkelly/papers/Failure_atomic_msync_EuroSys_2013.pdf

If so, I am not sure if a mmap interface would work for DB usecase, like 
PostgreSQL. I can ask.