Received: by 2002:a89:d88:0:b0:1fa:5c73:8e2d with SMTP id eb8csp2519921lqb; Tue, 28 May 2024 02:23:13 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVcyRMhzoyAXtMNTubxm+FYN4mkRCELJq1Ta66qU5H4MGy/xW526CieHvQwrD/foKYygfAOpqYPzxTubo8+Y4l13bDr/ifN0e82FfqyVg== X-Google-Smtp-Source: AGHT+IFf/E2AgUh0RHpGz0sHRanJ7XlsopMQT329YNi4URgV00XDRR6iu5mgzXXFLfRtHXhBHD2l X-Received: by 2002:a17:90a:3982:b0:2bd:fd59:ad9 with SMTP id 98e67ed59e1d1-2bf5e14b1b9mr11094633a91.13.1716888192916; Tue, 28 May 2024 02:23:12 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716888192; cv=pass; d=google.com; s=arc-20160816; b=q6v9As9PO7fQibreNyZ2aXTcSFyCNQ3A0mluHXRB71HY2CQdBtRPd3f/F78VQjvjyp DrlFmkLgARdBNAW4LQgsWlH8C0strSv7gyfpJCq/lX2pmTc8Td6aijcFliMFLZkYoZzJ tgONrd1KsnNuqqRLy9NrHT0K3Uk1WTBI+NHaK15Pu/t8zKw2uW/NiTPgDW80s28/F/c+ iN0WXruBUxwVZLJKKrFlTssR0trQp+mOsEJNayVeo0cHFzBHDkBpNjXfpWZHJJKcj/cH nkidPkWDh+kRWad2f62YqxI96ymA0YiBXlkDZx8wXQQAOswSzsF6GDPBinFPr4gRouWk JMPQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=ui-outboundreport:content-transfer-encoding:in-reply-to:from :content-language:subject:references:cc:to:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=KK4Se9epQ/qlMcMAbFV7gUJ2n7pL1maRb0tzRBLSB0M=; fh=1E2ieY4ER5wmP3GRr0hut6881Z6oqNVc4sQ54T0X8e0=; b=oXRbvrXttQ17yRjoKdd5bXxC5r9wCpmOtY5vv1wSZi81yfMRITRmMtmK27YjKba86+ VwB4+dHoJ2GagAdPhUyoxR3pXx1l5XvrCDLl5XDYhUTc1W32BK6U7/s7uezZNhpK36/f wrNm1lH6Nmwl2ebY3QWnCugUckgf8iVjANXhbjge976u7LSPNQR1p5Qn0tniMWTGmDPK 84CCrcNcYP68QQkumlXN8gz8AzR0h+dy3SH8ilfeSOz8NJVC3PdDCzZ+rPaDEDt6aXjk lceycBptAcn1vHkgbQngK6CmP3xa2ofX3ipI8s75wl2L0RMgPHfdKt5TgEBV3KRKRzwj /C5A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@web.de header.s=s29768273 header.b=BCP5g6DC; arc=pass (i=1 spf=pass spfdomain=web.de dkim=pass dkdomain=web.de dmarc=pass fromdomain=web.de); spf=pass (google.com: domain of linux-kernel+bounces-192011-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-192011-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=web.de Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id 98e67ed59e1d1-2bff4595a74si1991253a91.46.2024.05.28.02.23.12 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 May 2024 02:23:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-192011-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@web.de header.s=s29768273 header.b=BCP5g6DC; arc=pass (i=1 spf=pass spfdomain=web.de dkim=pass dkdomain=web.de dmarc=pass fromdomain=web.de); spf=pass (google.com: domain of linux-kernel+bounces-192011-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-192011-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=web.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 8493B2861AF for ; Tue, 28 May 2024 09:22:45 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 69DDA14D70A; Tue, 28 May 2024 09:22:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b="BCP5g6DC" Received: from mout.web.de (mout.web.de [212.227.17.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB000140E5E; Tue, 28 May 2024 09:22:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.17.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716888158; cv=none; b=SpxsiRRnd6TI24vMAIAAnIxBSddOObxZl0tqAYdZdOIHeCVeM5QJQQBFk2u+kSQkdAVqGyiRGzFv9fYoSvWIatF+bXM/H/IS2qXkq2tz5suzsOBi3oGILrnHZ7ybLz/9a/22KwAo7n3MmMnaYynpb4qu3TX2v7hsDlLHXTsDubw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716888158; c=relaxed/simple; bh=GwLFmpw97dTVYyGyXOWlFoh5Bpf1I6pea4ghGTgTLHA=; h=Message-ID:Date:MIME-Version:To:Cc:References:Subject:From: In-Reply-To:Content-Type; b=JrZZSt6AfELDsGs9vPS93qr/jD4gJfjzCCOAo+ibJxVXSypAfhxbPga9AyZynNh4kKJRQFLj2yUbyBtX4QzrzZddJXZmJAhEr+cDVmR3+dBh2jrY9lb9a2d23rpuExjMuDMacD1mVlkvJsFFotmFnoXJg7VZvQ9Wm4y0dwFhv7M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de; spf=pass smtp.mailfrom=web.de; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b=BCP5g6DC; arc=none smtp.client-ip=212.227.17.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=web.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1716888144; x=1717492944; i=markus.elfring@web.de; bh=KK4Se9epQ/qlMcMAbFV7gUJ2n7pL1maRb0tzRBLSB0M=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:To:Cc:References: Subject:From:In-Reply-To:Content-Type:Content-Transfer-Encoding: cc:content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=BCP5g6DCabvTJVw7DA6C1tR+bAwAGCopnt5wzzgHi6Tn2IO2a0lt+Rh8h0pzWPu8 T8aUrXGPTXqjDXND6uRZs35R+QxOsEOjvscrC+JPGOpK/7QsTLx/dP/2pgO+RAh+a 4hl6MbhVFOT+O6tqY2OumtHxyzszX/YgDt/BaLVyTvWPbSYQIk+qzl2GQI31Ejdr4 pyiGTKLV1rlJOBGCji3op6HwuKNBmRCSYOnIS+Aq7aQgEA7ztXiYyUWr+cyRbrWK8 n9Q2zwjuwstgmjVen+8n79GjEy6vEx2TXoBVjgPU+9BtZw+m19gj0qsOxU3tWnLTC QnDfcNLlqa/J8M19MA== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.21] ([94.31.83.95]) by smtp.web.de (mrweb106 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MGgNU-1sGoio2xM2-00Dn4P; Tue, 28 May 2024 11:22:24 +0200 Message-ID: <534687df-c200-4741-ad00-a847e8fb8b12@web.de> Date: Tue, 28 May 2024 11:22:23 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Li zeming , linux-block@vger.kernel.org, Chaitanya Kulkarni , Jens Axboe Cc: LKML References: <20240318025525.16439-1-zeming@nfschina.com> Subject: =?UTF-8?Q?Re=3A_=5BPATCH=5D_blk-zoned=3A_Remove_unnecessary_?= =?UTF-8?B?4oCYMOKAmSB2YWx1ZXMgZnJvbSByZXQ=?= Content-Language: en-GB From: Markus Elfring In-Reply-To: <20240318025525.16439-1-zeming@nfschina.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:eM83rr2d+zGxhfDZp62dOSXDrvp87wT2RucariXmvV4AU2oKs/e lnyxVqawxhdmBoiRoZ/sYbo7IpxR1LIz8stnY+iviVZgFJWuXhMtho7gP+1/sbsZHOa4BCT MrTnn2nmk0hpQOw5qst9MlO9GuX9iKoBb9lo1CNRkrGRv6PWiImpEUHRCk5o67XeoLudQUY deChX3bHs6L7v07b3VD9g== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:4oaWStMKZV4=;4V9uRLua0azCPe4/J6EQ+VvExt2 wQblOJ4PAX5S92ilATNsmXfG8vboBHf3M3pWcaKwsuU01yrMxJWQf9SqKoEENj9apkPe24LS0 pi/8+NuJObbamUHL8C48uupKW/Olta9ktqWccD2riSEZbJmLBk3kVLV+n4cORfN9HXG69coiw /mE+vPQOev40xCf9nbqPqEZGaYnvUuL9BJk2mqz/UXQljJufkcz6TQ5fR7AHQr+9j/vecmRGX e2mwUYfmdqOpNEZDkjYN3X78vbO8H+CaZkR3P6clcmiIvgVNpuvnBUgQ/Lm/HiB7/kabJaVRW LNfAeX78YYl5RO/5nmCFg0NZDx12c843NGci6qRpxUXuqhGswQ9VAyHXWxt2tcB32rvEqpS0F yS+2Whsc8rfPqrUAilfZUEl3oOR3lwVirwlgu7tblhcRumr41R2FDC6BY9I93duj4djif9Be7 kKC2jb3FDsch3FB+TkfqscdDAECkUVwHkWfjlWdKBY0Br30HSLvOa5Bp3GgZ7SnoG1jStduCL xpWlbEGfNJvfIV4bQBOgUnthzzHo8MDXYS352e3WMuQJFE2viZPvGDfsSzxyuqR7j3X3vrF6G f4sgrxpVMqYcfHLSX2oNCzQgoS62LhMLMAEHiYTs+hY5RgjnnBaOpfSEUNyo0ZncOq5/je7Mw P7nlF8vrADWIXDrfqFkk3J5QPUlNFUmANy7RhoPeMB9JnN+/UbsTpRSca4atUhCb6qRLw1V7N aEdKHv1YcO+9KwD8NIrJ/DU16KzDY0ik64Wozk9iBPHn+XpKVpgSEJwRJSYzns14FUGQUerYf bRTVugUhx/qb/wghrPAYh19Wuvj/FSnBUk6mM5rsO2DAg= > ret is assigned first, so it does not need to initialize the assignment. * Would a wording approach (like the following) be a bit nicer? The variable =E2=80=9Cret=E2=80=9D will eventually be set to an appropri= ate value a bit later. Thus omit the explicit initialisation at the beginning. * How do you think about to use the summary phrase =E2=80=9CDelete an unnecessary initialisation in blkdev_zone_mgmt()=E2= =80=9D? Regards, Markus