Received-SPF: pass (google.com: domain of linux-kernel+bounces-192019-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <d104a345-7df1-4fce-a9d4-05f539fc9160@intel.com>
Date: Tue, 28 May 2024 11:33:12 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next v3 2/2] net: phy: xilinx-gmii2rgmii: Adopt clock
 support
To: Vineeth Karumanchi <vineeth.karumanchi@amd.com>, <git@amd.com>,
	<davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
	<pabeni@redhat.com>, <robh@kernel.org>, <krzk+dt@kernel.org>,
	<conor+dt@kernel.org>, <harini.katakam@amd.com>, <andrew@lunn.ch>,
	<hkallweit1@gmail.com>, <linux@armlinux.org.uk>, <michal.simek@amd.com>
CC: <netdev@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>
References: <20240528062008.1594657-1-vineeth.karumanchi@amd.com>
 <20240528062008.1594657-3-vineeth.karumanchi@amd.com>
Content-Language: en-US
From: Wojciech Drewek <wojciech.drewek@intel.com>
In-Reply-To: <20240528062008.1594657-3-vineeth.karumanchi@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UzNiV2FQaTZpdVpMOEg5OUJlSjdKRnVTTGFwbjNiejhya1VVUnBHR1ZIYWQ1?=
 =?utf-8?B?SklLQkZJQ2lhVEgrbFZSRmNBNnkwdU1DeTkwQjhtaW40L0ZRUVFrbzROZEF1?=
 =?utf-8?B?TUs2dUhlTVpBRklLRXIrRW1yTkU2bWlaVk42VDV1QVlzVFB1bEZSMlkzdjJ5?=
 =?utf-8?B?RlplR1FGZTB0ZllhMEV3VnNMbFJFejZrOXFYNEhMd05JM2tzU0FaMXdFK3Zq?=
 =?utf-8?B?ZFM4OEtQUGZXOC9BSm13SmJTYWJsY1loeEduLzFyR3JlYWc3cUZzdSszL2cw?=
 =?utf-8?B?ektBWHU3V0ZSSW5MSGhiUWFMaFRqSHVOUWZpdlkxelM4dlFmWTBCVytCS2FV?=
 =?utf-8?B?RGxkRmZOVnRkK0RVRWtOcVk4blBiTU8xVnozYUlyTkZOSXhCVGk4cW1mUlAy?=
 =?utf-8?B?akZIT3kwTHY4YU1OYkFDMjJ6OWN1dHJZeUNZbnZ1RDNLNjRtUUdWenhySC9R?=
 =?utf-8?B?S0ZzRkhkcVdlbndzODdnTlNUYlg0aHhqeVhmRDZCVHVjbDVHYmVqOGd2Wjgw?=
 =?utf-8?B?ZjV3NU9iMGJ5eGMya045bjQ5b2NSUFVJcXBYZUN2eTBsT0gxTGhmZzVDbCtC?=
 =?utf-8?B?eS80MjJoWjRzSm8vN0VxQ213a1VYcExQUlRFUmlucDhQM1NyTFFrY3lUQVYv?=
 =?utf-8?B?ZnhxUDRNRmVGQ1ZiUGFuVmpQOHdWWkZCVTNwVlg1MkVnTEtidll3VjFOclpx?=
 =?utf-8?B?d3oxdk1EQ3VzUVhtL0VJM20yNkRvMDlqUFZ0U2dWckZ5NkNSbDE3cm5MQWUz?=
 =?utf-8?B?Rmp2dis3bmZ1U0hXUExoYmFiREx6WnE1K0dKRlZ6R3FKbDNBSG1tVTZON1pE?=
 =?utf-8?B?NUFUSDUzeUZlWER0R29FN0tIVTJBTVBGMU1qcHJJK01Ma0liTlBSKzRUWG5B?=
 =?utf-8?B?K2xEOUtnT0p6L3BVTFVxS1BNTnlFN0dVUm9Ga2xkQ0FSR2xENXZvS2Q5WnFq?=
 =?utf-8?B?SzMwNlZpYXZoejVVWXpQRndhWUVWbkcwMExTSkN0dmRreHBMQysyWEJHSUox?=
 =?utf-8?B?dlNmR3lZalFQQUxEallLVlI3R2V2TXRreUowcWlzczlnV1BZS2F6SFZEajVC?=
 =?utf-8?B?Nk53V01pa1U2Q2ROSTJpL0NsOWtPbGFnQTlCQk5JVTZrTDJtMk5nc25rYk9N?=
 =?utf-8?B?KzU0OGlQUUV2c0laK3BaS2c0Rm1xWVRHc1JZY0tKbEF6VU9weEdoOHB0TU1N?=
 =?utf-8?B?UGdtN0N2WUp3SmxldFkrU1ZTUkp1amNOU0hsUDJzVE14WWNFSHNYNlB1NXJ0?=
 =?utf-8?B?enZBSGk1TmRpZ1VGemo1NE5oMHh5UXcxUkduMWluM0V3RnVyYVI1cm85aWhm?=
 =?utf-8?B?VEFMMkpXTWRxN3ZGejMxa0ptc2EwYzYrb0x3czlwV1BUQmREWlJSY3N3cGdh?=
 =?utf-8?B?cW1uNTVhcHBBZ3RGNkI0ck1OWlkwMGdZVkZuZEFzaTd2Nlh3emhKRGJqSDJ2?=
 =?utf-8?B?TFhUeFBOR3huRVVUb2RYRjRPdHE2azM4OVFGZ3dTQnBoSmlVeFhGeHdDREtx?=
 =?utf-8?B?Y2haZTlPTHdHWEZwbDBNOTdWZ2wya3lReStKdGpKckU4MGVmdDZUZWJqdk1h?=
 =?utf-8?B?MDNDTWduSzIvWFIyUkU4Z3ZIWnFpcEJIeTZlY2hOc0l5c2V0TnFBa2J2czNB?=
 =?utf-8?B?WENpQzF1MG9jSjBkb2pGVU1lSi9DY0tEdkFJSkFaTG96ZDlJN05YMUFrVVRu?=
 =?utf-8?B?UmVvcVNZTTJqQ1ZOZ3ZIRE9jRE1RR09RNlp5eFcwYUdmMGxhUnBxcmQyTEdu?=
 =?utf-8?B?MzlKZGlmaWtYSWNtR1FEdmNSSnYwbHhhQi94VVRKUEFCTzNPaG5tYXYxMWd6?=
 =?utf-8?B?bnA2aklUZG16NmdoZFNCZ2RxSTdwakdCUVZVNXhkZ1ZyVlZCenZhaFRIT0RD?=
 =?utf-8?B?ZEk5YmFnaU5VQ2pCeGNoUVV1NjBaWVVvcG1nS2dIbmYxMG8zMG5TbVJ0U2xH?=
 =?utf-8?B?Z29wUEhINUN2SEkzM2cyaUhtVXFnd0NrbE9VNmVwa3lBbVNRMnprS2t6bWtt?=
 =?utf-8?B?elBhbHZtMjlkbkRkejBiYmhpL1FWS25kOElTRHNDZkNmaFA1cUprRGFLQ2l0?=
 =?utf-8?B?dVlORG5oS0pPRGtzYjhOTVFLNEtDMkswQkF0cjZTS3hEVUVXNDI3a09TRHBD?=
 =?utf-8?B?VUFGeExrSVl2WjhrY0pjNktiSnJmY1ZUT3RGYWM0UVM1NjVnY29XdlFtbHRL?=
 =?utf-8?B?NVE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 85ee7638-b402-4226-432e-08dc7ef935f9
X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5776.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 May 2024 09:33:19.9585
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qLk0pJ4glgc4pkiCOnYtFMDAsPu7qgN2hS9mrisxMTJs4djcFVFmu9YZRQD3J8RMsAnZKdkzc5bD05dvthHdknTcHU2K9kETaMO6Tj0HU+Q=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYXPR11MB8731
X-OriginatorOrg: intel.com


On 28.05.2024 08:20, Vineeth Karumanchi wrote:
> Add clock support to the gmii_to_rgmii IP.
> Make clk optional to keep DTB backward compatibility.
> 
> Signed-off-by: Vineeth Karumanchi <vineeth.karumanchi@amd.com>
> ---

Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com>

>  drivers/net/phy/xilinx_gmii2rgmii.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/net/phy/xilinx_gmii2rgmii.c b/drivers/net/phy/xilinx_gmii2rgmii.c
> index 7b1bc5fcef9b..7c51daecf18e 100644
> --- a/drivers/net/phy/xilinx_gmii2rgmii.c
> +++ b/drivers/net/phy/xilinx_gmii2rgmii.c
> @@ -15,6 +15,7 @@
>  #include <linux/mii.h>
>  #include <linux/mdio.h>
>  #include <linux/phy.h>
> +#include <linux/clk.h>
>  #include <linux/of_mdio.h>
>  
>  #define XILINX_GMII2RGMII_REG		0x10
> @@ -85,11 +86,17 @@ static int xgmiitorgmii_probe(struct mdio_device *mdiodev)
>  	struct device *dev = &mdiodev->dev;
>  	struct device_node *np = dev->of_node, *phy_node;
>  	struct gmii2rgmii *priv;
> +	struct clk *clkin;
>  
>  	priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
>  	if (!priv)
>  		return -ENOMEM;
>  
> +	clkin = devm_clk_get_optional_enabled(dev, NULL);
> +	if (IS_ERR(clkin))
> +		return dev_err_probe(dev, PTR_ERR(clkin),
> +					"Failed to get and enable clock from Device Tree\n");
> +
>  	phy_node = of_parse_phandle(np, "phy-handle", 0);
>  	if (!phy_node) {
>  		dev_err(dev, "Couldn't parse phy-handle\n");