Received: by 2002:a89:d88:0:b0:1fa:5c73:8e2d with SMTP id eb8csp2525595lqb; Tue, 28 May 2024 02:39:53 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWcGhrXIoE4dtjnpec2aB+tLzBnuXvy9bkGBgiyW3kgT1w+ZXW2I8hbuIe7rI8/i17gQE/+W7AuxIizG3d3f0ockD9no/SSm/94BzeBYQ== X-Google-Smtp-Source: AGHT+IH/6LFmD2JRVw4mzr4K3URdoVrfMSq1OSRIlgruL+okkze/CD6lz70d134Mm7Zqi4GgJTsu X-Received: by 2002:a17:906:bc4d:b0:a63:3c6f:bff6 with SMTP id a640c23a62f3a-a633c6fe205mr120618466b.18.1716889193463; Tue, 28 May 2024 02:39:53 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716889193; cv=pass; d=google.com; s=arc-20160816; b=k2w4QaQ1+4AGLHY4fhPwzEKke2Tz50JUHng3PO+EIWpbI797x+2NVIeC97rW/fI/Ra 95JSO+l1ga7WfYAxBz3x3FHQsiaa9lgJ/unPXjEULZgwTOKgJ80dHZviAwg8tzrs98P2 MVYsA0IGmNiCLm/EuJ4FWHqpswRMu5gUNi+qYbKxqy9Ev14pWooel6xqL68Q/7rOZ550 E14pC8egH3WARDn0UmN88JfkGdybVkibaQorB06yfO50kqrEU9hhNa6lxtAOUKihv1+B AcfR8StC0xbtKtbOjP3Ar6bpKvnB6aLKGSEAnh92iiDgX3rYjuu/aBLTCfqg0SmyY1e4 G64Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature:dkim-signature; bh=Vqve763J/fnX5w3j8DDUs6X/uVtGpHOXdGrGBsbN7qA=; fh=bIEGBRR+1dC130N0HSnTaVZr9GmNiOcdBGfLNRensUU=; b=ZzKxDsMeNExtqMgtjuCT5XgLb3+rm7FGbo7hlGNH2P5+MNpZgdY33cMycjCv3+dgTW /msin1U39lV/vb89mrvrSz/INJ+m18w3SpmGhnPH6bNXacLL6oKLlI9gIYGINY+ht2sk O2SXKDgCnLgD5pA8pLiIg0skzg/l6OWJ8wm+fONCaj8iNr0qbwBT71exxfTUJO4aRT8D Sk79QI9t2vXur9VNllu1Nbt5/WQX0EVFZb2y5hP5FV+nUpCSWwvsqpUuQNdwTqZu3rQ1 5k+Dotw65KRo6qVM0QYWR83PTUU0HUScNxhsBT/02Q068zAnbtOifbGKOa4+8rO1HK9C Tmvw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@tq-group.com header.s=key1 header.b=PNDEeeq9; dkim=temperror (no key for signature) header.i=@ew.tq-group.com header.s=dkim header.b=BJ4R6F1C; arc=pass (i=1 spf=pass spfdomain=ew.tq-group.com dkim=pass dkdomain=tq-group.com dmarc=pass fromdomain=ew.tq-group.com); spf=pass (google.com: domain of linux-kernel+bounces-192022-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-192022-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=tq-group.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id a640c23a62f3a-a630625c75esi181858566b.321.2024.05.28.02.39.53 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 May 2024 02:39:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-192022-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@tq-group.com header.s=key1 header.b=PNDEeeq9; dkim=temperror (no key for signature) header.i=@ew.tq-group.com header.s=dkim header.b=BJ4R6F1C; arc=pass (i=1 spf=pass spfdomain=ew.tq-group.com dkim=pass dkdomain=tq-group.com dmarc=pass fromdomain=ew.tq-group.com); spf=pass (google.com: domain of linux-kernel+bounces-192022-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-192022-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=tq-group.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 3798C1F2301B for ; Tue, 28 May 2024 09:39:53 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 59E3816A385; Tue, 28 May 2024 09:39:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tq-group.com header.i=@tq-group.com header.b="PNDEeeq9"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=ew.tq-group.com header.i=@ew.tq-group.com header.b="BJ4R6F1C" Received: from mx1.tq-group.com (mx1.tq-group.com [93.104.207.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B7B726E611 for ; Tue, 28 May 2024 09:39:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=93.104.207.81 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716889184; cv=none; b=jDEI+ZFVHJ0q7OpTkZqgEyhGB4rn5dVqJdyUMNjtVjNifLYFDp4nzL+J6SRK+CDJg5W1l7YWWY5Z+3y4lx1cRPIk1RdpSl5+SFfzp8znJz1rutYnphED5C15S8kL9HUTRiNgIYzYTPKPjFrtad6gCiYuQXZIdd9eAIIFtV9U5Mk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716889184; c=relaxed/simple; bh=nTTYiOeNyqQ0NyjPEVVnO1VfTHoV+DmgmjODFXYenxA=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=njsybrF+1lnkIbTMoM6wplGzqoj8CZwlSdn73rWThU0malUekAZcronSbX/l/P6W41FTKCwzJwKpJ0hEpIIo8+fFxAnQGgs1omoPuX2s+Wce6cMbzY4cSDsMAKd0QtnrJvxEMRr36Vl4i7DE2PI/amLSmM1C1fxS5WUwZN3uiMc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ew.tq-group.com; spf=pass smtp.mailfrom=ew.tq-group.com; dkim=pass (2048-bit key) header.d=tq-group.com header.i=@tq-group.com header.b=PNDEeeq9; dkim=fail (0-bit key) header.d=ew.tq-group.com header.i=@ew.tq-group.com header.b=BJ4R6F1C reason="key not found in DNS"; arc=none smtp.client-ip=93.104.207.81 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ew.tq-group.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ew.tq-group.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1716889181; x=1748425181; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=Vqve763J/fnX5w3j8DDUs6X/uVtGpHOXdGrGBsbN7qA=; b=PNDEeeq920ZPSm2o6TGMDatFziJp738D0ocjTX7DoySvouVP8LRdRSxC htWMtJiB1tdeAqM0ia2OJa+sdrT/FTj3gtKia13oNuUHmExL6XLOvXZ4F Wba89xYERSW6BYdV55kGBUwzFvIqRuqwsS4SJ6M8KEw+l6c9m0dv774rr 2NW83yjoBuLepR5J3DWv25Svog0YqMZ8/3G9CQ3QChJxw+aG1qfilJ6XM BZOaXF1qX3UU/PGxsa+kpZA1IFCRyq1AVEbBeISSYig1v3Xk1NHPzhcRg kSlbiLuwCOx3l41gHMULi8VZWogcuoMvcBlhBEUkyx4hVFGFG9j9b913t w==; X-CSE-ConnectionGUID: 2k6GM/7jTsO5KvQ5L84hDw== X-CSE-MsgGUID: YiUP1NdXTn+RyzxY1Ae8Bg== X-IronPort-AV: E=Sophos;i="6.08,194,1712613600"; d="scan'208";a="37100349" Received: from vmailcow01.tq-net.de ([10.150.86.48]) by mx1.tq-group.com with ESMTP; 28 May 2024 11:39:33 +0200 Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 08CE4164806; Tue, 28 May 2024 11:39:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ew.tq-group.com; s=dkim; t=1716889168; h=from:subject:date:message-id:to:cc:mime-version: content-transfer-encoding; bh=Vqve763J/fnX5w3j8DDUs6X/uVtGpHOXdGrGBsbN7qA=; b=BJ4R6F1CzUj3NIBsbMaYLBCt2DbeFl2CI9KPvuf+j5wyxi/OuPHjHCHaViG8kabd5LMcLh 7jF9z9C1IraKLgL1hUCINKUagX4RFZ6fw5U2LC5ki2TXATySWQ5A1Hze0oYRRJCJ6IAwt2 ILnBSjQ3TqKJygFA2nBz8Y6tJCdx3o4NlvibJ8nkibKQGmAmo6pnpq0tnqZA2nf6URuua5 saW0r6Rb1CqJuRNMWHurRqXJl0vN+YsmhdGqceuiaPqMtpQ8ASbGz6ALlV//fhz+oINt2c LFwppkiU9K4XKYEIJ0IvywXEuZpmLP84MpJPmF01OY4iFBNwG/12AvRn7WCUMg== From: Alexander Stein To: Liu Ying , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam Cc: Alexander Stein , dri-devel@lists.freedesktop.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/1] drm/bridge: imx93-mipi-dsi: Use dev_err_probe Date: Tue, 28 May 2024 11:39:21 +0200 Message-Id: <20240528093922.194684-1-alexander.stein@ew.tq-group.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Last-TLS-Session-Version: TLSv1.3 Although very unlike to occur (media_blk_ctrl needs 'syscon' compatible removed), it lines up with the other error paths in probe function. Signed-off-by: Alexander Stein --- drivers/gpu/drm/bridge/imx/imx93-mipi-dsi.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/bridge/imx/imx93-mipi-dsi.c b/drivers/gpu/drm/bridge/imx/imx93-mipi-dsi.c index 2347f8dd632f9..8331db3b4f054 100644 --- a/drivers/gpu/drm/bridge/imx/imx93-mipi-dsi.c +++ b/drivers/gpu/drm/bridge/imx/imx93-mipi-dsi.c @@ -841,11 +841,9 @@ static int imx93_dsi_probe(struct platform_device *pdev) return -ENOMEM; dsi->regmap = syscon_regmap_lookup_by_phandle(np, "fsl,media-blk-ctrl"); - if (IS_ERR(dsi->regmap)) { - ret = PTR_ERR(dsi->regmap); - dev_err(dev, "failed to get block ctrl regmap: %d\n", ret); - return ret; - } + if (IS_ERR(dsi->regmap)) + return dev_err_probe(dev, PTR_ERR(dsi->regmap), + "failed to get block ctrl regmap"); dsi->clk_pixel = devm_clk_get(dev, "pix"); if (IS_ERR(dsi->clk_pixel)) -- 2.34.1