Received-SPF: pass (google.com: domain of linux-kernel+bounces-192036-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240528033136.14102-1-ki.chiang65@gmail.com> <20240528033136.14102-2-ki.chiang65@gmail.com>
 <40d075d0-7075-6ece-ffe3-797d7b49db4a@gmail.com>
In-Reply-To: <40d075d0-7075-6ece-ffe3-797d7b49db4a@gmail.com>
From: =?UTF-8?B?6JSj5YWJ55uK?= <ki.chiang65@gmail.com>
Date: Tue, 28 May 2024 17:53:28 +0800
Message-ID: <CAHN5xi00mi7T2M9Bj+r9b1gpw2YX5bfXbUzj5ocTSFLBQjpfuw@mail.gmail.com>
Subject: Re: [PATCH v2 1/2] xhci: Apply reset resume quirk to Etron EJ188 xHCI host
To: Sergei Shtylyov <sergei.shtylyov@gmail.com>
Cc: mathias.nyman@intel.com, gregkh@linuxfoundation.org, 
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, 
	stable@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Sergey,

Sergei Shtylyov <sergei.shtylyov@gmail.com> =E6=96=BC 2024=E5=B9=B45=E6=9C=
=8828=E6=97=A5 =E9=80=B1=E4=BA=8C =E4=B8=8B=E5=8D=884:36=E5=AF=AB=E9=81=93=
=EF=BC=9A
>
> On 5/28/24 6:31 AM, Kuangyi Chiang wrote:
>
> > As described in commit c877b3b2ad5c ("xhci: Add reset on resume quirk f=
or
> > asrock p67 host"), EJ188 have the same issue as EJ168, where completely
> > dies on resume. So apply XHCI_RESET_ON_RESUME quirk to EJ188 as well.
> >
> > Cc: <stable@vger.kernel.org>
> > Signed-off-by: Kuangyi Chiang <ki.chiang65@gmail.com>
> > ---
> > Changes in v2:
> > - Porting to latest release
> >
> >  drivers/usb/host/xhci-pci.c | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
> > index c040d816e626..b47d57d80b96 100644
> > --- a/drivers/usb/host/xhci-pci.c
> > +++ b/drivers/usb/host/xhci-pci.c
> [...]
> > @@ -395,6 +396,10 @@ static void xhci_pci_quirks(struct device *dev, st=
ruct xhci_hcd *xhci)
> >               xhci->quirks |=3D XHCI_RESET_ON_RESUME;
> >               xhci->quirks |=3D XHCI_BROKEN_STREAMS;
> >       }
> > +     if (pdev->vendor =3D=3D PCI_VENDOR_ID_ETRON &&
> > +                     pdev->device =3D=3D PCI_DEVICE_ID_EJ188) {
> > +             xhci->quirks |=3D XHCI_RESET_ON_RESUME;
> > +     }
>
>    You don't need {} around a single statement, according to CodingStyle.
>
> [...]
>
> MBR, Sergey

Got it, I'll modify it and resend patches.

Thanks,
Kuangyi Chiang