Received-SPF: pass (google.com: domain of linux-kernel+bounces-192058-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <4b825fe5-c787-4e10-b771-536b6370311c@oracle.com>
Date: Tue, 28 May 2024 10:55:24 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 1/2] perf jevents: Use name for special find value
To: Ian Rogers <irogers@google.com>, Weilin Wang <weilin.wang@intel.com>,
        Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>, Adrian Hunter <adrian.hunter@intel.com>,
        Kan Liang <kan.liang@linux.intel.com>,
        Jing Zhang <renyu.zj@linux.alibaba.com>,
        Sandipan Das
 <sandipan.das@amd.com>, linux-perf-users@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20240525013021.436430-1-irogers@google.com>
Content-Language: en-US
From: John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <20240525013021.436430-1-irogers@google.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?NHFBYVkxV004c3RWUVplM3M3bm92VVFmR21PWEhwQTNJSC92RzhSenJ4d3Y4?=
 =?utf-8?B?dzN0eUk1bW1Wb2pqN3pWcnppQ25XT2hRZExwaHJFS2FsYmp0dEE4Y2RFR1BK?=
 =?utf-8?B?bUU4SWxUQmVQK05KOGJMNUR6SjM5ZlNVajVxZVRnb1BEZ2FVRWp1VGRpTHVI?=
 =?utf-8?B?b0lSTWdCNy9ScnFuM2RSMUxWd0pLaXJaQ2RVQXFzNWg1QjdCTXlnVklZVXhx?=
 =?utf-8?B?UnF4TWZsa3VWZHMxOXNNWjY2cGdCaVByYjBJaEQvM2VqOUREMUR0SlJPMXpD?=
 =?utf-8?B?YUxUVkNlRHkyMTV1M3BGazk3bnNFNmVoNDd1enV1NXNzZGM5OGdkOStMWCt4?=
 =?utf-8?B?clgrOTlYRnZUelZ0aGd2VVlLbFZRYWhHdHJJNmF3Vlg3b3M3WDl0NUxweHVr?=
 =?utf-8?B?TDFwcW5mMDB5SG8rZnY5eElUV0R3Z3lMcWZ5RzhCRDhHUkVSb2hsUy9JejJO?=
 =?utf-8?B?YjJnRHJqUHllSmRXRVlTV0d1UXczclVkQzlCdGk3VHlOQ3dGT2hMVWN6eUhs?=
 =?utf-8?B?dHgyMVFsN2ticGszYXU5Z2YzcDEwaGQ4OVlCVXV5STN1SFYwQU1ycGlKVUZm?=
 =?utf-8?B?bTJENlRRRVRyQk5Rdk50aCt3OVNSOUw5MFl6ZnhuSEVXbnpyZ0YzZ2NZM3g1?=
 =?utf-8?B?U1NrVUFKRHdwNlQvQlZzVlBrdVdSL0VPWFBXejNDMWN3OHpFbHZmSjArVExE?=
 =?utf-8?B?UENRaUVhMUZzUjNVN1lJdnRVdE1KV1FYVmtYL3hCV3ZqY1EzMjRzellhNkZN?=
 =?utf-8?B?ekNlZitNUzhOazQ5bFVWbkdBY3BRSkRNRzI2M2F0emZkVDdYU0FSUVFJdGZB?=
 =?utf-8?B?Q3ROUVN6N1pwejZkUEtpY3RyZGg1SWJoWE5NcmR3ZzZ3TXFuZURFU01hWVBp?=
 =?utf-8?B?K2NsNFZSVmV4cHZjamFKL2dhaE5obldPWWNBanVGY1cxV2plN1hBM1FuNFdN?=
 =?utf-8?B?NXJzemlocUdqbVJXdEgxWUpQYU5HNzRSLzdpc0hkZHZuQ2k5YlZRcFFXQzc0?=
 =?utf-8?B?VTlXNjRkYVpJc1ZmL0Vaanl3VDBuOVJuK1JTUis4MjI2Wk5oMDB0YjlUVXhZ?=
 =?utf-8?B?cXVYQjhGYjIrZzh1dzY3cnk4K0FEVW40azFTRTE3QnNtZ1ZPRFFHV2ZqM0Fm?=
 =?utf-8?B?aWNRUjFISmZtWDBBeDVKY3NwZ25rbFptMHZ6cXdpenZRempFRXJFZ3lZdVYw?=
 =?utf-8?B?bUpFNy9HNGJ2dFlKUlBJVVlMK0ZzSHpGL0NkQlRUQWcvWExVaTVCbVZVbWFY?=
 =?utf-8?B?Wkw0RGhSbS8zdnYzSU5lQjlaYUZwMElWbE9TTmx2bW5CUldGNFNsN1B0WHJN?=
 =?utf-8?B?cmdjeGZBMk8vcnBXOTlpQ3diYWFCQ3Q4TkNxeG5Gc0d6MElJenF6dGx3VG9q?=
 =?utf-8?B?SjBQWERDallncVVMSmhtVnJmS0V6UndkMEg4M0hiK1IzZkIzajV0K3dHQzZ6?=
 =?utf-8?B?S3RESy9DdWF6SnM1S215WGNydzNJRXg3VEw4VFNLZkJrdDJ5ZnRtdXRxWGEy?=
 =?utf-8?B?cVVHSHhucEJVZ29wbW03UzlRblJnT0cvc1JEU3I2V3ZkWE9WNHdkcEpVS0VC?=
 =?utf-8?B?WW9BSDEwSVhMRk9GUE5RdjRvc3MxWGFEYi9mWUJMbXpmTERvR1BxZEJsNTd1?=
 =?utf-8?B?YkhNSVFDYnBZMGp0NnM0KytQRzAycVhreERwNVEzbDZpV2w3d3hneURQN0Q2?=
 =?utf-8?B?V20wVHJzRUV4UEp0Mk5EVlVBbnE0OHl6MXJyaHJVN2lLWDd5R3JsTlp5RjBY?=
 =?utf-8?B?WWYyQ1prWk8yaERMT0pweGlDZ2RwcmFWengvMTVmcVJPaHVSVjVOa3dKcWs5?=
 =?utf-8?B?QmU1bmd2S29oRSsrRC9rdGhIcWNLd3h0aUhzclNWYTIybGtMYWtIZzNHQXA0?=
 =?utf-8?B?Tnd5Lytsd2dVYVoxa1BMTDNJT2pzZ3JQeThKUW0wVE1DR09TaEdPK1ZaVTZ5?=
 =?utf-8?B?b1VwbmVTSjhBUFQ0ME5VTkFpQlhoWit4T2F1L1hlL3dnQVpUem8xY2NraHkr?=
 =?utf-8?B?S1UrUHY3c20yUDZCSUI4YjJMR3hqdDVuZVEzQlpVMG1VeDFjcDFGanJuaFY5?=
 =?utf-8?B?cnh6SUhHSUtENjFDcjhpcUZ4OXpwL1Evcm9RUFBvOHVJMUFIVU5sS3dOQTNz?=
 =?utf-8?B?a0Y5Wnp4YUNWWU5FbE9hYVpUb21tNkZDd2dLVVlEbzdJbmVMa25vOHJRN1lF?=
 =?utf-8?B?UUE9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	NUeFn5B9tlA5l/XEhG0pL7BSbYgmrs/bA4DiMRz5RCT6kf5Vpmn5vAdJ9bunL+BFt7KvDyKGxhy567znuw2i6Jq3GTHMN51OpQd37lx2ne4GPRPNTpBrsSjAOZXraeSyz6cspzbMyafWzhRwG3uy62kfd2uyXExSMYqotpcttV+Q+1Bws58+EOhiomXASa88RF9ACe9qQm/A0d0k8CJW0eDK5dXtPpwnpqM+o4O8xHC9NsANzQq4OeWvPfok3KhPekV+jhiQN/1ay5aogx/p/zunig8RlM5xDAvZFgPK9T5Ga952WEpU/KKCsxdqIFwGOoAYHal+UUbdxlgq3e10t/NmrwHPJF62i7ne3nTUoCUz/gBQIWC2cqxXQfOrkgIdXcm05Xxftgz+A/RZoUPCmkjmNPLtm8VzhWzriUiqc0hEMCmbJ8zvzeKHVtlbezxb0PbxIMl8+cB8Od6ieSU3+JYWlDouxeFYdIfNDEOMf9RRxtpUyVIiovl4EA35CsoVRbInZUeKp7mSuxN7ghtt9+Vw/nJg5VOUteOIXIbjQZdrCSpEthxZHxAV7sMXsTZ3A5+FRpVk1l9uAL21PHn12ygksR0VRSIC8xh54rmqQXM=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 27b10740-3898-4a7b-dccd-08dc7efc4e5c
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 May 2024 09:55:29.3597
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jrWfrkSYIT4JU2gaOnhKl2x2dfelg6jycLK7XCa3X2mUQkau1Y0xNBJioahzPHgtMPKaPKnfdxMNmTMEQpYwlw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR10MB6880
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.12.28.16
 definitions=2024-05-28_05,2024-05-28_01,2024-05-17_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 spamscore=0 suspectscore=0
 adultscore=0 phishscore=0 malwarescore=0 mlxlogscore=999 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2405010000
 definitions=main-2405280073
X-Proofpoint-GUID: UT3CheZFUTho6X4415JdDiq03fKv-nM3
X-Proofpoint-ORIG-GUID: UT3CheZFUTho6X4415JdDiq03fKv-nM3

On 25/05/2024 02:30, Ian Rogers wrote:
> -1000 was used as a special value added in Commit 3d5045492ab2 ("perf
> pmu-events: Add pmu_events_table__find_event()") to show that 1 table
> lacked a PMU/event but that didn't terminate the search in other
> tables. Add a new constant PMU_EVENTS__NOT_FOUND for this value and
> use it.
> 
> Signed-off-by: Ian Rogers<irogers@google.com>

Reviewed-by: John Garry <john.g.garry@oracle.com>