Received-SPF: pass (google.com: domain of linux-kernel+bounces-192068-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <40bc3142-c7be-4dfc-a2ff-6ac209112aa6@nxp.com>
Date: Tue, 28 May 2024 18:02:29 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/1] drm/bridge: imx93-mipi-dsi: Use dev_err_probe
To: Alexander Stein <alexander.stein@ew.tq-group.com>,
 Andrzej Hajda <andrzej.hajda@intel.com>,
 Neil Armstrong <neil.armstrong@linaro.org>, Robert Foss <rfoss@kernel.org>,
 Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
 Jonas Karlman <jonas@kwiboo.se>, Jernej Skrabec <jernej.skrabec@gmail.com>,
 Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
 Maxime Ripard <mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>,
 David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
 Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>,
 Pengutronix Kernel Team <kernel@pengutronix.de>,
 Fabio Estevam <festevam@gmail.com>
Cc: dri-devel@lists.freedesktop.org, imx@lists.linux.dev,
 linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20240528093922.194684-1-alexander.stein@ew.tq-group.com>
From: Liu Ying <victor.liu@nxp.com>
Content-Language: en-US
In-Reply-To: <20240528093922.194684-1-alexander.stein@ew.tq-group.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
 =?utf-8?B?WlJGKzA3enMyZjM2R2tEeFhQZGFFK21PWXlyTHowRVB6OGRBRjUwZW1QcVMv?=
 =?utf-8?B?RWVNL2ZtZWcxLzg3bDRleFQ4YlFDUThsYkZMZ2h0Wk42WTB6SDZLS3RUckdE?=
 =?utf-8?B?ME83WmR0dWMwbkFDSVNrbzBKdHBmaFBnMVM3aHF5YVZpM0xoY3VvU0lrNTFv?=
 =?utf-8?B?ckxsa2FpWGpLTDdMNGJyYkRKcXZvQnA3Uzc5QitYYXJ2c1hOSTZFSVpGbjNn?=
 =?utf-8?B?VEYvaWhMQ0prV0NoQUZaMzV2bW85N3Bta1FqTEtzZGVFZnEyZFZjK3pQYnVy?=
 =?utf-8?B?dmZqSWRSYUEwUmlwdXdvM2RwT3BGRkdFblBmaWFjenB0YlhKaU82cFRhN3Bw?=
 =?utf-8?B?Uzd3L3Z0WUFmNzl0N2Q2SGgzK28yc1NDTXBoeVZybEpSdmgzZnNRaS9xTEIz?=
 =?utf-8?B?eDI4Q1B0d0ptcis0dzU0S2lwdk1vS1hFcGFDODY2SjV1TkJlWnZFWHNnWG54?=
 =?utf-8?B?WGlmOFYwVlpHTjQwRkVYcXJTb0tETVBOSjMxd3BDSklaelN6VjJDVWd3cytw?=
 =?utf-8?B?alQ0NU96NFVLT3pGVjNhSzRNSFdZOTVrbTJ5M2FQY21xMHVGRzVyQTZPQ1ds?=
 =?utf-8?B?enNHZ3lBSGpGQTRvRzE5c3B3Z3B3RjY4UVdKMTVrcGNoczNtNHJnUklWTkZz?=
 =?utf-8?B?a2d6RjBWSGtwYlVtMnBKSmJZT2JEODNjcjRDNnFSWjZiblpvQ0ZyTGNqWGlK?=
 =?utf-8?B?SDFQeHl3Vkp2SWFvaEhTeEYvRy9tUzRzelA5YnlPc01LZm9yNFZpTDgwcy8v?=
 =?utf-8?B?NGczYXZ1OFRmRlpkdGZiWnlVZ0JXTEpRVDhpS1lIRjJTQmJFNzQ2dWxuNnNQ?=
 =?utf-8?B?aGRKOUZKeWhHRGl4ejNra2gxSS94SEMxM1JEVGZDZklKOFdoeUpXcXBkSlNO?=
 =?utf-8?B?VHJTZmxQRGlLeWt5SEdvVXhnYXdhUUZwbVA0QUhCV28yY3pYdFVxQWtqdE9o?=
 =?utf-8?B?ZysySXhQNkdSQXpOcHFyMmVxUzBuV0tLRjJrb211RjMxZ3IyK1p1SnZNUjdr?=
 =?utf-8?B?UmhGQkpHWGh4SER4MEREbmdmVDZFRVMvQzNCR0U2YzkzVWlPV0lPWjhvVWlI?=
 =?utf-8?B?ZVlnN21BU0FUbXQzRDJsOHpPMEhaYXI4dG8zUzhRcTFSTjN3aDZBbzk4Z01D?=
 =?utf-8?B?TUxBODE4UUduY2U4TFViaHJ5WjZkbnhYQVBFOWhrVU0xM1lhRG1tUEZJdWtx?=
 =?utf-8?B?Tmx0NnBwZ3pMOUxNaVRyU29nTzllb01zSHhycW9Wd2I5czNsM0hCVExuZzBQ?=
 =?utf-8?B?aVpaakUrVFZxaFZ6a3pUNHhReVZNajVjMkplOWZxbWRmaEFZSDJhSS9iMkU1?=
 =?utf-8?B?b25zbW05QVdLTHJFSXFYZktnTys1NTZKaWhkSFV6bnk1aEgyak92QzZ5M0pN?=
 =?utf-8?B?dVQ5aTFPN3JMRUVoKys4M1pKbEpLekxtS0FKMHJUSC9pK2lTZGpQQlI4YlJv?=
 =?utf-8?B?ZGo5OGFqam1NQVRvMWZDMmZkYnBGNllObHEyU25TWTFJUGxzNVlTUVVlbW1x?=
 =?utf-8?B?RThoKytnaUNmZ3F2QjQ2d0RzUDdzOUk4bGE3UW5yYk5GMTl4SHViRFhpS0Fp?=
 =?utf-8?B?TFR1WEdKSndJdDV4ZzAvdldBbXo0MmEzNVZYK1BsN3JOYlNacVVpY1cwcnhF?=
 =?utf-8?B?UVdXbFhhWE0rUzFweENCQ3FnMXZ0VGRoMGhzY25kZlFDYUxsU0xsK25NU1la?=
 =?utf-8?B?a2hoaEJWLzNVWE0zRWRxbFpDVGRRb1ErUWZxOGRHZ05nZEVuS1VNV25ZWG56?=
 =?utf-8?B?YTRXUEIrS3I2dTY5ZHQvbkk0Q0NNUHduWS85YUJBSjJxbWRPS0F5cVcrNzFo?=
 =?utf-8?B?emhvamp0N3MvSUh2aXNJZmNoRnBrRS94S0pOMGlDb0lSN0hmZERLSnVvV3E2?=
 =?utf-8?B?dEw5T2tZS0pJTzFPc0tzVzlidlNUOXRCaGpMSnc5N0ttd1FGL0VPZUpkWVFN?=
 =?utf-8?B?M2NXRU1xYTNJemVZajZMbkxGaEdDallsbGY1djRjc2RBdVUxd2E5Y1JIT0RZ?=
 =?utf-8?B?SUVCNng3YS93WWR0QzVBMlRIZlhZVWlJZUdvdnh3dGFNc1BaeWE4SEMxVWRt?=
 =?utf-8?B?alpLeHVsOGEyOXhzTTFuclJaeklFclRxK3NYbTYrcnRqblRvTlRHVXpUcTF1?=
 =?utf-8?Q?dMxPfz5/63qJw2E8dGEAJJmmn?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dda5d92f-9318-4957-576b-08dc7efd3f7b
X-MS-Exchange-CrossTenant-AuthSource: AM7PR04MB7046.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 May 2024 10:02:13.8639
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +xQC/zyldLimadQH3AAXeQurYcxpQGrq71zluCBIz4wZaWLIfXerJMOuGoRK9ZNus8SIswEq29uKsC22mNcCkQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR04MB10874

On 05/28/2024, Alexander Stein wrote:
> Although very unlike to occur (media_blk_ctrl needs 'syscon' compatible
> removed), it lines up with the other error paths in probe function.
> 
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
>  drivers/gpu/drm/bridge/imx/imx93-mipi-dsi.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/bridge/imx/imx93-mipi-dsi.c b/drivers/gpu/drm/bridge/imx/imx93-mipi-dsi.c
> index 2347f8dd632f9..8331db3b4f054 100644
> --- a/drivers/gpu/drm/bridge/imx/imx93-mipi-dsi.c
> +++ b/drivers/gpu/drm/bridge/imx/imx93-mipi-dsi.c
> @@ -841,11 +841,9 @@ static int imx93_dsi_probe(struct platform_device *pdev)
>  		return -ENOMEM;
>  
>  	dsi->regmap = syscon_regmap_lookup_by_phandle(np, "fsl,media-blk-ctrl");
> -	if (IS_ERR(dsi->regmap)) {
> -		ret = PTR_ERR(dsi->regmap);
> -		dev_err(dev, "failed to get block ctrl regmap: %d\n", ret);
> -		return ret;
> -	}
> +	if (IS_ERR(dsi->regmap))
> +		return dev_err_probe(dev, PTR_ERR(dsi->regmap),
> +				     "failed to get block ctrl regmap");

Missing \n.

And, a build warning:
drivers/gpu/drm/bridge/imx/imx93-mipi-dsi.c: In function ‘imx93_dsi_probe’:
drivers/gpu/drm/bridge/imx/imx93-mipi-dsi.c:837:13: warning: unused variable ‘ret’ [-Wunused-variable]
  837 |         int ret;
      |             ^~~

Regards,
Liu Ying

>  
>  	dsi->clk_pixel = devm_clk_get(dev, "pix");
>  	if (IS_ERR(dsi->clk_pixel))