Received-SPF: pass (google.com: domain of linux-kernel+bounces-192077-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Tue, 28 May 2024 12:04:49 +0200 (CEST)
From: Ricard Wanderlof <ricardw@axis.com>
To: Andrzej Hajda <andrzej.hajda@intel.com>, 
    Neil Armstrong <neil.armstrong@linaro.org>, Robert Foss <rfoss@kernel.org>, 
    Laurent Pinchart <Laurent.pinchart@ideasonboard.com>, 
    Jonas Karlman <jonas@kwiboo.se>, Jernej Skrabec <jernej.skrabec@gmail.com>, 
    Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, 
    Maxime Ripard <mripard@kernel.org>, 
    Thomas Zimmermann <tzimmermann@suse.de>, David Airlie <airlied@gmail.com>, 
    Daniel Vetter <daniel@ffwll.ch>
cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, 
    kernel@axis.com
Subject: [PATCH] drm: bridge: adv7511: Accept audio sample widths of 32 bits
 via I2S
Message-ID: <91472c14-3aeb-766a-1716-8219af6e8782@axis.com>
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?fyERMwcgVJwcaADVUmp3sdXwUmng3nfhOd21tWwtj/UNA06moxt/3Twrt8VH?=
 =?us-ascii?Q?vpe55qmeuoJdmw9W+PerQTrKk1JD9s3LhldjYaZ5EpVk7G28Zpi5Hf/tlyFM?=
 =?us-ascii?Q?8uM6cmRY5KzR9X8vF30xeG3wfcZ80o2zs392TcE9RRQhqHu7GlV+AbS5Yy42?=
 =?us-ascii?Q?tbsJYn+2hVb6nk2SNbi9omHTxjYO5pDgC9uMBHNyurFZBugdbtrEt/LcddRP?=
 =?us-ascii?Q?BQm08AC1F5PN5tPVv5OFnaOMYAtPcfu6gKE8KbdQ8bmVw2s530yGNqtw/Kqp?=
 =?us-ascii?Q?czpJXZPrtzrDtT18eRs3Btfr/hMIIfi4yRenPbmsxlouAmyT8oZeODApNjC7?=
 =?us-ascii?Q?vykz0nneZDmLr9yMu7ECPyw3wpjWcDSLrjZTztRI0HwZQ9YnOuHsFjzr/oMZ?=
 =?us-ascii?Q?jkOu6VUQx5RPZH18adDmqICq8U5xIxs/gB6JX9E9NNEBps4Jhb2tyIPXkGxE?=
 =?us-ascii?Q?bnqQ1FXXtJY2Kasby2DzNgIf9CJwXXJX+XAU1s+M6N7GKoyHA0pYQd+AqRWQ?=
 =?us-ascii?Q?hiP9u5hl2N80IQ5F+Acu3SgsnlURo94cgbmS65LKpkF2SXPMlbgrfcO5Kuhs?=
 =?us-ascii?Q?of0jxEU5Ibp7ziRyPLDae6Bu0GlJJp1NhUaTWRDA0x9oowPwKIMZLKbYwmow?=
 =?us-ascii?Q?H7nghT+pS/SfW+s6Mmr+/oiFPY9NrOZXwQyem3pRTJiufByDY7YlqeeIbf6X?=
 =?us-ascii?Q?InDRNH0sL+xCOXd023pv0EtZqNGRngc6QohZhyimnzNwkWhVwBTM1zWMfkJu?=
 =?us-ascii?Q?ZAGWETixWSkJ1j7eKtu60CkH4g/DjrqEBfZAomJZRmon0XFVsre6rhNlUyfu?=
 =?us-ascii?Q?/el8NEp+jh70rWR7XZKOL4zN8Tc/EzFpvb9/In42YixiLNxbLUJA0pN5Gv3R?=
 =?us-ascii?Q?b7Bm38T52uZ/MY7tpCrUPoT0jH6U8zn+MvyIllKTCfTny0BhL+hGrWJXXeV+?=
 =?us-ascii?Q?ZBto+3Mugp3NqXmnLjsHCIOB1t/xspeWDnKK3iKrDvCJIw9h0jyQ10YekWVH?=
 =?us-ascii?Q?Pj2f1kvOS0lvnu0CTRfDosXYWydMp8anRVcYoDoe1YA7Md8Hvt6bVZtxUGRb?=
 =?us-ascii?Q?D4JMXogHNKkoL38HE5Q8FdTiXE1gJ2+VXaiXBvLlzHGPzK05jpqC1c1MFkGi?=
 =?us-ascii?Q?mC5+CwBjHGAatWJhlMCOtCe17CMqNz73IIpf6tZjIsvCdRSH71kB9rK/7l0/?=
 =?us-ascii?Q?DcUCUMOjtUZ04YIpnguroXXCfME7SRSeJvWWpNu3U55UYrU3WzkHKMuNnHE0?=
 =?us-ascii?Q?TOcVBXzdcBje0xJzLIp5WKfjz2W9rC15Ji8S2zjlWb4gMuMw15hNqiSsbDmC?=
 =?us-ascii?Q?yPfHL+r/qJe0SOCHK8bf1epOAwWILtgDlctWV4qsWbJ8yg6SUaDTb7pQlCqB?=
 =?us-ascii?Q?jfTsuDIL8Qi7GdnRvV0R2/dWmjd1xIiwxzrI23ebNiwiMeXdoJEFyQEgYzTa?=
 =?us-ascii?Q?iH3ZpEBzibll/O0rauaIS1atrt7pDIFqk0ApdGsEsdeFILTrbGLjRJLniYoz?=
 =?us-ascii?Q?s8HT9FAOdBp9IyXYTX7+n6h8FttjwRq41hMkYrpXHrIznNSckMGLdW38rJcV?=
 =?us-ascii?Q?vcRNVhMQwePsC/yWtRfXaTJ4m8YoiYd45fn4LFH1?=
X-OriginatorOrg: axis.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c79eb05c-e913-4f6a-0ba3-08dc7efd9d44
X-MS-Exchange-CrossTenant-AuthSource: VI1PR02MB3229.eurprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 May 2024 10:04:51.1464
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 78703d3c-b907-432f-b066-88f7af9ca3af
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: U88QP//je2sjWMktlEMG2ddXF1gtMCIvd7LbbGQhqz+RPx7zwh2LOvm9gwXTjoNHZCF4sDKW+Szz2UCpV33RCg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA6PR02MB10739


Even though data is truncated to 24 bits, the I2S interface does
accept 32 bit data (the slot widths according to the data sheet
can be 16 or 32 bits) so let the hw_params callback reflect this,
even if the lowest 8 bits are not used when 32 bits are specified.

This is normally how 24 bit audio data is handled (i.e. as 32 bit
data, with the LSB:s unused) and this is also reflected in other
bridge drivers which handle audio, for instance sii902x.c and
synopsis/dw-hdmi-i2s-audio.c .

Signed-off-by: Ricard Wanderlof <ricard.wanderlof@axis.com>
---
 drivers/gpu/drm/bridge/adv7511/adv7511_audio.c | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c b/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c
index 61f4a38e7d2b..4563f5d8136f 100644
--- a/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c
+++ b/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c
@@ -101,11 +101,14 @@ static int adv7511_hdmi_hw_params(struct device *dev, void *data,
 	case 20:
 		len = ADV7511_I2S_SAMPLE_LEN_20;
 		break;
-	case 32:
-		if (fmt->bit_fmt != SNDRV_PCM_FORMAT_IEC958_SUBFRAME_LE)
-			return -EINVAL;
-		fallthrough;
 	case 24:
+	case 32:
+		/*
+		 * 32 bits are handled like 24 bits, except that the lowest
+		 * 8 bits are discarded. In fact, the accepted I2S slot widths
+		 * are 16 and 32 bits, so the chip is fully compatible with
+		 * 32 bit data.
+		 */
 		len = ADV7511_I2S_SAMPLE_LEN_24;
 		break;
 	default:
-- 
2.30.2