Received-SPF: pass (google.com: domain of linux-kernel+bounces-192085-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <a8b18cea-cc04-47d0-8ff0-b02dd087dc73@oracle.com>
Date: Tue, 28 May 2024 11:11:24 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2] scsi: libsas: Fix exp-attached end device cannot be
 scanned in again after probe failed
To: yangxingui <yangxingui@huawei.com>, yanaijie@huawei.com,
        jejb@linux.ibm.com, martin.petersen@oracle.com,
        damien.lemoal@opensource.wdc.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        linuxarm@huawei.com, prime.zeng@hisilicon.com,
        chenxiang66@hisilicon.com, kangfenglong@huawei.com
References: <20240424080807.8469-1-yangxingui@huawei.com>
 <824c34aa-7c4c-4edd-b41c-f9b5ff5aff03@oracle.com>
 <12ea14e9-5821-b2b5-16c1-ac48985927d7@huawei.com>
Content-Language: en-US
From: John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <12ea14e9-5821-b2b5-16c1-ac48985927d7@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?YitLcGs0OG00cFRsaS9BMHNTQm5sd0dlUVM2OTNmUlYxa2VGaHF0VEpwVk5B?=
 =?utf-8?B?YWUvQXBqRXZtMFZ1QnVWWU1BWUZXZEZBZldjWE13dEdsRUZyRlZnbjloeEYz?=
 =?utf-8?B?TkhPN3ZocGswb0kvamtGN1VpMnVJdTUyRWFvQm9HbjRaOVJLSnFMRzFSQkZw?=
 =?utf-8?B?b1RpOGJXbUVHQXZQdjE5QlpxT0tST1BRSmd0SCswZ0cxWTF6ZC9XT0MwSEd1?=
 =?utf-8?B?RnNrZzRJM0dXSThKMm8rbTg5UDBlTVhON0dsYXhIcFphYWQ2Z1VVTHRyMVRk?=
 =?utf-8?B?RjRKb1RJVWNYcFZheCtzY056ZkxJRlQvSGNCaXY5cnpyYXp2cnlsZU5la2Zz?=
 =?utf-8?B?OVNWcEdzSEJ6U3Nkb0gxZWRnNmxtcTM1Q3d2Um9wWW4yaGI4Qkt3VjRlRWFM?=
 =?utf-8?B?Y2RNS0ViUlNTVEZaUHJMSVVYNzhaQmlud1BoMkp0Rld1bHdQWWRzZ1ZUdGxh?=
 =?utf-8?B?djFuYVQ0NzdQUDNWT1RJOWVLMldDdE83NVEydHcxejBiS1B2U0pvRlNaeWRm?=
 =?utf-8?B?VW1Bd25OZ1dZSC9Fa2QxcG04MnlQUEovK0QyOWZWbHhUOEJjN2ZVUnJoQlA4?=
 =?utf-8?B?TnQ4b2NtRURoY3MwQmRDUUZSb29hU0pmRVNTV2lXOCt4ZUowM1YyUEJQdVdr?=
 =?utf-8?B?MVFLUDVLRDdqWiswd0l0ZFptY1dlbkNwWm1za3JqdENybUIzZ1AzN0dsRmdr?=
 =?utf-8?B?NWNrMUlHTStoTUFDd0svMnNwRnJ0VVdqaDZFc2Z4Z25VNkNZZExWK0lVOG1s?=
 =?utf-8?B?YXJ2Qk1xRnVUcHdESERWdFBzUy9CY1pETkhUTUtISWhjMUMxd2QyNW15bW1w?=
 =?utf-8?B?U0R0WTF3dWtlR1dwWVZvejlkOWJMT2E0TzM2RTBTaEdtenUxdVMyK2ZPc2RM?=
 =?utf-8?B?Zi9ieFpVUWFxTWkrMWYvenBlakU5RTQ1Y1JTZTR5NDVYSEdmbWZhV1pWRkUz?=
 =?utf-8?B?RU1zQWM4ZzRsMTNSTWp6NVg0Q1FBKzFONlZVQ1NIRk5aL0ovM0l6VVhrUHdm?=
 =?utf-8?B?TWthd2E5QklEMDVmd1hkSFdCOElqc2NTaGpNYXNsaVJDdTg3a3E1NlNwV1c3?=
 =?utf-8?B?S2JqYnlUbmQvS2RucENKMzlaK3lqZWMrS1JJYTQ0ZUFxNExiZ1VmWDNMemFq?=
 =?utf-8?B?amEydks0cVBDV2p6ZUQ0VnR2YVVuMkJHNnR5VFlLVENySnBaSlRIQUtEMk5q?=
 =?utf-8?B?dUlsbVdwZkZzdURCUFQ5ZE80MjhQRld2Ym1WY2J5bzI1SFhRNCsrSGJRZlpR?=
 =?utf-8?B?UTFYY3BCVEQ1M28wb3dDTTNSdDhudEVmV3JNNEtia1RESHgxQ1ZsRFhOa3Mw?=
 =?utf-8?B?bCt1T0lWc1VMNGJPOFI1cmJwOThLZHpDTlNTR0RFUEJnNzZ0Uy9aZG1JUFdU?=
 =?utf-8?B?UWJrdFBwTUdDeWlRZjdvMnlkZ3QvR1NRa3VjdDBFVTQ5akFwL1BOMEw5VnlV?=
 =?utf-8?B?endTRVA2NUhNWE55bnAvRnJJSXhyMllPTnZnaHBldjFHbVo2a1o5SWUrTThy?=
 =?utf-8?B?TWdBaXpaZ2s4djhOdStzTHJ2WDdKQ1dOYXNYNjlwL2FOY3RBbWlsZ0dTRUE0?=
 =?utf-8?B?ZCt0bEx0QXFDQnVSNXRwWXpqVFBhZm1jaGdydWhjOTBPZG4rYVdZQVNyTWtH?=
 =?utf-8?B?d3RnYWZhQUs0b3FSWDdTSmdjTVpBbysxbjNCeHkzclhKN25TY2EvV25qU2VU?=
 =?utf-8?B?MGdTdFhnUHFsK2hkT3lPZnlUS3FvSERENTFQVlZhMXRUNmFaaEpQb3lRUE5I?=
 =?utf-8?B?RWo2MVhtQ0MwTkhtZ3FndWZtOWlrUnZsMkFUbGRZRm1hUWVsUklDQk5wbzhp?=
 =?utf-8?B?VWtaa2krUExaNGNTTy9YNnFENVhkUjNmdTVzcFRBQXJ4VU5Ic05NbWIxdzk5?=
 =?utf-8?B?R01UTUFwMGxhNkRjM09ncFd4WFEzczZ4WVpnbjk2Q0F4eEVhTzFoK1diNmIv?=
 =?utf-8?B?Qlp6YTlYSVk2WEJLT1k2a09rZ3hJaTVuRWo3c3krai9kbDJSNXBPUWdyMzNp?=
 =?utf-8?B?SVkrT2dZMWZRUXhiWHFtbnMxSloxTWVQa3JBZlJuRlRaSDl3VDZLOGhUYnpH?=
 =?utf-8?B?SE9RSmFVbFVnQ0dKWGV1dXNTLzV0TkJvZUlLOTdiYW5PTTFFRHNYN0JFQ2t2?=
 =?utf-8?Q?EY203mozIvKBX/JMj6lFs7W1y?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	nMF6tTbVkXqapBvsEfsnrN0/gFtArOXyZt3+12sjO4Rvp2wsi+HdCttypDjoBLLuJezV6nFvJ090OnoYbazFVp616NCUIr3g8RL3ykhQTp3z0UrdCwhroDeEwjIWqSGOepCoyPnxKT7vExIppyI+b1yCo8CR8pY1mHRnXabsct76aQDbz+HXHVKvtPtVOv9CMNRSroHi8LsMp0681nc1AljKEwFfb5JoSxMdVcOZex3geGSQyklM8tvlc1S+3EC0trHDgAxyFwJ3jXnaJPLfZSGpoxvEzCc3AsTIcr66mpNPls/v5s6UjPevg2xXqmF+V8aHLgGjTm/s+qjlCgDxcTafYix8eyRThC7AqUaPnv0FlqPfcRiemB2LsVliWVNXe9hpFbTEi8zZGMhULLGlnGPQepjsCm2qfm9T0wV4NAtViLV+s8XaXBvw64Q6c199bKYcN4duu8GqHkyLybnhB0F8RZ1onXi1fAPADyFo+bIZ9304oAiz9cBj6hIW5J8Sw6nHRT/PjYe2qQ/eOVZU482ERLee0/YdqYQSQ8Ee0xPpilwMI9SSNj9I6Mbm4zRZ9dV/VCxeHf9oectNcjKkRtN8Ic9MzxqqOBm6C58g/y8=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 704425c6-c643-4e65-9fd8-08dc7efe8a18
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 May 2024 10:11:28.5305
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mHgf5B22A10PbxtpFnq/c60OTlkhglQHE4IWrFQ6o3dZUBXDCSwqs207cBR9WnvS1nz0TCdW2V9OAwSr/SsNXA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR10MB7071
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.12.28.16
 definitions=2024-05-28_06,2024-05-28_01,2024-05-17_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=778 spamscore=0
 phishscore=0 bulkscore=0 malwarescore=0 adultscore=0 mlxscore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2405010000 definitions=main-2405280076
X-Proofpoint-ORIG-GUID: Fy-_hBkxDLn07oIV3gUFEDBwp0RDzprd
X-Proofpoint-GUID: Fy-_hBkxDLn07oIV3gUFEDBwp0RDzprd

On 25/05/2024 04:08, yangxingui wrote:
>> Why do these new additions not cover the same job which those calls to 
>> the same functions @out covers?
> For asynchronous probes like sata, the failure occurs after @out. After 
> adding the device to port_delete_list, the port is not deleted 
> immediately. This may cause the device to fail to create a new port 
> because the previous port has not been deleted when the device attached 
> again. as follow:
> 
> 1. REVALIDATING DOMAIN
> 2. new device attached
> 3. ata_sas_async_probe
> 4. done REVALIDATING DOMAIN
> 5. @out, handle parent->port->sas_port_del_list
> 6. sata probe failed
> 7. add phy->port->list to parent->port->sas_port_del_list // port won't 
> delete now
> 
> 8、REVALIDATING DOMAIN
> 9、new device attached
> 10、new port create failed, as port already exits.
> 
ok, so next please consider these items:

- add a helper for calling sas_destruct_devices() and sas_destruct_ports().

- add a comment on why we have this new extra call to 
sas_destruct_devices() and sas_destruct_ports()

- can we put the new call to sas_destruct_devices() and 
sas_destruct_ports() after 7, above? i.e. the
sas_probe_devices() call? It would look a bit neater.

Thanks,
John