Received-SPF: pass (google.com: domain of linux-kernel+bounces-192066-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <a173525f-33a9-43ee-8b03-a277810025fc@oracle.com>
Date: Tue, 28 May 2024 11:00:47 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 2/2] perf jevents: Autogenerate empty-pmu-events.c
To: Ian Rogers <irogers@google.com>, Weilin Wang <weilin.wang@intel.com>,
        Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>, Adrian Hunter <adrian.hunter@intel.com>,
        Kan Liang <kan.liang@linux.intel.com>,
        Jing Zhang <renyu.zj@linux.alibaba.com>,
        Sandipan Das
 <sandipan.das@amd.com>, linux-perf-users@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20240525013021.436430-1-irogers@google.com>
 <20240525013021.436430-2-irogers@google.com>
Content-Language: en-US
From: John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <20240525013021.436430-2-irogers@google.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?Q2NZdzJPZG1xeVpnMFI2S2RvUzRwMng2ZnpzelRhSkFGYUYxZGovdjBFRFRi?=
 =?utf-8?B?T3R3bWpHckhtbVlNRmoxbEgzOHlhRFhPSWRTaFVTM3lCUmFkeWE1VU5USkNR?=
 =?utf-8?B?amtiM2pBT0J5RlJJWXFaL3d1VmVrNzBhUDd0SkNyeS9LWk1Pd0JWbEJucm1m?=
 =?utf-8?B?K0hKa3dvMDlMbFo5YU9kbnB5N1E4Y0NJL2ZTYU51dnhEKzVBWlIyMjB3YktF?=
 =?utf-8?B?OTBXVzh3VHd4TytLUWhlREZwYytBaEZTTnY4Sms3blNYeVRIc2pjS3N6dUc1?=
 =?utf-8?B?UCtSUS9BTXpCSzhPdWxKdllxTW9LVm1HSjExTjhFVzhhTXZaTDJZOUIxMlV6?=
 =?utf-8?B?emZxc09JWlVTcng1Mm9RTDBtU0hmUHQ2NDV6NDI2cXZRb3BGa2FjTzJIb0ZC?=
 =?utf-8?B?QjJnUmVsUkwxWjhKOWlSODJXTERqdjlyKzZBUVovT0pEMXJpaFB5d1JqQXFP?=
 =?utf-8?B?c3NnMXZsOU1SL1Z6U25aeUhURzl0QXNUMlcrdmJpZGpzU05rM3U2NUNRanp4?=
 =?utf-8?B?bXVLZEZ5QzFDOXB5NkJRZDFTSi83d3NDWlRWeEl5Q1MzejVLdGFsQTBkaFNy?=
 =?utf-8?B?SnNjTU9ha29XMlNFamNsOHpPck9pbDBmeFQ0TVprUzVHenJ0c0NHWTFnZzB6?=
 =?utf-8?B?U1dFblZMSVJpaVE4VHdyOGxzY0o3QVhxZGRMV0tFWS9ha3JPN3N3UEpSaCs0?=
 =?utf-8?B?ZFNmZTJUTlpJdUMvaURsS1BEemx0NkV1cUllMnN2Qm1NT2FQNUowSGlHMHlr?=
 =?utf-8?B?V0QwQ3pDWmlSK3hmbXQ5Q094cks4NWJEWWMxZ0ZFd1ExczV1ZU9pME1rUzdI?=
 =?utf-8?B?eCtQaWNLeHN0Yzh5Q3VnZnMrZVQ1czcvQTRhZ3ZrelVOU3NGbStDTE10UFZD?=
 =?utf-8?B?VlIzZ28xc2xzSjNRcjFUMzhVOHE1M0YwZ1o5R2tDTGdEV2d1eExzWXJOK0hj?=
 =?utf-8?B?WExIQXlWUVA1RDRmMkFpbVBYa2VQQS9pTmFMaHkxK2UrRklOdU5YM2VEUXNr?=
 =?utf-8?B?VVRuVC9ackVXNk5MZUhONzF3Z1MxVHh4L2ZHdUZ4UjhVME5HSklHTmkrSlY2?=
 =?utf-8?B?ZUwzcit2UitSMWxlMCtEdGovb29BTm9BNHhhdUNDTXBZNG1ERXZocHJiOUZY?=
 =?utf-8?B?WDlkUUNwV2dRS0RibTZWcDBzZ2ZMTjFqbk8vL1JXb3pjUURBVVJNeWttbHNF?=
 =?utf-8?B?cGIvZXdYeUQ1OWFJTDJ5UWdsMVZLcjREcjV6WDVzbHVOY2RxM00vcHJoNGNk?=
 =?utf-8?B?ajBlQndVL2JvZlgzcVQyVDBIS1BYSFJ2amhwWktacHNSMzdLUEJmM0I2dDVt?=
 =?utf-8?B?RFhaNWNzd2pzcS9kKy80NEtNSFZXOFlqYUN0ZllzWUR4bmdEVHBnaGpQWDgr?=
 =?utf-8?B?SndTVEUvZU1rSXVBQ2VoMFovVzFwUGYvWlhSb2o5S0ExYkNqMG9rU214aFkw?=
 =?utf-8?B?R1VXUFFJL3lJWFo5OUQrLzBUMGtOTERES0dyYXM1STR6d1ZpQ1RqRHZoUDhx?=
 =?utf-8?B?VFBLTTdNZ2hFaWhHMnRxdnJxYzQ2dlFBRE9XdFVWM1YvVmxabXFmaERneGZm?=
 =?utf-8?B?U3E1ekpvQ09ERDl1SkQ5Z1RNcjZlWk1IN3RSWXlzejZGc0VwTUpXbzlYandj?=
 =?utf-8?B?NVdWazdadlhmekhpd3RPQlVmaFNhWEFlZHVPOGJ3bEtxN0hnVFZrbUZOWTAw?=
 =?utf-8?B?dStlQ0hLM1lZdVZhWG4yc1RNSlUwOXdldEE2N0lxMFdObEJGcUthWmFkWG5t?=
 =?utf-8?B?dnFQSERDSTJ6Z1NrTUJDZzZTd0NUQmdvaVJUL0sxK3FUNnJDNUwwOUFsRDRz?=
 =?utf-8?B?cnpxTVNidEFDdVBVV0FsN1dBMnpzUnBvbFZZRGVFWUx1dklodkk5TCtvZTll?=
 =?utf-8?B?MnR4dHkvUHoxd3FWNTFYQ0lnSWZGelJ0QVBXTHk4RitiZXZyVDNNUk8vc3VG?=
 =?utf-8?B?QytuenVlMmVFTGo1NXZ5QXBZYnl5S2pyMTZadkFXVENReUNCcTYydUs1TTc4?=
 =?utf-8?B?a2o1ZzRUZ1docUZlR1Rjb3YvbjdmdnR6WTVsM2pEOXN1c2UvdXc3QzRUT2xl?=
 =?utf-8?B?NkpOcnIwWHQzN0ZvRDFHVitYNlp3aDg4OXlDL1dpZHN4dFdjcnNKK0c5aDZQ?=
 =?utf-8?B?aU5CSEFoVE0wYW5VeVNyYWtXZ1huUkd3QWlORzQ0VUpQZE9PWkJnYm1IZ2RU?=
 =?utf-8?B?YUE9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	dIBoA60eEFJELwWCNejWtmTBy2ZyZLWQmflqgpLH6HLwMPkWrxYqQP4i7O54MLyFmSX3VbyWtTV5d0gk1ICBeFcES+MGXFMk/FYohU07ACxOTO3kpn1jN9l1d1kc306UY+Dg1UiJkN1xHGWZMr+hoXOAQFqb5t/wvgO1Et/GBAwiDRhV8qFxPlrRu3HesHSk1ds9pdtxANpAWL47gXEtkGUCvgtSu4GonNnYPifRB5plQN5xqw68mgGir1O0zg3CTrqt7zcdIyq1hs0suxX5uKHp/jVCzK15hR1CxEbP9W7qSCQoNFRJGCkauL2loHwIq1rJQJg4mw0YWeMpDaW1m+3JZAaqPbxFRPSDnbWGT07lA3O048wyRJff8R0BU+5ba+yjZ7KV50IO/AqDaTXvvqnuF1VGQ3KQUEc+CFRH8ULF9cz9FVsc9cEs8gH/aBzaH4R3W6KSj339nMwsT27YiMuE/k6edy5QH4w8CGxLBkMjjjPGjHJwN2/CxJZRxDHt82RLbf6boQsNGCHKSEm409hjHNLAu4KY+1AkkSIXaWWVA102c2C/CG96QvWLN4fz4gUV+SgVLlW2ZULaSEsdbQM50MSvo1YTPdmx8QVfJD0=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 99a07f07-4fbd-4341-dc53-08dc7efd0f4f
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 May 2024 10:00:53.0617
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Jxrd07xPMp0v/2ebgSLjbVFFhcWmXFm6VWiICFL+TYqJC5TQfWe/wQzvMGBGHP5SMzi7OxRWX3sBo5wdcIKdJg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA3PR10MB8113
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.12.28.16
 definitions=2024-05-28_06,2024-05-28_01,2024-05-17_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 spamscore=0 suspectscore=0
 adultscore=0 phishscore=0 malwarescore=0 mlxlogscore=999 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2405010000
 definitions=main-2405280074
X-Proofpoint-GUID: Ez19oqLybNVDQgjbMMn8TtgiHwE6vA5G
X-Proofpoint-ORIG-GUID: Ez19oqLybNVDQgjbMMn8TtgiHwE6vA5G

On 25/05/2024 02:30, Ian Rogers wrote:
> empty-pmu-events.c exists so that builds may occur without python
> being installed on a system. > Manually updating empty-pmu-events.c to
> be in sync with jevents.py is a pain, let's use jevents.py to generate
> empty-pmu-events.c.
> 
> 1) change jevents.py so that an arch and model of none cause
>     generation of a pmu-events.c without any json. Add a SPDX and
>     autogenerated warning to the start of the file.
> 
> 2) change Build so that if a generated pmu-events.c for arch none and
>     model none doesn't match empty-pmu-events.c the build fails with a
>     cat of the differences. Update Makefile.perf to clean up the files
>     used for this.
> 
> 3) update empty-pmu-events.c to match the output of jevents.py with
>     arch and mode of none.
> 
> Signed-off-by: Ian Rogers <irogers@google.com>


Reviewed-by: John Garry <john.g.garry@oracle.com>

> ---
>   tools/perf/Makefile.perf                 |   2 +
>   tools/perf/pmu-events/Build              |  12 +-
>   tools/perf/pmu-events/empty-pmu-events.c | 894 ++++++++++++++---------
>   tools/perf/pmu-events/jevents.py         |   6 +-
>   4 files changed, 562 insertions(+), 352 deletions(-)
> 
> diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.per

..

> -	},
> +struct pmu_table_entry {
> +        const struct compact_pmu_event *entries;
> +        uint32_t num_entries;
> +        struct compact_pmu_event pmu_name;
> +};
> +
> +static const char *const big_c_string =
> +/* offset=0 */ "default_core\000"
> +/* offset=13 */ "bp_l1_btb_correct\000branch\000L1 BTB Correction\000event=0x8a\000\00000\000\000"
> +/* offset=72 */ "bp_l2_btb_correct\000branch\000L2 BTB Correction\000event=0x8b\000\00000\000\000"

Please remind me: how to figure out this number when adding a new entry?

> +/* offset=131 */ "l3_cache_rd\000cache\000L3 cache access, read\000event=0x40\000\00000\000Attributable Level 3 cache access, read\000"