Received-SPF: pass (google.com: domain of linux-kernel+bounces-192074-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Tue, 28 May 2024 10:01:21 +0000
From: Sakari Ailus <sakari.ailus@iki.fi>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Sylvain Petinot <sylvain.petinot@foss.st.com>,
	benjamin.mugnier@foss.st.com, mchehab@kernel.org, robh@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	linux-media@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] media: dt-bindings: Add ST VD56G3 camera sensor
 binding
Message-ID: <ZlWrcTCNBWEz67Tj@valkosipuli.retiisi.eu>
References: <20240521162950.6987-1-sylvain.petinot@foss.st.com>
 <20240521162950.6987-2-sylvain.petinot@foss.st.com>
 <8afe1888-5886-45fc-b576-98db3d392d37@linaro.org>
 <ZlWiQTfag5yTA4YM@valkosipuli.retiisi.eu>
 <b6d3d336-5999-424a-9e38-3cf793b6627e@linaro.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <b6d3d336-5999-424a-9e38-3cf793b6627e@linaro.org>

Hi Krzysztof,

On Tue, May 28, 2024 at 11:46:00AM +0200, Krzysztof Kozlowski wrote:
> On 28/05/2024 11:22, Sakari Ailus wrote:
> > Hi Krzysztof,
> > 
> > On Mon, May 27, 2024 at 09:04:38PM +0200, Krzysztof Kozlowski wrote:
> >> On 21/05/2024 18:29, Sylvain Petinot wrote:
> >>> Add devicetree bindings Documentation for ST VD56G3 & ST VD66GY camera
> >>> sensors. Update MAINTAINERS file.
> >>>
> >>> Signed-off-by: Sylvain Petinot <sylvain.petinot@foss.st.com>
> >>
> >>
> >>> diff --git a/MAINTAINERS b/MAINTAINERS
> >>> index ef6be9d95143..554e6861425b 100644
> >>> --- a/MAINTAINERS
> >>> +++ b/MAINTAINERS
> >>> @@ -20885,6 +20885,15 @@ S:	Maintained
> >>>  F:	Documentation/hwmon/stpddc60.rst
> >>>  F:	drivers/hwmon/pmbus/stpddc60.c
> >>>  
> >>> +ST VD56G3 DRIVER
> > 
> > I might add this is a sensor, i.e. "ST VD653G IMAGE SENSOR DRIVER".
> > 
> >>> +M:	Benjamin Mugnier <benjamin.mugnier@foss.st.com>
> >>> +M:	Sylvain Petinot <sylvain.petinot@foss.st.com>
> >>> +L:	linux-media@vger.kernel.org
> >>> +S:	Maintained
> >>> +T:	git git://linuxtv.org/media_tree.git
> >>
> >> This is a friendly reminder during the review process.
> >>
> >> It seems my or other reviewer's previous comments were not fully
> >> addressed. Maybe the feedback got lost between the quotes, maybe you
> >> just forgot to apply it. Please go back to the previous discussion and
> >> either implement all requested changes or keep discussing them.
> > 
> > The above MAINTAINERS entry is roughly in line with what else we have for
> > the Media tree. I'm in favour of listing the people who would look after
> > the driver, not just those who merge the patches (or even send PRs to
> > Linus).
> 
> I did not propose to drop the entry.
> 
> > 
> > In other words, I think the above entry is fine as-is.
> 
> I propose to drop duplicated, redundant git entry. Maintainer of this

Ah, I agree, that makes sense.

> driver does not have access to git tree and the git tree is already
> explained in media subsystem entry. If you ever update the git tree, you
> need to update 100 driver entries which is meaningless...

-- 
Regards,

Sakari Ailus