Received: by 2002:a89:d88:0:b0:1fa:5c73:8e2d with SMTP id eb8csp2545408lqb; Tue, 28 May 2024 03:25:26 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXMXHZTK/K3cYI985saZF4ECvc+OuoL7HyGaBdqYB6TP9yI/PW0m+r5Dv40wmwuSSau3VOO56/gnkOKhvKeastDLaqshH4kn3WmLZd9nQ== X-Google-Smtp-Source: AGHT+IEYxWrkFrEgVR7HCgtQ2bUCy6fip7SpPP8IslAzCRXiOTXBOMk5ifq71AT09oRUtrrK+o4e X-Received: by 2002:a50:ab0c:0:b0:575:2b1a:cea6 with SMTP id 4fb4d7f45d1cf-578519a3040mr8047275a12.28.1716891926079; Tue, 28 May 2024 03:25:26 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716891926; cv=pass; d=google.com; s=arc-20160816; b=racLQKeczvksjXPegr2uS8fZPZXHpsr2Jwl9UhSaxYlK6hwksZCvcegQrSc3nQadJ8 nMq1zJfvKU7PHokfZqnpn/jfOm/wmZUONGZvuvbeuIzhCvdtNy1UYEB+qD233xP3XQgZ q0etP7kc/2ebANnZfgqO/Ng7fi21aMNmtK098dsJ+6IqW7QHy7FJrum+8zt8wavsxRlF p5VSWhm9gdzOwutEzsxEZH59EaImTzS8YNLtCEUFtenH5eR5bPtxVYF0bgqwNdjq0vBG olsa4gJAqBgQP5i9vJ1ReEbuohJ7X51Z3QkfuBl7Tm+fe9AqQ1T1bnUxReTOaMhlvf+R s3iA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=H7G4Z+JDPlGSq4FjtsjOg3xvjrPwA6k8DfYP4Dn+4po=; fh=+Oqfc304Xt9+3TQLA0mTwZ9Tl6SyzVeWJEzT/JXjgJM=; b=IrRLGXeVailNO6ez6EdTndZh3PAl7G3U3OTu8w8zva8hhqOsksGpcm2C68wPLwr7QW 8XoYKqrIfrIP/UlSGcSJO9I07wABYLHmS49GcgGqdjPaGVbSS9WrWMxrdaW0DJZlTgKM bleNZhAJ5VrmsYgurV8HrJ+bUo9pKOJUbG31/ZyEDWokUNG/q46TNgncocMqV1LwWfkj M+vUM47zq9Dx0wQMG/vuL931DVkFWjdJyJYQ+umEskMk0TMbhwmGxL3J7/xuV+lkflZ+ PnsdfP7gGJfP0pq6hTza8VCQMpXzycwoyii07kj2v12K+hE0ehTRX0S/MHLYKJYBPaGV YEpA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=uXmoZx45; arc=pass (i=1 spf=pass spfdomain=collabora.com dkim=pass dkdomain=collabora.com dmarc=pass fromdomain=collabora.com); spf=pass (google.com: domain of linux-kernel+bounces-192109-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-192109-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id 4fb4d7f45d1cf-578cc8b7a08si3697857a12.591.2024.05.28.03.25.26 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 May 2024 03:25:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-192109-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=uXmoZx45; arc=pass (i=1 spf=pass spfdomain=collabora.com dkim=pass dkdomain=collabora.com dmarc=pass fromdomain=collabora.com); spf=pass (google.com: domain of linux-kernel+bounces-192109-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-192109-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id C3F0D1F2232B for ; Tue, 28 May 2024 10:25:25 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id ED75116C6BA; Tue, 28 May 2024 10:24:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="uXmoZx45" Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9517C16C6AC; Tue, 28 May 2024 10:24:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.227.194 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716891891; cv=none; b=Bxvj4d4RPOj9xD4IrWt5lai+LXaBAei+TjL1898GIrsZnvGzVF3BqH3wJQTRi9LO3XAQY3ISa3+cRCYnxP7M3qdlih1pz3VLLRGaBOLvpDkdM3lgF8hE6voJTWfNfeXrmSXncITlJGiOdRa4B+SyOE64v1yZE4vxy3gZM+zyLMU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716891891; c=relaxed/simple; bh=eCwSK1GHrFnFt48tdaVfJXIdF4FWIhLcfBXFC1OraC4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=VVpj2pPss57uUex7FZNYvJyrunAiTYZM9akOHvuERHtIr3CN8V5qYRK0g2rZLWBo3t6tdPiotHmXf9PfyIIysiVogDEJP6+NNC5RmqikLdZC6k/18DtC3IdlUecPUtYonXbpU5cm+7rRgfw/nxGRW84NrUkCSX1qFrZps13eEjQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=uXmoZx45; arc=none smtp.client-ip=46.235.227.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1716891887; bh=eCwSK1GHrFnFt48tdaVfJXIdF4FWIhLcfBXFC1OraC4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=uXmoZx45jNRaFuP8GluwtX/dBcGxZBoC2sG3ztrO7Vw/mLyOgR6UHs5a39tVBZlII tjM15S11SxO8H3TJvsD6+Ut+EF5A3BM2RLN/3GySr33UwEqLb0DH+bSm9OtW2bwZHA ONOPOhmtKh8DTktxE/FsTqxmPJeVm6MBHGDwkenM9P9FvspUPB3kSMpokA5kqdtS7A xHSc80R/5YVbiW+DOYJ+5HEccTEXY+0rLu1ow14Qst+fqaeNEGn7iA4LEOg+joW6Re U2fA/SCgJqgv4hEz+heCV0YecgNueNj8a5r46HzdaJXIHE90lX7QeJNURxq0oM2/zN zarGK7OsgFw6g== Received: from [100.113.186.2] (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 962773782113; Tue, 28 May 2024 10:24:46 +0000 (UTC) Message-ID: <26c862ec-1613-46fc-ba37-5649fd55e159@collabora.com> Date: Tue, 28 May 2024 12:24:46 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 4/8] mailbox: mtk-cmdq: Support GCE loop packets in interrupt handler To: "Jason-JH.Lin" , Jassi Brar , Krzysztof Kozlowski , Rob Herring , Matthias Brugger , Chun-Kuang Hu Cc: Conor Dooley , Jason-ch Chen , Singo Chang , Nancy Lin , Shawn Sung , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, dri-devel@lists.freedesktop.org, Project_Global_Chrome_Upstream_Group@mediatek.com References: <20240525230810.24623-1-jason-jh.lin@mediatek.com> <20240525230810.24623-5-jason-jh.lin@mediatek.com> From: AngeloGioacchino Del Regno Content-Language: en-US In-Reply-To: <20240525230810.24623-5-jason-jh.lin@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Il 26/05/24 01:08, Jason-JH.Lin ha scritto: > 1. Add a loop flag for CMDQ packet struct. > CMDQ helper will use a loop flag to mark CMDQ packet as lopping command > and make current command buffer jumps to the beginning when GCE executes > to the end of command buffer. > > 2. Add a looping task handle flow in irq handler. > GCE irq occurs when GCE executes to the end of command(EOC) instruction. > If the CMDQ packet is a loopping command, GCE irq handler can not > delete the CMDQ task and disable the GCE thread. > > Signed-off-by: Jason-JH.Lin > Signed-off-by: Hsiao Chien Sung Reviewed-by: AngeloGioacchino Del Regno