Received-SPF: pass (google.com: domain of linux-kernel+bounces-192141-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <20240528090244.6746-1-ecurtin@redhat.com> <CAJfpegvoao1jd7HhoPEeWCdS8jWEXhKTENbwvLdo=aMiNaLKQQ@mail.gmail.com>
In-Reply-To: <CAJfpegvoao1jd7HhoPEeWCdS8jWEXhKTENbwvLdo=aMiNaLKQQ@mail.gmail.com>
From: Eric Curtin <ecurtin@redhat.com>
Date: Tue, 28 May 2024 11:54:51 +0100
Message-ID: <CAOgh=FyHFE7qjfYq4BqGc20SYJ5FebhN2iYpJSsYYatO1TkqBw@mail.gmail.com>
Subject: Re: [PATCH] ovl: change error message to info for empty lowerdir
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: "open list:OVERLAY FILESYSTEM" <linux-unionfs@vger.kernel.org>, Alexander Larsson <alexl@redhat.com>, 
	Wei Wang <weiwang@redhat.com>, Amir Goldstein <amir73il@gmail.com>, 
	open list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"

On Tue, 28 May 2024 at 11:34, Miklos Szeredi <miklos@szeredi.hu> wrote:
>
> On Tue, 28 May 2024 at 11:03, Eric Curtin <ecurtin@redhat.com> wrote:
> >
> > In some deployments, an empty lowerdir is not considered an error.
>
> I don't think this can be triggered in upstream kernel and can be
> removed completely.

True... Just switched to Fedora Rawhide and instead we just see this one:

pr_err("cannot append lower layer");

>
> Or do you have a reproducer?

Run one of these vms:

https://github.com/osbuild/bootc-image-builder

And on boot:

sudo bootc switch quay.io/fedora/fedora-bootc:rawhide && sudo reboot

is the reproducer that is closest to upstream

Is mise le meas/Regards,

Eric Curtin

>
> Thanks,
> Miklos
>