Received-SPF: pass (google.com: domain of linux-kernel+bounces-192242-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240527022036.31985-1-user@blabla> <9abb1d5e-fdac-4500-9218-fb9f28ff2c05@web.de>
In-Reply-To: <9abb1d5e-fdac-4500-9218-fb9f28ff2c05@web.de>
From: =?UTF-8?B?5p2O57u06LGq?= <cn.liweihao@gmail.com>
Date: Tue, 28 May 2024 20:01:04 +0800
Message-ID: <CAPEOAkRjKm_bcfX4CJe3HON=6abcfzBGjXo6VpcnhR-u9OCHzg@mail.gmail.com>
Subject: Re: [PATCH] pinctrl: ralink: mt76x8: fix pinmux function
To: Markus Elfring <Markus.Elfring@web.de>
Cc: linux-gpio@vger.kernel.org, linux-mips@vger.kernel.org, 
	Angelo Gioacchino Del Regno <angelogioacchino.delregno@collabora.com>, 
	=?UTF-8?B?QXLEsW7DpyDDnG5hbA==?= <arinc.unal@arinc9.com>, 
	Linus Walleij <linus.walleij@linaro.org>, Matthias Brugger <matthias.bgg@gmail.com>, 
	Sean Wang <sean.wang@kernel.org>, Sergio Paracuellos <sergio.paracuellos@gmail.com>, 
	LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Markus Elfring <Markus.Elfring@web.de> =E4=BA=8E2024=E5=B9=B45=E6=9C=8828=
=E6=97=A5=E5=91=A8=E4=BA=8C 19:37=E5=86=99=E9=81=93=EF=BC=9A
>
> =E2=80=A6
> > There are some same function name in different pin groups, =E2=80=A6
>
>                                names?
>

refclk [0][1], pwm [2][3] and some others. For example, without this
patch, part of the pinmux-functions in the kernel debug fs looks like
this

root@mt7628:/sys/kernel/debug/pinctrl/pinctrl-ralink-pinmux# cat
pinmux-functions
function 0: gpio, groups =3D [ pwm1 pwm0 uart2 uart1 i2c refclk perst
wdt spi sdmode uart0 i2s spi cs1 spis gpio0 wled_an p0led_an p1led_an
p2led_an p3led_an p4led_an wled_kn p0led_kn p1led_kn p2led_kn p3led_kn
p4led_kn ]
function 1: sdxc d6, groups =3D [ pwm1 ]
function 2: utif, groups =3D [ pwm1 ]
function 3: gpio, groups =3D [ pwm1 ]
function 4: pwm1, groups =3D [ pwm1 ]
function 5: sdxc d7, groups =3D [ pwm0 ]
function 6: utif, groups =3D [ pwm0 ]
function 7: gpio, groups =3D [ pwm0 ]
function 8: pwm0, groups =3D [ pwm0 ]
function 9: sdxc d5 d4, groups =3D [ uart2 ]
function 10: pwm, groups =3D [ uart2 ]
function 11: gpio, groups =3D [ uart2 ]
function 12: uart2, groups =3D [ uart2 ]
function 13: sw_r, groups =3D [ uart1 ]
function 14: pwm, groups =3D [ uart1 ]
function 15: gpio, groups =3D [ uart1 ]
function 16: uart1, groups =3D [ uart1 ]
function 17: -, groups =3D [ i2c ]
function 18: debug, groups =3D [ i2c ]
function 19: gpio, groups =3D [ i2c ]
function 20: i2c, groups =3D [ i2c ]
function 21: refclk, groups =3D [ refclk ]
function 22: perst, groups =3D [ perst ]
function 23: wdt, groups =3D [ wdt ]
function 24: spi, groups =3D [ spi ]
function 25: jtag, groups =3D [ sdmode ]
function 26: utif, groups =3D [ sdmode ]
function 27: gpio, groups =3D [ sdmode ]
function 28: sdxc, groups =3D [ sdmode ]
function 29: -, groups =3D [ uart0 ]
function 30: -, groups =3D [ uart0 ]
function 31: gpio, groups =3D [ uart0 ]
function 32: uart0, groups =3D [ uart0 ]
function 33: antenna, groups =3D [ i2s ]
function 34: pcm, groups =3D [ i2s ]
function 35: gpio, groups =3D [ i2s ]
function 36: i2s, groups =3D [ i2s ]
function 37: -, groups =3D [ spi cs1 ]
function 38: refclk, groups =3D [ spi cs1 ]


>
> =E2=80=A6
> > To solve this problem, a simple way is just add a pingrp refix to
>
>                                                     pin group prefix?
>

Yes. Just add a pin group prefix like pinctrl-mt7620.c does.

> Regards,
> Markus

[0] https://elixir.bootlin.com/linux/latest/source/drivers/pinctrl/mediatek=
/pinctrl-mt76x8.c#L73
[1] https://elixir.bootlin.com/linux/latest/source/drivers/pinctrl/mediatek=
/pinctrl-mt76x8.c#L101
[2] https://elixir.bootlin.com/linux/latest/source/drivers/pinctrl/mediatek=
/pinctrl-mt76x8.c#L54
[3] https://elixir.bootlin.com/linux/latest/source/drivers/pinctrl/mediatek=
/pinctrl-mt76x8.c#L61