Received: by 2002:a89:d88:0:b0:1fa:5c73:8e2d with SMTP id eb8csp2593755lqb; Tue, 28 May 2024 05:05:34 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXyvX3NzC109tlwMlMC8zuewombsl8SRunphojHqiTv1HLnBrQSKrLz0mE0JYF3G4HhuvqAIzSnUP+n1Om9ErqCQKxyDmI/xZ97ht610A== X-Google-Smtp-Source: AGHT+IH5iHdWXm9NDbB7v35/MMiE1z7xtdjt6F/k5pX7dFwbDdCG1LlUWK77hQ5go9sz8YbV8XvN X-Received: by 2002:a50:cb86:0:b0:572:a770:1371 with SMTP id 4fb4d7f45d1cf-57851a2126bmr8363739a12.42.1716897934420; Tue, 28 May 2024 05:05:34 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716897934; cv=pass; d=google.com; s=arc-20160816; b=sGTIhsYNAUPxI9h5YyUkrYDuw0KEwDVSFPymXYWwAVGC01whykb4wOf9o2wMiGKiOb eyZMmIbL1COvK2AD4WFdgAyuzNEv2zoYCe9Qw2uOb4FgA0MuTOQXsf3Hbsq31VXWaIOx M8ARe2XDsSXQwIaKF1nztupJocDOWlVE+2yl6Qu2Pft6RvtLPdYz1CqLfxjXrTtPy8kd vNr79L3QyZRO8pAfRU3pc84VixliYuC/jvAdEGWVWbXSLsMxT+G8iRTyBa8ORLwDh72g REw6O66aHyyp7th0Dm6UoUbWwz9wjV4hv3lpgtK94buCm/jwj2m03/T+F4g2VJ20dA3P nyEA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=K+vQJEXhgadRxGPN+Q29+wrzGVQjvGEvPdCco9C6A2k=; fh=u1iZTdk3U2VfAgDnzZ/KFzTzo+8dO5osoNp5VEePTVE=; b=xUCuygBo6L27WRwGLnpnHkNMwkcbMAOK7FVAhWaj2E54VOWrIvrmiIYnnuNiZeZuQ7 u36TSVLcLpXMQYmnZ+abnY8AclMz9i/hoByxMLkV4iEchcL7KKLm2VIgFwB5ForwxHpT MV7V5yL7RSFO70h7uCE1b75gIstt7n0Rq3UqwJJjtjpEIPRGZb01sMHBCcp9THgrmH7b KgjCOgcMv0yl4SP9uPk7aMNJllbTp9CmU6wOxJ4feihrEsikzyyIpMJEUmKggo4kM6t1 +cBT3oQs3LpQCMCpsBiJP4xMnLrUryQvdk8Ic6D18acAUBKPO2FcCwc/9sDwG+YAHIT4 inSA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=nWj8ZvqO; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-192248-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-192248-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id 4fb4d7f45d1cf-57859f090f8si4919221a12.73.2024.05.28.05.05.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 May 2024 05:05:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-192248-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=nWj8ZvqO; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-192248-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-192248-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 2A8C01F23A81 for ; Tue, 28 May 2024 12:05:34 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A791E16D9DB; Tue, 28 May 2024 12:04:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="nWj8ZvqO" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C88B916B743; Tue, 28 May 2024 12:04:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716897872; cv=none; b=pCX5dolmBWQdARLWazFI1pIf6sKbiT4z0Yyf/7X5A3RVZTEIGNVR+qSuanqEsC+9JnpiTVVe60uFq/WTCPw8532RLcKvZa0dIE2vCS5g1dWEiqMYhKgSPo61HVyl8O3duoxHfSNBPwoEUBudZCYto7vVLoPRKeO+AY8IpErzCoM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716897872; c=relaxed/simple; bh=geFzxgDm7W4HA50i8vXt3CLQRJwI4FU8uG+93ofHFxY=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=EFuU6234aGJNUbhvm+8mJcS/C0Amb74pHbyCO8FUNTMTqdoBZ4ILNsQ4Im+Pjg9rOLyoukqO7oruJAb/I1WMpunZUJE446+mVGAvgdlseUwnX7ihNrNSNuM4NJi6lvOAK6Ts8Dz6qDIjww9eOVPVO2cliue88MbJN2ihP6mH0sg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=nWj8ZvqO; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 83895C32782; Tue, 28 May 2024 12:04:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1716897871; bh=geFzxgDm7W4HA50i8vXt3CLQRJwI4FU8uG+93ofHFxY=; h=From:To:Cc:Subject:Date:From; b=nWj8ZvqO4QYiburakoYAcexvxmbveCbUU//HDUl7nERTKp6g9s8UoYzLPvtik1c9r E5dkiPoJgdwlZc342vma5XxmBxFTDLj05IzI1+cP/U6Ie6kKKJkq+Jc20mISDYZ+/F NiEG85XE+an8l0XRshU6+Yl0Ox0nOjpi5TKuBgNMGOXABd24d6MMfC9J4geeb5BaUM nChOeg0guxtb9N0GmRqjF2G2xqdJkoo2v3/8tyqtEppXWWmtKCeWv65l28h8pt8Zjl N43yo6BdlcQ8etlQ24KYJz5KJQ20Q3v7sSTUFXtKY8bnYrKwOGvxtU6GPXzuK9l8zi O4hDR15XJkplg== From: Arnd Bergmann To: Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" Cc: Arnd Bergmann , Linus Walleij , =?UTF-8?q?Alvin=20=C5=A0ipraga?= , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Luiz Angelo Daros de Luca , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] net: dsa: realtek: add LEDS_CLASS dependency Date: Tue, 28 May 2024 14:03:46 +0200 Message-Id: <20240528120424.3353880-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Arnd Bergmann This driver fails to link when LED support is disabled: ERROR: modpost: "led_init_default_state_get" [drivers/net/dsa/realtek/rtl8366.ko] undefined! ERROR: modpost: "devm_led_classdev_register_ext" [drivers/net/dsa/realtek/rtl8366.ko] undefined! Add a dependency that prevents this configuration. Fixes: 32d617005475 ("net: dsa: realtek: add LED drivers for rtl8366rb") Signed-off-by: Arnd Bergmann --- drivers/net/dsa/realtek/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/dsa/realtek/Kconfig b/drivers/net/dsa/realtek/Kconfig index 6989972eebc3..6c90a83c71da 100644 --- a/drivers/net/dsa/realtek/Kconfig +++ b/drivers/net/dsa/realtek/Kconfig @@ -39,6 +39,7 @@ config NET_DSA_REALTEK_RTL8365MB config NET_DSA_REALTEK_RTL8366RB tristate "Realtek RTL8366RB switch driver" depends on NET_DSA_REALTEK_SMI || NET_DSA_REALTEK_MDIO + depends on LEDS_CLASS select NET_DSA_TAG_RTL4_A help Select to enable support for Realtek RTL8366RB. -- 2.39.2