Received: by 2002:a89:d88:0:b0:1fa:5c73:8e2d with SMTP id eb8csp2595984lqb; Tue, 28 May 2024 05:09:00 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWxN3jR9ySiQK8jH4LrTop4vWwadsHTt8AYSD789FHFJDSlcU+dNFAZRjXuy5w7fOlfeYximxAYZ96SxO/nEUElEU3L0ZEImhneeDqhmg== X-Google-Smtp-Source: AGHT+IE4cSq56i7YDYrpBaN/gx1PMQm/GLifEKQ+c74m/M8PHbZJj4j4AdCzTCZNreiAEIA2okOy X-Received: by 2002:a05:6a00:4088:b0:6e7:b3c4:43a4 with SMTP id d2e1a72fcca58-6f8f3f9faa5mr12422582b3a.25.1716898140039; Tue, 28 May 2024 05:09:00 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716898140; cv=pass; d=google.com; s=arc-20160816; b=GEml0VZa9KNDLpU0W8051c+nXEZwT8bCatOAr7SQ9PUnTrtPEMg9dLvan+fsnfip7m a+TYvmP3mN8dKPCP0F3BQlMT4TxC3D/Wdf5jkt5TbT2RnTQhGxW8m1IQyG5GIPRxk8HZ RICnA3mWZ/LFs874Jt/Te0mKLtX6LBF3ijC9902EGiRkcdtgeXrFeQ2f5GvURwMenSV+ vHy7jYNgVOmubrbDkbiqhsuc/FlbVZN7ouCO/UDrEXF2VLZX1Q5vfxC3pCJSzBSjUmBw R7jJDK3C9Qs1HsqcRta+WPh/VroBdPLwVXUzLxirdDjlZFTQVWVrU0+8L4EbLskFguR2 FBbQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=vJJrthcfBRkfxz/ZPs6JUGm4CEN8fDDGSUoMZktKf60=; fh=e4BP6H0nUu5lGd+KEJ8YhtgdTL/1E3fRz4ly5aEo92c=; b=R+cHxyPPSPSNchvJwvA5V+cRvoMt5Bm6+rDXddXv2PsryT21DUIVbi9j+W+VbbBrQs Fa/Vs3qBXCMePoH4gcXplxYySIDbsHhVpDOtmE3oMfxZvgesxaa0xtvWI9BzXYpIf76K pNMZw+/r4FmuTIx1dD03olatuujW0VWxZfYNDKMriQlaVEIBOqyB0n9j2Me0Tr03plGw zzJbau2lqehS+mf204TcZwd31V8n43qtOc/fop+Q3nsG/WWvJGp/2eW3HenwSFlgL/Ry 5Eg75yDxjB4iCvQtncKqilqXlsZmORergyEjmkHogGABfByKX2cPYZuFn2be/2YyBhIk 68eg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=H4iXVa2X; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-192220-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-192220-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id d2e1a72fcca58-6f8fd8e5917si7740297b3a.315.2024.05.28.05.08.59 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 May 2024 05:09:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-192220-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=H4iXVa2X; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-192220-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-192220-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id CB862B25A8E for ; Tue, 28 May 2024 11:51:07 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A6D0D16C870; Tue, 28 May 2024 11:50:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="H4iXVa2X" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC4AF16C698 for ; Tue, 28 May 2024 11:50:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716897057; cv=none; b=ai5ABfC5/XepLqi/JpiIsXGsK7lTqEbpKribGaNmz2nrPD2R/YBkO3og3Sz9pgGHM3/EcBNT2ushAAq39rh1KRXvC6UBnxSB8tu/obMKKYj7hzz/4J14yJirR268+X5pA08WPwOxRPpzYHV1gNkxRwvmwkqtcAJbPEzo+WT6g2s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716897057; c=relaxed/simple; bh=vCzcWUNmvMUlvI8YURG3Btky8bNrSZU0/30kwieKgRM=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=A1s7oTjmwEVYUdnT3sqiagJqZ1q6T+yyaGfA1TBiKHjoxItEe0L6rdK1TYssoMWjhRD+3PS3Dx1C68UUGsHLiGyeEWc6uyJCo5cbMZLxoWA/UHd/J4cb7MN3eHkwFXE84dxbtV5KlWGxJYPLZiL1+LhxSl5IMMA1NVGofpsEJbM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=H4iXVa2X; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5CF2DC3277B; Tue, 28 May 2024 11:50:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1716897057; bh=vCzcWUNmvMUlvI8YURG3Btky8bNrSZU0/30kwieKgRM=; h=From:To:Cc:Subject:Date:From; b=H4iXVa2XTb/BQ48DrxGjyEW4dPitPx8+zyptgCLF6aB5RzX/wgbW6GRYFlcZWatZU Av27wYkwultkGf236L2YZlx3kpABD8fWJNHzCf3PDx3WrqjfHHYOwkqK8YrRRCXZWJ vUY9esizWwtQvPkTvLsYfowh0+SrDpH0iCwQrddaKn5iZHdCWMDDVtyVE1Js5223PK RUCU16pKRMyY7syvM9rXuESlPMwJChch3lRQHkzy829CYpIzruGSPho2OGHhFT7FdG YdbIu2IxrS1n1SEnCYiPNAIkKdyLAnd0lkVYbYyWJc60j8k8rLJO2GpdxPf+Ljl6Pk 7JO5opD9IOYxQ== From: Arnd Bergmann To: Felix Kuehling Cc: Arnd Bergmann , Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= , "Pan, Xinhui" , David Airlie , Daniel Vetter , Harish Kasiviswanathan , Lijo Lazar , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm/amdkfd: select CONFIG_CRC16 Date: Tue, 28 May 2024 13:50:32 +0200 Message-Id: <20240528115050.2831206-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Arnd Bergmann The amdkfd support fails to link when CONFIG_CRC16 is disabled: aarch64-linux-ld: drivers/gpu/drm/amd/amdkfd/kfd_topology.o: in function `kfd_topology_add_device': kfd_topology.c:(.text+0x3a4c): undefined reference to `crc16' This is a library module that needs to be selected from every user. Fixes: 3ed181b8ff43 ("drm/amdkfd: Ensure gpu_id is unique") Signed-off-by: Arnd Bergmann --- drivers/gpu/drm/amd/amdkfd/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdkfd/Kconfig b/drivers/gpu/drm/amd/amdkfd/Kconfig index d3c3d3ab7225..f82595af34bf 100644 --- a/drivers/gpu/drm/amd/amdkfd/Kconfig +++ b/drivers/gpu/drm/amd/amdkfd/Kconfig @@ -6,6 +6,7 @@ config HSA_AMD bool "HSA kernel driver for AMD GPU devices" depends on DRM_AMDGPU && (X86_64 || ARM64 || PPC64) + select CRC16 select HMM_MIRROR select MMU_NOTIFIER select DRM_AMDGPU_USERPTR -- 2.39.2