Received-SPF: pass (google.com: domain of linux-kernel+bounces-192298-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20240528090244.6746-1-ecurtin@redhat.com> <CAJfpegvoao1jd7HhoPEeWCdS8jWEXhKTENbwvLdo=aMiNaLKQQ@mail.gmail.com>
 <CAOgh=FyHFE7qjfYq4BqGc20SYJ5FebhN2iYpJSsYYatO1TkqBw@mail.gmail.com>
 <CAJfpegu+z2Nxvk2H9vfZ3nfzEEixUG4kEthVGHWUYw0wX5bgMg@mail.gmail.com> <CAL7ro1Hm7EOxKUv9U5vEMbe2Ui2oaCdM0b2Xbm0wbdZ52+JV2w@mail.gmail.com>
In-Reply-To: <CAL7ro1Hm7EOxKUv9U5vEMbe2Ui2oaCdM0b2Xbm0wbdZ52+JV2w@mail.gmail.com>
From: Eric Curtin <ecurtin@redhat.com>
Date: Tue, 28 May 2024 13:25:59 +0100
Message-ID: <CAOgh=FygeLw0jBLvPKiaBCxKkfoQXmwf=sfvyJHs4Hyy_7wDSw@mail.gmail.com>
Subject: Re: [PATCH] ovl: change error message to info for empty lowerdir
To: Alexander Larsson <alexl@redhat.com>
Cc: Miklos Szeredi <miklos@szeredi.hu>, 
	"open list:OVERLAY FILESYSTEM" <linux-unionfs@vger.kernel.org>, Wei Wang <weiwang@redhat.com>, 
	Amir Goldstein <amir73il@gmail.com>, open list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, 28 May 2024 at 13:23, Alexander Larsson <alexl@redhat.com> wrote:
>
>
>
> On Tue, May 28, 2024 at 1:34=E2=80=AFPM Miklos Szeredi <miklos@szeredi.hu=
> wrote:
>>
>> On Tue, 28 May 2024 at 12:55, Eric Curtin <ecurtin@redhat.com> wrote:
>> >
>> > On Tue, 28 May 2024 at 11:34, Miklos Szeredi <miklos@szeredi.hu> wrote=
:
>> > >
>> > > On Tue, 28 May 2024 at 11:03, Eric Curtin <ecurtin@redhat.com> wrote=
:
>> > > >
>> > > > In some deployments, an empty lowerdir is not considered an error.
>> > >
>> > > I don't think this can be triggered in upstream kernel and can be
>> > > removed completely.
>> >
>> > True... Just switched to Fedora Rawhide and instead we just see this o=
ne:
>> >
>> > pr_err("cannot append lower layer");
>> >
>> > >
>> > > Or do you have a reproducer?
>> >
>> > Run one of these vms:
>> >
>> > https://github.com/osbuild/bootc-image-builder
>>
>> Apparently it is using the legacy lowerdir append mode
>> "lowerdir=3D:foo".  This works only on 6.5.
>>
>> In 6.6 and later the same can be achieved with "lowerdir+=3Dfoo".
>>
>> It's strange that there are not side effects other then the error messag=
e.
>
>
> The code tries to use the new mode, but then falls back on ENOSYS:
>
> https://github.com/containers/composefs/blob/main/libcomposefs/lcfs-mount=
c#L431
>
> So, I guess with a more recent kernel it will not print the warning.
>
> --
> =3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=
=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D
>  Alexander Larsson                                Red Hat, Inc
>        alexl@redhat.com         alexander.larsson@gmail.com

I realized I never posted the version of the kernel producing this
error message:

pr_err("cannot append lower layer");

So just for clarity in general, that was this one:

Linux fedora 6.9.0-64.fc41.x86_64 #1 SMP PREEMPT_DYNAMIC Mon May 13
11:58:46 UTC 2024 x86_64 GNU/Linux

Is mise le meas/Regards,

Eric Curtin