Received-SPF: pass (google.com: domain of linux-kernel+bounces-192318-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.11.0-alpha0-491-g033e30d24-fm-20240520.001-g033e30d2
Precedence: bulk
MIME-Version: 1.0
Message-Id: <d6ddfe21-8596-4311-a229-4b1501fa84b4@app.fastmail.com>
In-Reply-To: <20240528133104.304a1261@canb.auug.org.au>
References: <20240528104905.58195cbe@canb.auug.org.au>
 <20240528133104.304a1261@canb.auug.org.au>
Date: Tue, 28 May 2024 14:39:42 +0200
From: "Arnd Bergmann" <arnd@arndb.de>
To: "Stephen Rothwell" <sfr@canb.auug.org.au>,
 "Christian Brauner" <brauner@kernel.org>
Cc: =?UTF-8?Q?Christian_G=C3=B6ttsche?= <cgzones@googlemail.com>,
 "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
 linux-next <linux-next@vger.kernel.org>
Subject: Re: linux-next: build warning after merge of the vfs-brauner tree
Content-Type: text/plain

On Tue, May 28, 2024, at 05:31, Stephen Rothwell wrote:
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Tue, 28 May 2024 13:20:29 +1000
> Subject: [PATCH] fix up for "fs/xattr: add *at family syscalls"
>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  fs/xattr.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/fs/xattr.c b/fs/xattr.c
> index 8e712795ab80..d0d54ae2f9cb 100644
> --- a/fs/xattr.c
> +++ b/fs/xattr.c
> @@ -706,7 +706,8 @@ SYSCALL_DEFINE6(setxattrat, int, dfd, const char 
> __user *, pathname, unsigned in
>  	if (error)
>  		return error;
> 
> -	return do_setxattrat(dfd, pathname, at_flags, name, (const void 
> __user *)args.value,
> +	return do_setxattrat(dfd, pathname, at_flags, name,
> +			     (const void __user *)(unsigned long)args.value,
>  			     args.size, args.flags);
>  }
> 

We have a u64_to_user_ptr() helper to make this slightly
more readable.

      Arnd