Received-SPF: pass (google.com: domain of linux-kernel+bounces-192320-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <70b0c2dc-0ec7-4b04-9742-e54b6e56e6bb@amd.com>
Date: Tue, 28 May 2024 18:10:05 +0530
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] drm/amdkfd: select CONFIG_CRC16
To: Arnd Bergmann <arnd@kernel.org>, Felix Kuehling <Felix.Kuehling@amd.com>
Cc: Arnd Bergmann <arnd@arndb.de>, Alex Deucher <alexander.deucher@amd.com>,
 =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>,
 "Pan, Xinhui" <Xinhui.Pan@amd.com>, David Airlie <airlied@gmail.com>,
 Daniel Vetter <daniel@ffwll.ch>,
 Harish Kasiviswanathan <Harish.Kasiviswanathan@amd.com>,
 amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
 linux-kernel@vger.kernel.org
References: <20240528115050.2831206-1-arnd@kernel.org>
Content-Language: en-US
From: "Lazar, Lijo" <lijo.lazar@amd.com>
In-Reply-To: <20240528115050.2831206-1-arnd@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?QStYWVluVThNNW9GejNaaTd0cmFhT3lOMFBBUEhnTmo2S0pBU055b25qcTJx?=
 =?utf-8?B?K09sd2hUTkkxSk5OWmtieERsYU45YUs1SFI1eW0xaTZoRm8rQ1ZjZURoRUcr?=
 =?utf-8?B?RFExeStVT3A1cEt5OG1QdW54by9uRmdRQmZhZzZNS1hJZmpOeDd6cW10NUhQ?=
 =?utf-8?B?VVFaWE8yNFpRSXZzc2ZGd3BPWWhobEl1MjhFWG9mMzlISDhGOEdZLzZlSXhx?=
 =?utf-8?B?ZXNRbElvVG5pWU9aV1dXb0d2aGhGTFcvZGtqMDl0NkN0OCtPaUduZURqSFlX?=
 =?utf-8?B?MWN1YlhzL0NxTTBXYURBbW93Y2dhaDlmRk95WjJNKzZQVTI4UEdGd2JaZ0c2?=
 =?utf-8?B?Yll6RmRJV0czMno2OCs4anB6aWplTzNmM0ZERm1qVStHYy9LdS92VTJ4allw?=
 =?utf-8?B?cUR5c3FCbkpBL0RxN0ZyWlF1M1RzT1owQTlqSXFsSk8vd3lVblkrb3hvdjV2?=
 =?utf-8?B?OG5zU2JmaUdkUmovTzhjUWlrbU56MzVIWEI2YmN1eEhLU0FTVDRuditoUml0?=
 =?utf-8?B?eEhTY0I5YlEwdDBNQU1xUlVLRHVFUXpYQWxuWW1JQ002dFgwUm9HU05CSDdF?=
 =?utf-8?B?Zkd3QUtOc2NscWJ1VG5PbWFBYnBJMi9VSk1uY2xZZGVPVndqYm16UFZ4a0Ji?=
 =?utf-8?B?TmNWV1BQNTgrUHpyOFJhVDNWbjlWRlhaYjJxeTJ0WEdRc0ZoLytMNlNEQ2p0?=
 =?utf-8?B?SVoraTNLNU1yN09uSlVVYjFJandya1BPblFNUnp4cHNGNjdLY1FCMHdvOVdW?=
 =?utf-8?B?bXlnSmc0TWRqL2ErWm0rdlMyNnFwOXYzMldJbFFWdmtUb05ZS0RhcmQ1RVNX?=
 =?utf-8?B?c01hdVN0VEJiSEpEUHdUVFVLREVwK09UOWxubjVPTVNGZExjb3FSSlBKMjQr?=
 =?utf-8?B?dTZpaTFqUVlndDBEMFpMemFlYWN3cUc1QmxLSm94VmVuNWNYMmpiOEM3bGZF?=
 =?utf-8?B?YTZkNFJEMHJDM01qdW9JTlZSWnMwK0dUbmp4TE1lSGtJMUYwM09yYWVKb3JL?=
 =?utf-8?B?a3FGTVZtSmZMKzVSY2dQN2orOGV0ZlBlTnBId0tMZ3dKUzJGZ0c1Q1REWFJv?=
 =?utf-8?B?NTU3UlhSQ2lGNmlpWHpTT09WcjdReUxpUVdYZEZTZy9CSlR5dEc5dzdZQVZM?=
 =?utf-8?B?QmNkbko2OWlKZDVJd2k2bGJhbXJDTU0zelY2ZnkzcEhnT1M0RzQrMWRuNDdw?=
 =?utf-8?B?UVpXRGwxYzF3TVRhNnVFSDNMYzU0TXBtamw0QlFoTHUvcWREbjZDdTdGd01x?=
 =?utf-8?B?NUovcjNTbU9IYWhIVDhsWGZMalB4bzk0ak1hVER3UGhTRStHZFdDaUxIaTlq?=
 =?utf-8?B?b3AwNXc1TnBiTWhIdDhlazRjZHk1b2owZ1ZYdDNYVG1iMHRhUmtLL0tSdk9z?=
 =?utf-8?B?UEkrT0htcjJnZElpWU9rYlFCVjZUbkxkL3pKRm9xUzJ1QWV6ekVsL0o4aWtG?=
 =?utf-8?B?SXRGUHhGbm5DTEtjWmtWTEhmOWJMVG51QzFNRHBxK0NFQU1xUG9iY05Ycmxq?=
 =?utf-8?B?WlNKQWdkaEZacE56MTBWUkhxVWdzMWV0NlcxNTl6Ty9QdnZQTytQSGRpRE1o?=
 =?utf-8?B?ajhWODA1SWJwTmRjOExhV0tLbjFGUDU0cUYxY2dxSGMvekswWWVzOEtya3Vl?=
 =?utf-8?B?U2ZCSmhmWUdLVUQzcHdwOHM1cWFHOEZQOFVpVFhSU1NsTzFGKzA2aHdxcUwx?=
 =?utf-8?B?RjNtMnU0SnNMMW95QUVxMkN3OXNIdGIvSFBiWE0wWmZNV0poMDU3MGovRW5y?=
 =?utf-8?B?YVZycm5wMUFvbXBHMExiWVFDYjlsNmE4MHNXOFQ4citWSGhPUkxaYWZTdmtN?=
 =?utf-8?B?WlZidmRDN2FQdVNzMURHMnZJdnlHWFd2djB6Tmdmei9SMDZxN3FTeXIzNHlX?=
 =?utf-8?B?a2tsMG41YW9OYWcrOEllTEVnT1pLak5pRy9oS2M2MkdOMGhBamVhMndBMnY0?=
 =?utf-8?B?MGsreDc0WTVNbDdiakdCNTJtQXJMWE9RNU5JdFFLc24rR3pTSERjOXg0WFRI?=
 =?utf-8?B?Z2ZSeXVLL1dPTVRqMHE3cUlOcTlTZVJCSDRVWklHcE5YNVdLbmZBL0gvMERs?=
 =?utf-8?B?WG1NamkzNVFRd1R3UUhodTVZejB3b2QzR2ViVFdXampTVG5NZmNoNjN1UmZo?=
 =?utf-8?Q?kGDOC6ijASLF6eXu3mSkuLE63?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 32cbecf1-4edc-4933-a662-08dc7f13538f
X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB7804.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 May 2024 12:40:16.6808
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: q9m64DHDtOnFFGGWpxAJ9ElXmAkUqAfLXEEr422XAMkn/DlSChkHoZVygNXFteM3
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6035


On 5/28/2024 5:20 PM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The amdkfd support fails to link when CONFIG_CRC16 is disabled:
> 
> aarch64-linux-ld: drivers/gpu/drm/amd/amdkfd/kfd_topology.o: in function `kfd_topology_add_device':
> kfd_topology.c:(.text+0x3a4c): undefined reference to `crc16'
> 
> This is a library module that needs to be selected from every user.
> 
> Fixes: 3ed181b8ff43 ("drm/amdkfd: Ensure gpu_id is unique")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Thanks for the patch; this is already addressed with -
https://patchwork.freedesktop.org/patch/594816/

Thanks,
Lijo

> ---
>  drivers/gpu/drm/amd/amdkfd/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/amd/amdkfd/Kconfig b/drivers/gpu/drm/amd/amdkfd/Kconfig
> index d3c3d3ab7225..f82595af34bf 100644
> --- a/drivers/gpu/drm/amd/amdkfd/Kconfig
> +++ b/drivers/gpu/drm/amd/amdkfd/Kconfig
> @@ -6,6 +6,7 @@
>  config HSA_AMD
>  	bool "HSA kernel driver for AMD GPU devices"
>  	depends on DRM_AMDGPU && (X86_64 || ARM64 || PPC64)
> +	select CRC16
>  	select HMM_MIRROR
>  	select MMU_NOTIFIER
>  	select DRM_AMDGPU_USERPTR