Received-SPF: pass (google.com: domain of linux-kernel+bounces-192327-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <b3b02658-ffc4-4bd9-b77a-af65ae359474@oracle.com>
Date: Tue, 28 May 2024 13:46:39 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2] statx: stx_subvol
To: Eric Biggers <ebiggers@kernel.org>,
        Kent Overstreet <kent.overstreet@linux.dev>
Cc: linux-fsdevel@vger.kernel.org, linux-bcachefs@vger.kernel.org,
        linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
        Josef Bacik <josef@toxicpanda.com>,
        Miklos Szeredi <mszeredi@redhat.com>,
        Christian Brauner <brauner@kernel.org>,
        David Howells <dhowells@redhat.com>
References: <20240308022914.196982-1-kent.overstreet@linux.dev>
 <20240312021308.GA1182@sol.localdomain>
Content-Language: en-US
From: John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <20240312021308.GA1182@sol.localdomain>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?V2xHc0J6RmtaYkxKaTFlaDNac2RNS1p3RU04SU9MMnljZzRIeE1UZTJTSXE4?=
 =?utf-8?B?eXl5SzkvWG40OFR3VHVaMWRzTjJUQzJkcjRaZUNxcTNUOHdwNkFMLzBsUWJs?=
 =?utf-8?B?Rk1Ed0RjSmkwMElqWEUxTnIxNlA5MU1GNUVhcExMZlJiUENabzBScmFCcWx6?=
 =?utf-8?B?NVljNTQ3dHpJMnlCc0hxUUtPaU8vbUNWQzVWUW9LVlpxQkdGaFFEd3FNMXZE?=
 =?utf-8?B?UGFYbkhraFFLSndzQm54OXNqNlNBdHBlVE5sVTNPQ3hxbFpFMWRUVmN1dUdB?=
 =?utf-8?B?YjhDd1h4WGJCckJ4RlIyNFlCV3J5VVh0enViNUYrVVNTMyt6WEdraHAvLzd4?=
 =?utf-8?B?UVZ6b1NUemYyNlNTckwwMzU4RDdsWm4rUzcxQnl6Wlk0eS83dEljem1hMzdE?=
 =?utf-8?B?VGZPSzVkeEhFTXRTZ3BjUkwraUN3WnFqWkxtNjJuTjMyMDBxWWJSbGZjdlVz?=
 =?utf-8?B?SzN0c0pDYUd0b2o3R21oV0FPVGR0cjlUdWlDT2psUnB5QUp1U0pmZmluejls?=
 =?utf-8?B?b3h1ZzFHZ3daeUdsTzVmNGdGOUtsWFJITm9BTTIrQ3JLY1Z6S1dUM01LaEFY?=
 =?utf-8?B?VVlGcEkzQm5RcHJWVk41cXN3ZlppWmdEMnNTNncxc2l4WFhXaGFJc01iam1o?=
 =?utf-8?B?TmVGK1pVUzZkdHdpVXpXbWtlL29DdFZxcHRhZHdKanc1RThaaTZ3Y0R0MTRN?=
 =?utf-8?B?U0IwS0xXYVJnL05TaGNLbEFnVC90aElhTTJxYnVPYlUyVHFMUlNJdkt0eklH?=
 =?utf-8?B?a1oxT0doQmZ5R3VEMGtoNk42d0NiWDVLcW85OVIxdlBiVkVWVU9kTjBaaE9k?=
 =?utf-8?B?S2FXNWhOUCtXNTZyVGt4UU54YmZudXpZeEMyaENiaWpySHpHcVZ5WDFlVXNL?=
 =?utf-8?B?ckR1Z01MdWFGaDJRVElVa1E1M3QwTXhsN21ORUs4bnhPOU1MVVdkMnJFeHhD?=
 =?utf-8?B?ZDl6c2xkVUxobEpuK1FZdWlhdmFlTHoxcUhIcUxZUlptTHJnVmtxVGhVUzlD?=
 =?utf-8?B?TmdnU08xZ1B6ODhQTllITm44V25NZXZZZHd1TTd2QmR5OUJYVzB1Q0tycVQ4?=
 =?utf-8?B?NUtLcVFKVmh1SXJHY21XczIyUDJISTl0YXBmWjQvbmNiMVBLTytXNGpBWlB1?=
 =?utf-8?B?eUFmSEJnSGJyYmM5USttbzgrc2ZxcU9YWjlKQzl0bUhrY1NjemtWY3VubkN5?=
 =?utf-8?B?b2tXZXYva3Z5c05HdXEwMncwUDFIZjJJcHkwK1JXdkxDdmU3ZjB0SGRZWUQ1?=
 =?utf-8?B?NlFjK2ZuRG1ZUmF0UGpMQzN6WU9PWDJQalZxb3NVdThsVENTYTh0S1NEQWJs?=
 =?utf-8?B?OTlQdGRiL3hFWFh5WFAyTk5OTG9YVjFvQStjR2JKZUxtVTR4YWxneWl1d04r?=
 =?utf-8?B?UUJYU2xVZzVvYnc5WTZUT1N6Tyt1Q3BOVTdWYlB6b2IzM0dYQk9USm5laThx?=
 =?utf-8?B?VnVUSFIwY1ZwZnFkQzRzWTVKR1FpamxuTXJjbkNDY0FTMDdOL3lxMmdSa245?=
 =?utf-8?B?aGpoZ3ZscVFnb3dyYW1SdHhWcFJLbDdZNGNWbkRJSVhyek1aendoYWhobUJi?=
 =?utf-8?B?cXczc0o0TUZSaFRNNlhOQmk4T0tpYnJrY3phOGd1cjM1YStWazQ1Z2s5em1k?=
 =?utf-8?B?Vmh4KzdlMVMxYzhTY1Mva3Y2ZTUrL1lmWHNaQ1J4WDVFL1Y1SzNhZlpTdjZj?=
 =?utf-8?B?SCttb1FOMXYvVmpvbWZPL1ozRDJ0aVZncFQ5TlhhM1FqU1ozZXhycVIvbEZx?=
 =?utf-8?B?NndQQ1ZCdUZxT0NCb2g3ZkVReTBZNWEwck52a3Z6SjVPcXJWWmN4M3BtY0ds?=
 =?utf-8?B?dUNJajd3MFNHNFh5Y2M1b0E0S1pMcjdjbnlYYzA4NXVoT1Z5R2VubjRzcjZn?=
 =?utf-8?B?WE5ueWMxc3gvY3JlN3hZRWRibVh1YVZ3cWVCKytrNzRoL29SOWVKUGZiY0Jr?=
 =?utf-8?B?TTl4aEEzY05tdlBBRzBETTNOQ3pIMjBPQjZFS0V1dlZyeEN0c1Z4ZFBQQnNz?=
 =?utf-8?B?MXV0WE92MUoxUzh1eUV3QlZ2OFdkRTZoQStUNTArMTVUSURuMjlLM0xBVHBI?=
 =?utf-8?B?ek4rMUpvMFFYSm5zblQzNUhicTU1K2lQZTRRYTBxQVhiMWJNS2pHRXdYNzU1?=
 =?utf-8?B?Nk55dU9NeFo1cE0xMVJYYnlGcEJ1VU04NWxWQWVBVUtnY1kxYmNrYmYwa2g0?=
 =?utf-8?B?dVE9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	F+qlB3f2Qc40vryhN+1LRIKYlyK8E2D6BqGPskriXl4rZY06f/G6Fecv0M2RuBCs3WmqWj6uB/VHvTirBhih2pIHMJgikMf4Rajd2qHho+NCk5bd0zxDOv7bx8CtWTlsRswQq+lma1FWxpie4C2KwmknsrKryMzhScuOyVS4zYquknQopjrJMVz+c8q3wKGYA1buDtW0CQbEvT1JAF0uyFibUQQ3csa8MeqiyDs5Eq2Ogg83msefAEITYBp+6nEKMg9gXa+z8oiy59XeI2SoYIGvFxgssfMXQeyi4seWcsUCmnKdsP4N9PQQLVuWciDC8nBP72H5MxH+5Swy9mukZIvLPO6JRYPyn2BcjHqR3kDCTw11BSn6HBb12kgxn6RJZD4d7plqyRgef+Ntbmzo5f+2y5qAWd/8X5hDaFXN2vkh7VjioDY0mTOeCzzrwlQVGli00bW5vKLuEdgN0i/pfhitCz8E9Wl3F7QoOLonHQgpbMtGpvMGrVYSmcPHo48UCT0C+RrGm5b1XYhLhQUK+PKuRn2W1qWPmw73XYU0f91KUFwLlKywU80cM0h2uHwZuJKg1a6mL+0UFJPD7cuJLReEoyWom0PeYdw9HhQtsEI=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5c1ba7cd-6a92-41f7-f315-08dc7f143acb
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 May 2024 12:46:44.4791
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tRArRr9d2Ege0RLHT+eu8gxmBY3nXaDeXdkg8cqF1/4TXnVzOCwm4lFnY6o828f+IoFnuMYLtbZufdc7JmndBA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB6227
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.12.28.16
 definitions=2024-05-28_09,2024-05-28_01,2024-05-17_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=935 mlxscore=0 adultscore=0
 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2405010000
 definitions=main-2405280096
X-Proofpoint-GUID: Q_HEixrhLHhO4GYWv0C7ABV4Yy7bsPZD
X-Proofpoint-ORIG-GUID: Q_HEixrhLHhO4GYWv0C7ABV4Yy7bsPZD

On 12/03/2024 02:13, Eric Biggers wrote:
> On Thu, Mar 07, 2024 at 09:29:12PM -0500, Kent Overstreet wrote:
>>   	__u32	stx_dio_mem_align;	/* Memory buffer alignment for direct I/O */
>>   	__u32	stx_dio_offset_align;	/* File offset alignment for direct I/O */
>> +	__u64	stx_subvol;	/* Subvolume identifier */
>>   	/* 0xa0 */
>> -	__u64	__spare3[12];	/* Spare space for future expansion */
>> +	__u64	__spare3[11];	/* Spare space for future expansion */
>>   	/* 0x100 */
> The /* 0xa0 */ comment needs to be updated (or deleted).

I would tend to agree. Was this intentionally not updated (or deleted)?