Received: by 2002:a89:d88:0:b0:1fa:5c73:8e2d with SMTP id eb8csp2641402lqb; Tue, 28 May 2024 06:24:44 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVxPW/l8spJfTV7z7Gm8QEnlR99rV6jR/D/U4KovOAnvhePBn607NvsH6GvTjYD7xKH4NGXUAIX3OehsEoz0S7lw2zNl73/4DforBqaEg== X-Google-Smtp-Source: AGHT+IG5gPq/zgCTBSkc0ENCdp+kEi1dQBP9JEARagnyKZzD/RJhdpFpj0uC2L3tYWscoFaEEAcQ X-Received: by 2002:a17:903:228a:b0:1f3:1482:60d with SMTP id d9443c01a7336-1f449901aa6mr118969475ad.61.1716902684599; Tue, 28 May 2024 06:24:44 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716902684; cv=pass; d=google.com; s=arc-20160816; b=rZ49SvcB892Em7cvREx1HH2kYapNFU3A/osAc8VK7CZnY391aZKs8Yf6XgMfNDWFd3 HxKuVHyCCTZT/zxWKyNvuzINIhJSW9rKvaLgu7L3bAFrPVFCr/1EAKL6fPO1jc8i2mG1 EIfFVMTmaGr/T9qUXSkIIy/V0JdabKg45NYlaymlULHTS+v0Lbo9T60tweDnxqDoSHT8 vJ30Zb+sWZ4aFUuZp4scsDrjdUsOKfPQBgrwKQmiTjo7yGsujlMEyv1KOBjZVcqe1Urk sH2I/1Valattyf2s1RpDummGZwuRX+tIWhN33DTsxmFkxs2mAmRqh8TYfI2N/pAEL4wc 7ozw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=VpoXeImvv+3zjups/cZs0SCyUkXvCCcET3oHfElZJnE=; fh=pw6A0dfRIfV9Mq3fu+4t+4A5tecz6su09VyhC0g4F3U=; b=iIo7jnOYGJUFOFzITfOASFMtkMW9A4RmAKryfI7T+jHj2C9Zn0pMd9E6nWd1YFTxKM Icv7YiY1dq3LtHHMvKDQJO1q9jp+updjyHhuNXZDcnIkOkkWe7NseHdqQJWVD7kXhhD1 JLR8xmy2mtYJEM0rxbk/lesw4f1XfgpuMUHP0ofZdBWxhDVHyADVe1fW+BlGDw0QorHT bF1hvfMzVSZc7/9nGvjf4B2dJ0XRbHNtiTk++bCMVL0moqvTdJpkXsitTcCKB0qKMOck 5qDZhN3W6YLK3lATiIFHesHLeXtyqcjuoI5meOZ7c5WDLCXirZAyFyIjhU91K/Tg/ed8 WsMA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=sntech.de dmarc=pass fromdomain=sntech.de); spf=pass (google.com: domain of linux-kernel+bounces-192403-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-192403-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=sntech.de Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id d9443c01a7336-1f44ca0504csi77772005ad.600.2024.05.28.06.24.44 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 May 2024 06:24:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-192403-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=sntech.de dmarc=pass fromdomain=sntech.de); spf=pass (google.com: domain of linux-kernel+bounces-192403-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-192403-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=sntech.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 5D21728574D for ; Tue, 28 May 2024 13:24:39 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B22D816F27E; Tue, 28 May 2024 13:23:27 +0000 (UTC) Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F51716ABC2; Tue, 28 May 2024 13:23:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.11.138.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716902607; cv=none; b=TWy5nBo9TanjDiGCysKwKHgG4p9FD4blec8LU5KQ6JiC64rMn6AX89keB0g/1EZZAXgiPocPArRjDPtjScXI96hHqm7AZuvChg1T/jm1OQKHgdrLZ6z4yQ1ivAW+o/pWWQoawwvb3vp6OZQTrYIUMPHVzdvu1c+AsZy0M4yQASg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716902607; c=relaxed/simple; bh=VpoXeImvv+3zjups/cZs0SCyUkXvCCcET3oHfElZJnE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=UlgkHmV0mBDdRvQPN8z5DDSU1ReRSfGfyDxErXT1hJoTF8E9QSTAClSr8BiA+HcF+Kt/BzCP4/5WE20rd9AQPqyzoUN3Si8DBxw6FCe9SZhf9Pypo3VhYevgHyCBmxmRQEaZKlGSQPeziXAbv8c+7ojlVRSqVU0FlSFs5PxAOgM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sntech.de; spf=pass smtp.mailfrom=sntech.de; arc=none smtp.client-ip=185.11.138.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sntech.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sntech.de Received: from i5e86193d.versanet.de ([94.134.25.61] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sBwnL-00040P-DW; Tue, 28 May 2024 15:23:15 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Linus Walleij , Dmitry Yashin Cc: Krzysztof Kozlowski , Conor Dooley , Rob Herring , Luca Ceresoli , Jianqun Xu , devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Dmitry Yashin Subject: Re: [PATCH 1/3] pinctrl: rockchip: update rk3308 iomux routes Date: Tue, 28 May 2024 15:23:14 +0200 Message-ID: <2553645.4XsnlVU6TS@diego> In-Reply-To: References: <20240515121634.23945-1-dmt.yashin@gmail.com> <1770701.X513TT2pbd@diego> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Am Dienstag, 28. Mai 2024, 14:18:35 CEST schrieb Dmitry Yashin: > Hi Heiko, >=20 > On 5/28/24 4:52 PM, Heiko St=C3=BCbner wrote: > > Hi Linus, > > > > Am Dienstag, 28. Mai 2024, 13:29:12 CEST schrieb Linus Walleij: > >> On Wed, May 15, 2024 at 2:17=E2=80=AFPM Dmitry Yashin wrote: > >> > >>> Some of the rk3308 iomux routes in rk3308_mux_route_data belong to > >>> the rk3308b SoC. Remove them and correct i2c3 routes. > >>> > >>> Fixes: 7825aeb7b208 ("pinctrl: rockchip: add rk3308 SoC support") > >>> Signed-off-by: Dmitry Yashin > >> While you guys are thinking about the RK3308B support, is this fix > >> something I can just apply? > > I'd think so. I've detailed stuff in my Review mail I just sent. > > Both the soc itself and also the affected pin functions are niche > > enough that this should not cause breakage. > > > > > > Heiko > > > > > > >=20 > Should i just drop 1/3 from V2 then? I guess just check the state of affairs once your v2 is ready ;-) . I.e. if LinusW grabs patch1 before you post v2, just drop it, otherwise send it along. > Thanks everyone for the feedback on this series. I'll prepare V2 based > on runtime chip detection with use of GRF_CHIP_ID.