Received-SPF: pass (google.com: domain of linux-kernel+bounces-192440-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240528121154.3662553-1-arnd@kernel.org>
In-Reply-To: <20240528121154.3662553-1-arnd@kernel.org>
From: Doug Anderson <dianders@chromium.org>
Date: Tue, 28 May 2024 06:41:50 -0700
Message-ID: <CAD=FV=U=BW3qjhn=Lp=vb6d1wHaUF6M98DUssEz-zZkL2TU=mw@mail.gmail.com>
Subject: Re: [PATCH] kdb: address -Wformat-security warnings
To: Arnd Bergmann <arnd@kernel.org>
Cc: Jason Wessel <jason.wessel@windriver.com>, 
	Daniel Thompson <daniel.thompson@linaro.org>, Arnd Bergmann <arnd@arndb.de>, 
	Petr Mladek <pmladek@suse.com>, Sergey Senozhatsky <senozhatsky@chromium.org>, 
	Justin Stitt <justinstitt@google.com>, John Ogness <john.ogness@linutronix.de>, 
	kgdb-bugreport@lists.sourceforge.net, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi,

On Tue, May 28, 2024 at 5:12=E2=80=AFAM Arnd Bergmann <arnd@kernel.org> wro=
te:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> When -Wformat-security is not disabled, using a string pointer
> as a format causes a warning:
>
> kernel/debug/kdb/kdb_io.c: In function 'kdb_read':
> kernel/debug/kdb/kdb_io.c:365:36: error: format not a string literal and =
no format arguments [-Werror=3Dformat-security]
>   365 |                         kdb_printf(kdb_prompt_str);
>       |                                    ^~~~~~~~~~~~~~
> kernel/debug/kdb/kdb_io.c: In function 'kdb_getstr':
> kernel/debug/kdb/kdb_io.c:456:20: error: format not a string literal and =
no format arguments [-Werror=3Dformat-security]
>   456 |         kdb_printf(kdb_prompt_str);
>       |                    ^~~~~~~~~~~~~~
>
> Use an explcit "%s" format instead.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  kernel/debug/kdb/kdb_io.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Fixes: 5d5314d6795f ("kdb: core for kgdb back end (1 of 2)")
Reviewed-by: Douglas Anderson <dianders@chromium.org>

..probably also justifies a:

Cc: stable@vger.kernel.org


-Doug