Received-SPF: pass (google.com: domain of linux-kernel+bounces-192441-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: Esben Haabendal <esben@geanix.com>
To: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,  Tudor Ambarus
 <tudor.ambarus@linaro.org>,  Pratyush Yadav <pratyush@kernel.org>,
  Michael Walle <mwalle@kernel.org>,  Miquel Raynal
 <miquel.raynal@bootlin.com>,  Richard Weinberger <richard@nod.at>,
  Vignesh Raghavendra <vigneshr@ti.com>,  Michael Ellerman
 <mpe@ellerman.id.au>,  Nicholas Piggin <npiggin@gmail.com>,  "Aneesh Kumar
 K.V" <aneesh.kumar@kernel.org>,  "Naveen N. Rao"
 <naveen.n.rao@linux.ibm.com>,  "linux-kernel@vger.kernel.org"
 <linux-kernel@vger.kernel.org>,  "linux-mtd@lists.infradead.org"
 <linux-mtd@lists.infradead.org>,  "linuxppc-dev@lists.ozlabs.org"
 <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH v2 1/2] memory: fsl_ifc: Make FSL_IFC config visible and
 selectable
In-Reply-To: <56f19120-7ddb-4006-99f6-e1b043ed88e1@kernel.org> (Krzysztof
	Kozlowski's message of "Tue, 28 May 2024 15:32:12 +0200")
References: <20240528-fsl-ifc-config-v2-0-5fd7be76650d@geanix.com>
	<20240528-fsl-ifc-config-v2-1-5fd7be76650d@geanix.com>
	<eb911c50-2f66-43dd-a1ff-398a3e7c56a2@csgroup.eu>
	<56f19120-7ddb-4006-99f6-e1b043ed88e1@kernel.org>
Date: Tue, 28 May 2024 15:43:07 +0200
Message-ID: <87jzjevyqc.fsf@geanix.com>
User-Agent: Gnus/5.13 (Gnus v5.13)
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Krzysztof Kozlowski <krzk@kernel.org> writes:

> On 28/05/2024 15:15, Christophe Leroy wrote:
>> Le 28/05/2024 =C3=A0 14:28, Esben Haabendal a =C3=A9crit=C2=A0:
>>> [Vous ne recevez pas souvent de courriers de esben@geanix.com. D=C3=A9c=
ouvrez pourquoi ceci est important =C3=A0 https://aka.ms/LearnAboutSenderId=
entification ]
>>>
>>> While use of fsl_ifc driver with NAND flash is fine, as the fsl_ifc_nand
>>> driver selects FSL_IFC automatically, we need the CONFIG_FSL_IFC option=
 to
>>> be selectable for platforms using fsl_ifc with NOR flash.
>>=20
>> I don't understand.
>>=20
>> Shall I understand :
>>=20
>> While use of fsl_ifc driver with NAND flash is fine as the fsl_ifc_nand=
=20
>> driver selects FSL_IFC automatically, ....
>>=20
>> or
>>=20
>> ..., as the fsl_ifc_nand driver selects FSL_IFC automatically we need=20
>> the CONFIG_FSL_IFC option to be selectable for platforms using fsl_ifc=20
>> with NOR flash
>>=20
>>=20
>>=20
>> I'm fine with the fact that you want to be able to select it when you=20
>> use NOR flashes,=20
>
> But users are not fine... their memory won't work if they cannot choose
> it (if you meant select=3Dchoose).

Exactly. The IFC controller supports both NAND and NOR flashes. Since
commit ea0c0ad6b6eb ("memory: Enable compile testing for most of the driver=
s"),
it has not been possible to use IFC controller for NOR flashes without
selecting the IFC NAND driver (CONFIG_MTD_NAND_FSL_IFC), which is
obviously not how it is supposed to be.

/Esben