Received-SPF: pass (google.com: domain of linux-kernel+bounces-192444-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Tue, 28 May 2024 15:46:04 +0200
From: Michael Tretter <m.tretter@pengutronix.de>
To: Nas Chung <nas.chung@chipsnmedia.com>
Cc: mchehab@kernel.org, linux-media@vger.kernel.org,
	sebastian.fricke@collabora.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] media: uapi: v4l: Change V4L2_TYPE_IS_CAPTURE
 condition
Message-ID: <ZlXgHN4DPfRtZaPS@pengutronix.de>
Mail-Followup-To: Michael Tretter <m.tretter@pengutronix.de>,
	Nas Chung <nas.chung@chipsnmedia.com>, mchehab@kernel.org,
	linux-media@vger.kernel.org, sebastian.fricke@collabora.com,
	linux-kernel@vger.kernel.org
References: <20240528020425.4994-1-nas.chung@chipsnmedia.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20240528020425.4994-1-nas.chung@chipsnmedia.com>

On Tue, 28 May 2024 11:04:25 +0900, Nas Chung wrote:
> Explicitly compare a buffer type only with valid buffer types,
> to avoid matching the buffer type outside of valid buffer
> type set.
> 
> Signed-off-by: Nas Chung <nas.chung@chipsnmedia.com>

Reviewed-by: Michael Tretter <m.tretter@pengutronix.de>

> ---
>  include/uapi/linux/videodev2.h | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h
> index fe6b67e83751..fa2b7086e480 100644
> --- a/include/uapi/linux/videodev2.h
> +++ b/include/uapi/linux/videodev2.h
> @@ -157,6 +157,10 @@ enum v4l2_buf_type {
>  	V4L2_BUF_TYPE_PRIVATE              = 0x80,
>  };
>  
> +#define V4L2_TYPE_IS_VALID(type)		\
> +	((type) >= V4L2_BUF_TYPE_VIDEO_CAPTURE	\
> +	 && (type) <= V4L2_BUF_TYPE_META_OUTPUT)
> +
>  #define V4L2_TYPE_IS_MULTIPLANAR(type)			\
>  	((type) == V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE	\
>  	 || (type) == V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE)
> @@ -171,7 +175,8 @@ enum v4l2_buf_type {
>  	 || (type) == V4L2_BUF_TYPE_SDR_OUTPUT			\
>  	 || (type) == V4L2_BUF_TYPE_META_OUTPUT)
>  
> -#define V4L2_TYPE_IS_CAPTURE(type) (!V4L2_TYPE_IS_OUTPUT(type))
> +#define V4L2_TYPE_IS_CAPTURE(type)	\
> +	(V4L2_TYPE_IS_VALID(type) && !V4L2_TYPE_IS_OUTPUT(type))
>  
>  enum v4l2_tuner_type {
>  	V4L2_TUNER_RADIO	     = 1,
> -- 
> 2.25.1
> 
>