Received-SPF: pass (google.com: domain of linux-kernel+bounces-192442-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Tue, 28 May 2024 15:43:37 +0200
From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Markus Schneider-Pargmann <msp@baylibre.com>
Cc: Martin =?utf-8?Q?Hundeb=C3=B8ll?= <martin@geanix.com>, 
	Chandrasekar Ramakrishnan <rcsekar@samsung.com>, Vincent Mailhol <mailhol.vincent@wanadoo.fr>, 
	"David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, 
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, linux-can@vger.kernel.org, 
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] can: m_can: don't enable transceiver when probing
Message-ID: <20240528-beautiful-teal-of-attack-a6d106-mkl@pengutronix.de>
References: <20240501124204.3545056-1-martin@geanix.com>
 <rgjyty2tbqngttoicyxhntmiplihcd2xxjsqsi6r7pqrxrnumc@upt2nelsumv3>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="dw25iobgk3zzmc32"
Content-Disposition: inline
In-Reply-To: <rgjyty2tbqngttoicyxhntmiplihcd2xxjsqsi6r7pqrxrnumc@upt2nelsumv3>


--dw25iobgk3zzmc32
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 07.05.2024 14:29:57, Markus Schneider-Pargmann wrote:
> Hi Martin,
>=20
> On Wed, May 01, 2024 at 02:42:03PM +0200, Martin Hundeb=C3=B8ll wrote:
> > The m_can driver sets and clears the CCCR.INIT bit during probe (both
> > when testing the NON-ISO bit, and when configuring the chip). After
> > clearing the CCCR.INIT bit, the transceiver enters normal mode, where it
> > affects the CAN bus (i.e. it ACKs frames). This can cause troubles when
> > the m_can node is only used for monitoring the bus, as one cannot setup
> > listen-only mode before the device is probed.
> >=20
> > Rework the probe flow, so that the CCCR.INIT bit is only cleared when
> > upping the device. First, the tcan4x5x driver is changed to stay in
> > standby mode during/after probe. This in turn requires changes when
> > setting bits in the CCCR register, as its CSR and CSA bits are always
> > high in standby mode.
> >=20
> > Signed-off-by: Martin Hundeb=C3=B8ll <martin@geanix.com>
> > ---
> >=20
> > Changes since v1:
> >  * Implement Markus review comments:
> >    - Rename m_can_cccr_wait_bits() to m_can_cccr_update_bits()
> >    - Explicitly set CCCR_INIT bit in m_can_dev_setup()
> >    - Revert to 5 timeouts/tries to 10
> >    - Use m_can_config_{en|dis}able() in m_can_niso_supported()
> >    - Revert move of call to m_can_enable_all_interrupts()
> >    - Return -EBUSY on failure to enter normal mode
> >    - Use tcan4x5x_clear_interrupts() in tcan4x5x_can_probe()
>=20
> Thanks for addressing these.
>=20
> In general this looks good:
> Reviewed-by: Markus Schneider-Pargmann <msp@baylibre.com>
>=20
> A few small things commented below, mostly nit-picks.
> @Marc: Up to you if you want to merge it or not. I hope the review was
> early enough for your PR :)
> I don't have time to test it this week, but I can do that next week.

Martin, please address the review feedback by Markus and send a v3.

regards,
Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung N=C3=BCrnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

--dw25iobgk3zzmc32
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEUEC6huC2BN0pvD5fKDiiPnotvG8FAmZV34YACgkQKDiiPnot
vG8W0gf+OXBFxXnx3JnC+bhlMxgn5v7NSRKsE4GU5mE0Z5uaUZXpEjavklwP2cDg
Yirkaai/61+NRkVLn0vNlQsLTDIY3t4Q/N1edYBql44XMua3XrCGZ3071yzF/4Uo
kOE6y9DNZei1vDsCbukXwWmaynXNtrLtnOh0u2vzENPE3StE1Z6gozPmPhwgFmna
G5JcdA9Bx3765cKBx1PPCZqPeTJHJc+GVJNMUgwaAJXdGRMOn/mqu5tSFuDevANZ
vwDMQoH8jxoWGu+/ReavCS99tVcizLPilpjiZsBiPaE1Y68Awl4IUEl1gAQ7urO+
nc+sfDgheyINWOeig9Or08N22NNC9A==
=fHzh
-----END PGP SIGNATURE-----

--dw25iobgk3zzmc32--