Received: by 2002:a89:d88:0:b0:1fa:5c73:8e2d with SMTP id eb8csp2674104lqb; Tue, 28 May 2024 07:12:13 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWvO+e5DibR32c89QPD8/eJVO1pLekyVRKmo/UB0uUFQyRCLOP+jYcBbhZSBJDFnsamyOEdjgfvogWv1xjzooNCZhPwep3qWCUaR2bawA== X-Google-Smtp-Source: AGHT+IEIT3LFF8DVzfBCrxANFxyJF00DCuJczK7iLSPi6v7FCuXAMl4EbQvVQkMcNuXLvUNUL+LM X-Received: by 2002:a17:90b:2395:b0:2b2:b02d:3ffd with SMTP id 98e67ed59e1d1-2bf5e18a697mr10730831a91.15.1716905533125; Tue, 28 May 2024 07:12:13 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716905533; cv=pass; d=google.com; s=arc-20160816; b=Apq39Jihwq9l+AqsRJf3ne/hVbO5Oz4M8fxeenQWrmpNpqzdyBG6hK9PHRGjt2XZ5p hjL8TMGp0epBw9xcEY9ROh56Ok2gGG848W1fxl1c2xg9RiLS/iKagaXq1wXusSS9PczR qIDARNFV1ZfUnO2FO5NAKoCdLCDLezwfm25eHVKjIjoJduJrROlv9Zj3WLDSEnLHhH3v nSPbZcYu8zM5CxMf9ZWoeDDcB/f634XlWcpy3/5Q2tnOsbg5Fx5t/nl9v16WxhgcIiPk r9udaUz9IcQL4nwkadTCl8VUNaa62kMIN38c/YT4cDRNFsTOgsj6uPMPeSuYNc7OXrXw LiLw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=ui-outboundreport:content-transfer-encoding:in-reply-to:from :content-language:subject:references:cc:to:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=x3mRV9ZWaP3e1MlgUeuaRbk+mdm99fVFI5oThwwKG/Y=; fh=CjBOmpLQiBFkkM9UFdU0AMI/y8bNuLUO94M8L0YTln8=; b=fBVHA78RU0aBrfT+SQleuE+OpdYjpOiLUtXU97RJRD4f7mKOtQrhVMlVfL117qv74j Mkqys7hjDjIIQcZ4zbpkjNII/ygs5bbqYlXSGe75JWvlGdX7CENjx5eptIzTUK6gzBRj Gsc5YE/asVpApwrqv5S1wbGhFuMOE0jsK+bvK0Wi/+DoFwj1QuuW3Jl0RLglfZVUpk+H 7mo4WlLuAdp6f2IfWRV0gZZkpBn+IbrmJUIC/GbjffmDJYS60CC1DPs5rfG/s9moLrwK F30FZ39QDSyoDp7A8sdCTyEw+i27GMSRjGQDQbBQgL+paCLIuchefmenSlOfj58lNNld 2lKg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@web.de header.s=s29768273 header.b=CZE5zEbF; arc=pass (i=1 spf=pass spfdomain=web.de dkim=pass dkdomain=web.de dmarc=pass fromdomain=web.de); spf=pass (google.com: domain of linux-kernel+bounces-192498-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-192498-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=web.de Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id 98e67ed59e1d1-2bdda14d4fbsi10004088a91.157.2024.05.28.07.12.12 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 May 2024 07:12:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-192498-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@web.de header.s=s29768273 header.b=CZE5zEbF; arc=pass (i=1 spf=pass spfdomain=web.de dkim=pass dkdomain=web.de dmarc=pass fromdomain=web.de); spf=pass (google.com: domain of linux-kernel+bounces-192498-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-192498-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=web.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id F0CC5B227B6 for ; Tue, 28 May 2024 14:10:31 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 920C416F830; Tue, 28 May 2024 14:10:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b="CZE5zEbF" Received: from mout.web.de (mout.web.de [212.227.15.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B03A316F836 for ; Tue, 28 May 2024 14:10:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.15.14 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716905412; cv=none; b=JW4W8jMiresbob0bQuZhrDGNATEb/AKFEtb5hq4n7JXlcLJWmZmZEwQwUU+g28ee3gX/cx+FCH4joLV6vs2Fe+0OGgWdD8vdyMk3exnFM/ZF3IxGXLH1XgDNJuqtT9JWlpS6cRfKzjvL85uviKgIDE2O9XV4zYcCtvbBu+604Jc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716905412; c=relaxed/simple; bh=wYKyHwOcRbmBl6fi/PN4M7/WvM7jsc6gP0DuKcneGNY=; h=Message-ID:Date:MIME-Version:To:Cc:References:Subject:From: In-Reply-To:Content-Type; b=tWee6vDKuuW7jUvbillutu6lQcocA+VkyQ0vUvUUbwzt60E1estHD7nW1W5H5xwRGvz55ACyqZG5LwM/66n08oORdp9vdlENck2sulyhJ42SVZL9Uy8GQmlngX8s2fH8/o1ScwLN7jLsEk2WAh/9u5CG/g8DLe0UNn3MVTCYDa8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de; spf=pass smtp.mailfrom=web.de; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b=CZE5zEbF; arc=none smtp.client-ip=212.227.15.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=web.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1716905381; x=1717510181; i=markus.elfring@web.de; bh=x3mRV9ZWaP3e1MlgUeuaRbk+mdm99fVFI5oThwwKG/Y=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:To:Cc:References: Subject:From:In-Reply-To:Content-Type:Content-Transfer-Encoding: cc:content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=CZE5zEbF98SWM+qTHSQPtWlKxigEsB3P9HUEEaqgfqDvMnpQB8uFQTzhrtAKuxWq YcKtzzYEojdFfyClJNY1QIrPoyFP7KoT8A+iuXDWr+8f9q84kBI2x+tyiZVuOU1zY gjHLcts5F9+Yy8SHrY2b/xVl3MH2T8bB7zfBCiMx0RJWWhFE7zICNZWym1A9slj00 L8L8voNCjpiPuJNnJt2+8fp+RXkp5s1EGpa96ZkA0r1mt/pgABirR6PGgrXYacuPG kI8/sUFHYhblfgR0Tw4qHp3c6jVLzfe7Qwa12nKMKNagjShTlCkI5AOi7ttWv3OBB h2yExkBB0sw12fwjEw== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.21] ([94.31.83.95]) by smtp.web.de (mrweb005 [213.165.67.108]) with ESMTPSA (Nemesis) id 1M9ISh-1s6kSY0Wu7-00DU2n; Tue, 28 May 2024 16:09:41 +0200 Message-ID: Date: Tue, 28 May 2024 16:09:39 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: kunyu@nfschina.com, Ben Segall , Daniel Bristot de Oliveira , Dietmar Eggemann , Ingo Molnar , Juri Lelli , Mel Gorman , Peter Zijlstra , Steven Rostedt , Valentin Schneider , Vincent Guittot Cc: LKML , Li zeming References: <20240528064532.42532-1-kunyu@nfschina.com> Subject: =?UTF-8?Q?Re=3A_=5BPATCH=5D_sched=3A_core=3A_Remove_unnecessary_?= =?UTF-8?B?4oCYTlVMTOKAmSB2YWx1ZXMgZnJvbSBwZW5kaW5n?= Content-Language: en-GB From: Markus Elfring In-Reply-To: <20240528064532.42532-1-kunyu@nfschina.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:f3Wio4BrB6q2Ptyi59fTYK6zKvM0GX4FV9IUuw88nPOmzXlSzEi qvclbdyAFRNuOZcGeVENdlstnYrlNG10i5YdzYk0cMEwTJeJrKqe4hL/EJHMqSXnq6igqKb PGRTvdYUOwo/OONhUmZM1XSd3SboaPjBXcrc9JBwNf2VY3i0jo5IQBQSuFhE0ofnMYwRRsG n35pMh99JqJ4iaxnW4IxA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:uM4l5juRmsY=;3Wp6zio5SgowleLMICyscfjjFvF L8obBJ9EgrRh4fiBaEDGhnmdgyCPWTI6vKZFh6U+EWru1dINu1h58tBreSoNkTxsZMZlBhgJN 9I6h7hl/ycEwRzbU2XBp5I5Of+iPGzNiqONaxRUOdRRLGyeVv4dLT5Nd8cU3LyXqfWn+uES06 2scd9u4f1DQ/4lXI7Gy+rBqlL1b/kQ0sESDNFgvaso7/lwOM/xRLuWQp37BECFOzcOZCXNXqx BIGt8+noL17Cn6HedaX0WeawPfPNLCrDZxYwyfuDj3qhIx/AaWFNbd3vUx0CRRd4a1LTlycN4 aEUwK/darjAP0hGhKiNUYUjzdlSIxSkqWbKxUXCfBYoGTL9ylDQPvOPMs0u2cCPLvxjtbqa4P bWDZkCwnIdGpP+65FRvoh8xfWVq5HpUVH+4Xu4yz17vBkX0Ay2vJEkkhJiIuNJk0Blm4ocI30 MOLJYJVhjGZmiga/jiGtjMmSedEKk0DrqlOiHF2BtD2n4FCHTufT5jZQfHoEJ2e4vwQCWs6yG t/dDbXdZQIpWNjNAdFpU+cwlSUz2c4gursokmkrLxdLvkMbVFIGYd7Ktd2vwp0Y7z+QgzrYfO 57lIEZJKQ6MrTSLAC+rGrNvQglFZl9Qe8H+Yaj7VoOKJoufx9DHTwCmLAANHgS/9pDyhz5zlX avyQUCIi8ZDqgCE0C7KP6KgfL2Ze3Rc1UlGSKDiy8uEZLRBX8kxOMjxObSwdFCKC8wbR8w/Yy ZGucy+TmzJesrYI4aar6tw+Wib0O6bIdolXEkg9fyjLYGGeauRHq3K+pzy1JpWbtpDf6RoigO 1FMEkq8p69Fzc7BWEKj0mBwl5ZR/Po3fbjGeTviUiI4rk= > pending is assigned first, so it does not need to initialize the > assignment. Would a wording approach (like the following) be a bit nicer? The variable =E2=80=9Cpending=E2=80=9D will eventually be set to an appr= opriate pointer a bit later. Thus omit the explicit initialisation at the beginning. > Signed-off-by: kunyu Can the Developer's Certificate of Origin become clearer another bit? https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Do= cumentation/process/submitting-patches.rst?h=3Dv6.10-rc1#n438 How do you think about to use the summary phrase =E2=80=9CDelete an unnecessary initialisation in affine_move_task()=E2=80= =9D? Regards, Markus