Received-SPF: pass (google.com: domain of linux-kernel+bounces-192506-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240528085221.2989315-1-wenst@chromium.org>
In-Reply-To: <20240528085221.2989315-1-wenst@chromium.org>
From: Simon Glass <sjg@chromium.org>
Date: Tue, 28 May 2024 08:14:46 -0600
Message-ID: <CAFLszTg+Gg=wZDAWX420hA1N04OYM1TY6Yj_JAq4X98TPwaaTw@mail.gmail.com>
Subject: Re: [PATCH v2] scripts/make_fit: Drop fdt image entry compatible string
To: Chen-Yu Tsai <wenst@chromium.org>
Cc: Masahiro Yamada <masahiroy@kernel.org>, Nathan Chancellor <nathan@kernel.org>, 
	Nicolas Schier <nicolas@fjasle.eu>, linux-arm-kernel@lists.infradead.org, 
	linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"

Hi,

On Tue, 28 May 2024 at 02:52, Chen-Yu Tsai <wenst@chromium.org> wrote:
>
> According to the FIT image source file format document found in U-boot [1]
> and the split-out FIT image specification [2], under "'/images' node" ->
> "Conditionally mandatory property", the "compatible" property is described
> as "compatible method for loading image", i.e., not the compatible string
> embedded in the FDT or used for matching.
>
> Drop the compatible string from the fdt image entry node.
>
> While at it also fix up a typo in the document section of output_dtb.
>
> [1] U-boot source "doc/usage/fit/source_file_format.rst", or on the website:
>     https://docs.u-boot.org/en/latest/usage/fit/source_file_format.html
> [2] https://github.com/open-source-firmware/flat-image-tree/blob/main/source/chapter2-source-file-format.rst
>
> Fixes: 7a23b027ec17 ("arm64: boot: Support Flat Image Tree")
> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
> ---
> Changes since v1:
> - Add clear reference to U-boot docs along with excerpt
> - Send separately from "disable compression for DTBs" patch
>
>  scripts/make_fit.py | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>