Received-SPF: pass (google.com: domain of linux-kernel+bounces-192509-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <eb470f47-9957-a8d6-c5c2-aaf5ccc8b9db@amd.com>
Date: Tue, 28 May 2024 09:15:57 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Content-Language: en-US
To: Michael Kelley <mhklinux@outlook.com>, Dexuan Cui <decui@microsoft.com>,
 Dave Hansen <dave.hansen@intel.com>, "x86@kernel.org" <x86@kernel.org>,
 "linux-coco@lists.linux.dev" <linux-coco@lists.linux.dev>,
 "bp@alien8.de" <bp@alien8.de>,
 "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
 Haiyang Zhang <haiyangz@microsoft.com>, "hpa@zytor.com" <hpa@zytor.com>,
 "kirill.shutemov@linux.intel.com" <kirill.shutemov@linux.intel.com>,
 KY Srinivasan <kys@microsoft.com>, "luto@kernel.org" <luto@kernel.org>,
 "mingo@redhat.com" <mingo@redhat.com>,
 "peterz@infradead.org" <peterz@infradead.org>,
 "sathyanarayanan.kuppuswamy@linux.intel.com"
 <sathyanarayanan.kuppuswamy@linux.intel.com>,
 "tglx@linutronix.de" <tglx@linutronix.de>,
 "wei.liu@kernel.org" <wei.liu@kernel.org>, jason <jason@zx2c4.com>,
 "tytso@mit.edu" <tytso@mit.edu>, "ardb@kernel.org" <ardb@kernel.org>
Cc: "linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
 Tianyu Lan <Tianyu.Lan@microsoft.com>
References: <20240523022441.20879-1-decui@microsoft.com>
 <299a83e8-cb13-4599-9737-adb3bb922169@intel.com>
 <SA1PR21MB1317CD997CCD64654B438754BFF52@SA1PR21MB1317.namprd21.prod.outlook.com>
 <SN6PR02MB4157B940ED0A5F39D49A897BD4F52@SN6PR02MB4157.namprd02.prod.outlook.com>
From: Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [RFC PATCH] clocksource: hyper-v: Enable the tsc_page for a TDX
 VM in TD mode
In-Reply-To: <SN6PR02MB4157B940ED0A5F39D49A897BD4F52@SN6PR02MB4157.namprd02.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZXBiYXg2dElqdDM1cEQwMENsV2hIZ0pxUGU2elZJQkxGQlVEQ1lYMlh0UDJk?=
 =?utf-8?B?RTRqRDE0Y2Q1YXAzaVJRdGVlQks1c3ZXOXY3TXBIaWsxZlRIMzZ3SDQrc1B1?=
 =?utf-8?B?V2Q1OVMrOVpEejFzKzJNV21uc29rSjF6Nnl3NDM2WUJLbXF0TVc4L2R5OEx1?=
 =?utf-8?B?bkd2RXJIR3RaTVk5Vmd2d1FYTDg1QnhSay9pVzNPSTFVelNLN0h5R3h1K2Vz?=
 =?utf-8?B?cXlmUE5yZkxsNVRFMUZtRFFMSjgwK3g2Umg4MUxUVm1MeGdKZ3pFQU9LMmJ1?=
 =?utf-8?B?S2ljcmJwY0MxTHQrTzFJYURXcVhSWGNEbVU4UWhvUUdzK1FWaXNxN1paUkts?=
 =?utf-8?B?Ukdham4rTEphOXd4N3o0Um5NbHhiMk5iOTVjL1JDbi9BSGFpNGVsR1hSdnho?=
 =?utf-8?B?KzJBc3lJK2NkN0lSNTZmVHJqbTFZem91aVhjY1ExZ3BwQkx2b3hpdXVLK2ht?=
 =?utf-8?B?Lzkxdlp3Yy9GdG9tczJJeE9aMFh2U2h6aGdOZ1FuZ3NtejBrMnFnUUZCYmFs?=
 =?utf-8?B?WDRPdm16azEzN0JML3IwTmpvUkhCK2xXRnZkUi83ZnNjUWdMdkFqV3M0OC8w?=
 =?utf-8?B?a0ltSmNNVVIyblVwblY1bXBXNmgreTFTVlp0Z1FvcS9WVGxoMzZScklKSHh5?=
 =?utf-8?B?ZzltbFlpbkNhWjg1enN0ZXZlT00wS0FvK2w4VkZtZXdWNzV1d2dmOEJPazhr?=
 =?utf-8?B?L1NhaWJybjhidVVMTHJYeDdlaDl5ZjhsdTBqYmdEUDRwMzE3dlhFYVZkNTFT?=
 =?utf-8?B?SlJNN3FrS1V0UFN2MWFlREdQNXNqUUlWanJYK0V6S1BDZUl4dEpHanJEeTJN?=
 =?utf-8?B?aTZoNFJzRHFOQmk3Q0hxTjZVZENUR3JQNTZ0V0gvTjdjUnY2RC9sSDdlY2U1?=
 =?utf-8?B?dFhTMExqNFVLNElFSzJnL1lQYnlGdEFWWmxqUS9EclR3bVBIUVRnNGdUOUcx?=
 =?utf-8?B?dDdkRHVveHV3dWhrKytKRy9UQzlMRElEUjk5aDFvZlVHN29Gd05TRVpZRGJF?=
 =?utf-8?B?ZHRMZW9HWDJnMXhQc1hQV1FYUDdJM1JBZnlLdmNVMmxrZWF1TnBoenY3cFlx?=
 =?utf-8?B?eTZBbWhsbWQ1Q0RDZEdqOGpINXNRS0ZiWDh5YWFld09mUXZpcVBIZGc1OTN5?=
 =?utf-8?B?ZW54VzluenhoeGdIZUl3bjlRdGdLejA1MEMrRGpXd1ArN2pWVnNMQnU3Tk1R?=
 =?utf-8?B?b2t4aGIxamFwU2U3NzE1YnRqY3lBUW0wT1hJbER3SzVFOWIzQkQ1TzVwTlIz?=
 =?utf-8?B?STVaK24ybXpCb01wbDNVNXJmRU0xZit3VVd2UldhNUY3aGd2UzFyYVM2Tyty?=
 =?utf-8?B?RWFEODIxSnBnV3JtRzJVNVJtNGRFZ0NoS2JPWVQ4Y2ppKzFEN29MM2RENURz?=
 =?utf-8?B?Tm00QStWNzJNR3g0Vmo2dm0zcjFUUlVPRG1wSVhqTnptc284TnlaR1YrWVIx?=
 =?utf-8?B?TzhIbGFJU0VnTEx1M3dIZHc2dU9GVE1EUGhqM2VyVUJUZ3VDenlyZm40NTlU?=
 =?utf-8?B?QTVXZUJhNXlYMUJhY3Jad2pPYjRlb1hiOU11dzdkcWxWVmpUeFNLWE90L3Jr?=
 =?utf-8?B?dlNOZDFtNnRkREJQdktVam1sQm9NZXVWOGxvOXVmZ2FXMHZNTkEwWUVpK2lD?=
 =?utf-8?B?K3BveE1BbnN5Q0k1aWw3a0xVYnZvSEo3S25pUjl2RnVTTVZGYXdhY3kwTWFz?=
 =?utf-8?B?emlKOVJzd045aFV1Qjd1YklkaEdxNmRuVFBmN0F2QWhNemV1eUU1dm5wc1dU?=
 =?utf-8?B?SGF1N3M1ZVFPSFhoODAvbWpBa2VuVjI2eWxjZFEweXhja2t4NDgxd3lkQVdr?=
 =?utf-8?B?clBVa3dJL215TlFGc08xbVIzeDJhbXRqOWp2V1k4RGk1YjJDUjAwSEk2U2lZ?=
 =?utf-8?B?ZkJRYlRBM2xpbUlPUkNyVEZ0UVkwUEt5V0h5R3o4VEFyMEJKaW4xMVJLSzVQ?=
 =?utf-8?B?R3ZjSUJSa1BsRjcwQjFXSDhvWmdvaWEwOC8zV1RJcFcwUFVneFhsUklncFJV?=
 =?utf-8?B?bUovYk1HNDZBcXZsRFJCdi9TY0RlbDdRMHVNQWJTcGxYQ3luQTkvRkk4OEZB?=
 =?utf-8?B?TEc4dlZRYjlPclNPbU9pRTNNTEMvNU1QVWx1cWxVcGZPdFR5U0Y1RUtkdlpo?=
 =?utf-8?Q?Vmt9kgRs52WbzsQbD1AZ2lH5p?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 84795d6d-68c3-4c17-24a4-08dc7f20b334
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5732.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 May 2024 14:16:00.3089
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: oE5daOf+o53/my5NNSdZVDvrfSF/RFiVmWMMNokgW4JxmykrIPVv9bNdfGfMaBHT9H/fNKEVZnTARsx6nw/uyw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR12MB9205

On 5/24/24 17:44, Michael Kelley wrote:
> From: Dexuan Cui <decui@microsoft.com> Sent: Friday, May 24, 2024 1:46 AM
>>> From: Dave Hansen <dave.hansen@intel.com>
>>> Sent: Thursday, May 23, 2024 7:26 AM
>>> [...]
>>> On 5/22/24 19:24, Dexuan Cui wrote:
>>> ...

> 
> My thoughts:
> 
> __bss_decrypted is named as if it applies to any CoCo VM, but really
> it is specific to AMD SEV. It was originally used for a GHCB page, which

IIRC, it was originally used for KVM clock, not the GHCB page, since
plain SEV doesn't use a GHCB, see:

b3f0907c71e0 ("x86/mm: Add .bss..decrypted section to hold shared variables")

> is SEV-specific, and then it proved to be convenient for the Hyper-V TSC
> page. Ideally, we could fix __bss_decrypted to work generally in a
> TDX VM without any dependency on code specific to a hypervisor. But
> looking at some of the details, that may be non-trivial.

In reality, TDX should also make this area shared as that is how this
section is meant to be setup. But up till now, I don't think TDX used
anything in the __bss_decrypted section, so it was never moved to a
common location and has remained SEV specific.

> 
> A narrower solution is to remove the Hyper-V TSC page from
> __bss_decrypted, and use Hyper-V specific code on both TDX and
> SEV-SNP to decrypt just that page (not the entire __bss_decrypted),
> based on whether the Hyper-V guest is running with a paravisor.
>  From Dexuan's patch, it looks like set_memory_decrypted()
> works on TDX at the time that ms_hyperv_init_platform() runs.
> Does it also work on SEV-SNP? The code in kvm_init_platform()
> uses early_set_mem_enc_dec_hypercall() with
> kvm_sev_hc_page_enc_status(), which is SEV only.  So maybe

This is to inform the hypervisor that these pages are now shared, see
below.

> the normal set_memory_decrypted() doesn't work on SEV at
> that point, though I'm not at all clear on what kvm_init_platform is
> trying to do.  Shouldn't __bss_decrypted already be set up correctly?

With SEV, yes, the pagetable is set up correctly. And specific to SNP,
the RMP is set up correctly because of the page state change (PSC) call
which also notifies the hypervisor of the state change.

But since the RMP PSC is SNP specific, SEV and SEV-ES require the
separate hypercall to notify the hypervisor of the state change.

Thanks,
Tom

>