Received-SPF: pass (google.com: domain of linux-kernel+bounces-192539-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Tue, 28 May 2024 15:26:00 +0100
From: Conor Dooley <conor@kernel.org>
To: Naresh Solanki <naresh.solanki@9elements.com>
Cc: Jean Delvare <jdelvare@suse.com>, Guenter Roeck <linux@roeck-us.net>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, linux-hwmon@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: hwmon: Add max6639
Message-ID: <20240528-frame-liqueur-7f37ecc0dad1@spud>
References: <20240528125122.1129986-1-naresh.solanki@9elements.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="EHygdDbVgT6tr7rK"
Content-Disposition: inline
In-Reply-To: <20240528125122.1129986-1-naresh.solanki@9elements.com>


--EHygdDbVgT6tr7rK
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, May 28, 2024 at 06:21:21PM +0530, Naresh Solanki wrote:
> Add Devicetree binding documentation for Maxim MAX6639 temperature
> monitor with PWM fan-speed controller.

Other than unneeded |s where your descriptions don't have any
formatting, this patch looks fine. That said - where's your dts or your
driver? A binding on its own is unusual.

Thanks,
Conor.

--EHygdDbVgT6tr7rK
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZlXpeAAKCRB4tDGHoIJi
0g4dAP4k+S3tFyalBRKB1PYHsAZmy4WUQcyyVrwF3Vao5e7JIgEA7KjfB0skqXwB
focCZ/19rjDXZw4vATfCuQSGoJIArQ0=
=cRrS
-----END PGP SIGNATURE-----

--EHygdDbVgT6tr7rK--