Received-SPF: pass (google.com: domain of linux-kernel+bounces-192543-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Feedback-ID: ifd894703:Fastmail
User-Agent: Cyrus-JMAP/3.11.0-alpha0-491-g033e30d24-fm-20240520.001-g033e30d2
Precedence: bulk
MIME-Version: 1.0
Message-Id: <558b1d58-08a5-410d-97b8-e77def7c1cf8@app.fastmail.com>
In-Reply-To: <9947f7a5-1a95-48f2-b0eb-0385eb2b3d55@app.fastmail.com>
References: <20240517-loongson_nodecnt-v2-1-5bd0bb20ff5f@flygoat.com>
 <87sey3b6de.ffs@tglx> <9947f7a5-1a95-48f2-b0eb-0385eb2b3d55@app.fastmail.com>
Date: Tue, 28 May 2024 15:31:52 +0100
From: "Jiaxun Yang" <jiaxun.yang@flygoat.com>
To: "Thomas Gleixner" <tglx@linutronix.de>,
 "Huacai Chen" <chenhuacai@kernel.org>,
 "Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
 "Daniel Lezcano" <daniel.lezcano@linaro.org>
Cc: linux-kernel@vger.kernel.org,
 "linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>
Subject: Re: [PATCH v2] clocksource: Add node counter timer driver for MIPS/Loongson64
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable


=E5=9C=A82024=E5=B9=B45=E6=9C=8827=E6=97=A5=E4=BA=94=E6=9C=88 =E4=B8=8B=E5=
=8D=885:32=EF=BC=8CJiaxun Yang=E5=86=99=E9=81=93=EF=BC=9A
> =E5=9C=A82024=E5=B9=B45=E6=9C=8827=E6=97=A5=E4=BA=94=E6=9C=88 =E4=B8=8B=
=E5=8D=884:51=EF=BC=8CThomas Gleixner=E5=86=99=E9=81=93=EF=BC=9A
>> Jiaxun!
>>
> Hi Thomas,
> [...]
>>
>> What's this indirection for? Why dont you update=20
> [...]
>>
>>> +static struct clocksource nodecnt_clocksource =3D {
>>> +	.name	=3D "nodecnt",
>>> +	.read	=3D nodecnt_clocksource_read,
>>
>> the read function pointer here and spare the indirection?
> Smart! sched_clock takes slightly different function pointer argument =
type
> but as we don't use the argument anyway, it should be safe to relax th=
is
> indirection.

Sadly, I'm unable to remove it with force type catsing :-/

drivers/clocksource/loongson-nodecnt.c: In function =E2=80=98nodecnt_clo=
cksource_init=E2=80=99:
drivers/clocksource/loongson-nodecnt.c:89:36: warning: cast between inco=
mpatible function types from =E2=80=98u64 (*)(void)=E2=80=99 {aka =E2=80=
=98long long unsigned int (*)(void)=E2=80=99} to =E2=80=98u64 (*)(struct=
 clocksource *)=E2=80=99 {aka =E2=80=98long long unsigned int (*)(struct=
 clocksource *)=E2=80=99} [-Wcast-function-type]
   89 |         nodecnt_clocksource.read =3D (u64 (*)(struct clocksource=
 *))nodecnt_read_fn;

I'll leave it here.

Thanks
>
> Will fix in v3.
>
> Thanks
>>
>> Thanks
>>
>>         tglx
>
> --=20
> - Jiaxun

--=20
- Jiaxun