Received-SPF: pass (google.com: domain of linux-kernel+bounces-192547-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Tue, 28 May 2024 15:36:40 +0100
From: Conor Dooley <conor@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Andreas Kemnade <andreas@kemnade.info>, lee@kernel.org, robh@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org, lgirdwood@gmail.com,
	broonie@kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [RFC PATCH] dt-bindings: regulator: twl-regulator: convert to
 yaml
Message-ID: <20240528-unimpeded-dealing-0128abb54272@spud>
References: <20240528065756.1962482-1-andreas@kemnade.info>
 <e497498c-f3da-4ab9-b6d4-f9723c10471c@kernel.org>
 <20240528131622.4b4f8d03@aktux>
 <f288a1c9-762c-4c66-8611-9a08d6c09bac@kernel.org>
 <20240528150647.40385d08@aktux>
 <3a29c775-4131-4047-9777-4146e6c8eed0@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="yUj0T/sqf3gA9NuE"
Content-Disposition: inline
In-Reply-To: <3a29c775-4131-4047-9777-4146e6c8eed0@kernel.org>


--yUj0T/sqf3gA9NuE
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, May 28, 2024 at 03:54:05PM +0200, Krzysztof Kozlowski wrote:
> On 28/05/2024 15:06, Andreas Kemnade wrote:
> > On Tue, 28 May 2024 13:25:29 +0200
> > Krzysztof Kozlowski <krzk@kernel.org> wrote:
> >=20
> >> On 28/05/2024 13:16, Andreas Kemnade wrote:
> >>> On Tue, 28 May 2024 12:04:22 +0200
> >>> Krzysztof Kozlowski <krzk@kernel.org> wrote:
> >>>  =20
> >>>> On 28/05/2024 08:57, Andreas Kemnade wrote: =20
> >>>>> Convert the regulator bindings to yaml files. To allow only the reg=
ulator
> >>>>> compatible corresponding to the toplevel mfd compatible, split the =
file
> >>>>> into one per device.
> >>>>>
> >>>>> To not need to allow any subnode name, specify clearly node names
> >>>>> for all the regulators.
> >>>>>
> >>>>> Drop one twl5030 compatible due to no documentation on mfd side and=
 no
> >>>>> users of the twl5030.
> >>>>>
> >>>>> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> >>>>> ---
> >>>>> Reason for being RFC:
> >>>>> the integration into ti,twl.yaml seems not to work as expected
> >>>>> make dt_binding_check crashes without any clear error message
> >>>>> if used on the ti,twl.yaml
> >>>>>
> >>>>>  .../devicetree/bindings/mfd/ti,twl.yaml       |   4 +-
> >>>>>  .../regulator/ti,twl4030-regulator.yaml       | 402 ++++++++++++++=
++++
> >>>>>  .../regulator/ti,twl6030-regulator.yaml       | 292 +++++++++++++
> >>>>>  .../regulator/ti,twl6032-regulator.yaml       | 238 +++++++++++
> >>>>>  .../bindings/regulator/twl-regulator.txt      |  80 ----
> >>>>>  5 files changed, 935 insertions(+), 81 deletions(-)
> >>>>>  create mode 100644 Documentation/devicetree/bindings/regulator/ti,=
twl4030-regulator.yaml
> >>>>>  create mode 100644 Documentation/devicetree/bindings/regulator/ti,=
twl6030-regulator.yaml
> >>>>>  create mode 100644 Documentation/devicetree/bindings/regulator/ti,=
twl6032-regulator.yaml
> >>>>>  delete mode 100644 Documentation/devicetree/bindings/regulator/twl=
-regulator.txt
> >>>>>
> >>>>> diff --git a/Documentation/devicetree/bindings/mfd/ti,twl.yaml b/Do=
cumentation/devicetree/bindings/mfd/ti,twl.yaml
> >>>>> index c2357fecb56cc..4ced6e471d338 100644
> >>>>> --- a/Documentation/devicetree/bindings/mfd/ti,twl.yaml
> >>>>> +++ b/Documentation/devicetree/bindings/mfd/ti,twl.yaml
> >>>>> @@ -50,7 +50,7 @@ allOf:
> >>>>>            properties:
> >>>>>              compatible:
> >>>>>                const: ti,twl4030-wdt
> >>>>> -
> >>>>> +        $ref: /schemas/regulator/ti,twl4030-regulator.yaml   =20
> >>>>
> >>>> That's not needed, just like othehr refs below.
> >>>> =20
> >>> but how to prevent error messages like this:
> >>>
> >>> arch/arm/boot/dts/ti/omap/omap2430-sdp.dtb: twl@48: Unevaluated prope=
rties are not allowed ('gpio', 'keypad', 'pwm', 'pwmled', 'regulator-vaux1'=
, 'regulator-vaux2', 'regulator-vaux3', 'regulator-vaux4', 'regulator-vdac'=
, 'regulator-vdd1', 'regulator-vintana1', 'regulator-vintana2', 'regulator-=
vintdig', 'regulator-vio', 'regulator-vmmc1', 'regulator-vmmc2', 'regulator=
-vpll1', 'regulator-vpll2', 'regulator-vsim', 'regulator-vusb1v5', 'regulat=
or-vusb1v8', 'regulator-vusb3v1
> >>>
> >>> esp. the regulator parts without adding stuff to ti,twl.yaml? =20
> >>
> >> Eh? That's a watchdog, not regulator. Why do you add ref to regulator?
> >>
> > hmm, wrongly indented? At what level doet it belong? But as the regualo=
r.yaml stuff can
> > be shortened, maybe just add it directly to ti,twl.yaml to avoid that t=
rouble.
>=20
> I don't follow. The diff here and in other two places suggest you add
> twl-regulator reference to wdt/gpio/whatnot nodes, not to regulators.

The diff may look like that, but I think they're just trying to add it
as a subnode of the pmic. There are other nodes, like the madc that do
this in the same file:
        madc:
          type: object
          $ref: /schemas/iio/adc/ti,twl4030-madc.yaml
          unevaluatedProperties: false

I guess this is what was being attempted, albeit incorrectly.

--yUj0T/sqf3gA9NuE
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZlXr+AAKCRB4tDGHoIJi
0j9uAQC3pwdHQucNm0SqQ0bnTS8kgNAy9mN+8gAmir3pxWrQhwD+PUYyBa08fTN7
WpInMAQB537+Ja8D4ucMVXAXbvr7VgY=
=V9s5
-----END PGP SIGNATURE-----

--yUj0T/sqf3gA9NuE--