Received-SPF: pass (google.com: domain of linux-kernel+bounces-192566-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <c366a946-fa00-44b2-88bd-c724b3b7a39e@huaweicloud.com>
Date: Tue, 28 May 2024 16:45:58 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [RFC][PATCH 4/4] tools/memory-model: Distinguish between
 syntactic and semantic tags
To: Alan Stern <stern@rowland.harvard.edu>
Cc: paulmck@kernel.org, parri.andrea@gmail.com, will@kernel.org,
 peterz@infradead.org, boqun.feng@gmail.com, npiggin@gmail.com,
 dhowells@redhat.com, j.alglave@ucl.ac.uk, luc.maranget@inria.fr,
 akiyks@gmail.com, dlustig@nvidia.com, joel@joelfernandes.org,
 urezki@gmail.com, quic_neeraju@quicinc.com, frederic@kernel.org,
 linux-kernel@vger.kernel.org
References: <20240527152253.195956-1-jonas.oberhauser@huaweicloud.com>
 <20240527152253.195956-5-jonas.oberhauser@huaweicloud.com>
 <5ce0c8a3-bd9c-475a-9427-7edef47a90f2@rowland.harvard.edu>
 <dbcecf28-98e8-4f7e-957b-e73a4d811051@huaweicloud.com>
 <f9ea1b36-b345-4c94-a19f-4fa124d8f7c3@rowland.harvard.edu>
From: Jonas Oberhauser <jonas.oberhauser@huaweicloud.com>
In-Reply-To: <f9ea1b36-b345-4c94-a19f-4fa124d8f7c3@rowland.harvard.edu>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


Am 5/28/2024 um 4:01 PM schrieb Alan Stern:
> On Tue, May 28, 2024 at 02:49:38PM +0200, Jonas Oberhauser wrote:
>>>> +let Mb = MB \ FailedRMW
>>>>>>    (* Compute marked and plain memory accesses *)
>>>> -let Marked = (~M) | IW | Once | Release | Acquire | domain(rmw) | range(rmw) |
>>>> +let Marked = (~M) | IW | ONCE | RELEASE | ACQUIRE | MB | domain(rmw) | range(rmw) |
>>>
>>> The new MB term isn't needed, because MB tags on memory accesses are
>>> filtered out unless the access also belongs to domain(rmw) | range(rmw).
>>>
>>> Alan
>>
>>
>> Thanks for all the notes.
>> I think on this one is needed though under the assumption that herd7 would
>> no longer know internally to replace the MB with ONCE in case
>> of failure.

> Hmmm, this raises another question: Shouldn't the R event for a failed
> cmpxchg_release count as marked?  

Yes.

> At the moment it's not clear how such
> events will be tagged.

If by "at the moment" you mean the current herd7, then (as mentioned in 
the cover letter) this patch does not work at all with the current herd7 
because IIUC in fact ACQUIRE and RELEASE tags will be replaced by Once 
in all cases (so smp_store_release would be a store Once ...).

However, in a hypothetical version of herd7 which just leaves all the 
syntactic tags intact, we would get R & RMW & RELEASE, which would not 
be in the Release set (by nature of failing and being a read) but would 
be Marked (by nature of having a syntactic RELEASE tag).

> Perhaps the best thing to do is add RMW to
> this list, which would make domain(rmw) and range(rmw) unnecessary.


That's also a good idea.

> And then we probably don't need to keep MB

That's correct, although as a failsafe I would probably keep it anyways 
- it doesn't harm, but it may prevent a gotcha.

Have fun,
   jonas