Received: by 2002:a05:6500:1b8f:b0:1fa:5c73:8e2d with SMTP id df15csp33747lqb; Tue, 28 May 2024 08:09:30 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWrPfbLAMAjSgAC5XSrqE9rOIEefN9n7ac5rRuOLt00iP+sDw4z4IknzLvCZICs8D2SGzO66uFlcMFHfJ217vy4X++ZzgvCdOv9JIV5KA== X-Google-Smtp-Source: AGHT+IETFCJM1UPtDgaO1X4mcnDeWvMLZZyryZW2o7FWbBIdWRsN78NSM1/Zag04j8SXNc+rXkVU X-Received: by 2002:a50:cb8c:0:b0:579:c4cd:735d with SMTP id 4fb4d7f45d1cf-579c4cd75d9mr5478647a12.11.1716908970678; Tue, 28 May 2024 08:09:30 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716908970; cv=pass; d=google.com; s=arc-20160816; b=rJdWCHx7juqUbUelYbsTRryT8NDPe0VphoR+Zu1BUWffULA6RwetWWlnfaangn3Uc8 2rPvXWBR+tULn2JhrL69K9A5FHL2TGCbYilRQrHdJWMQd9FXCMY7mTkJ1U9bc8xDrDh2 UjRzDMf96p5OGD2olABxPN6wo/sqN6Ui+Eafj0j8ZFsX6Dkj7zkkZ8yK4/tpa3RfTkb7 TmQZikkOPMT21HBWV94pkGN24OUiCmiim4/Wuu6V7BB/md4nbULdB46UsbkFytP7+Iae RBzNlxVTloGcznS5CvVBgtE4bKVS9mcvjuemfvR0YWZZZwkP8mxVg4OcL+tjCtvhP7B/ P9rw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=ORCopvd8d+TaxF+DCwiEcjkKhkra3u0QQhvKjml+O3o=; fh=KbH7erZcGXouY6SjenZDYKsjv/d9DiNUTeXvZ0adZvk=; b=Yk6TjP/pSll1bWmPSk/bN5BndT/yIJX2YoJbbLSQ+i7wTgTYjlhKm7UIkETuKmC7c/ tcGVsHGhp/bV4HPgbmPybdlSWd7leJA9xwIwXH4qWC4mfje4eNMwX6G12QlwCr1N7Iva lCEi3ekPc0fxFdAnGuEtepBGBq8M1Tdka5TjSf7O1wfbg3iE3uXWrGzq4gLxcceyqfag 9u1hZ+sgUwOEfb2TiaPwnkZ1bmNI5iYn48rlpZXVi/tMobQf+wXmbAkXvujJ6w9c1t7R viz6alhksVmEjmkpjmq15oO7JZIZjWylqPfyXQjeKreOecz+RUUjAWkVjY74nYU5Qs3y Bvmg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=rJCFrejZ; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-192614-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-192614-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id 4fb4d7f45d1cf-5785247b87fsi5213021a12.376.2024.05.28.08.09.30 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 May 2024 08:09:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-192614-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=rJCFrejZ; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-192614-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-192614-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 2582A1F2236F for ; Tue, 28 May 2024 15:09:29 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id BCFCA172796; Tue, 28 May 2024 15:06:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="rJCFrejZ" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE4741E880; Tue, 28 May 2024 15:06:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716908797; cv=none; b=MRkAhaOh2WBXc9WO5VBKA4t0o7dfik4Aq2xbjey+0owwdHPlEspfyhWqO/blciHp3uXqbxWEBOO5+wgW8+qTozxOIxeqgrUb7BnKQA2Io5Gj3b9Xj3WOaXQ0lwbbKJir2VcZaFcSFCH9lyQ6MpM5412DRrQH/VU5npjnuyLl5gY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716908797; c=relaxed/simple; bh=WW8C6Bc9G0Yfb3CfuxmEdX54sinQDMOYusd6wezRaW4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FZCLWAE1EFnrwEfUscDNHmcD6F2rmKSxpL8tvJj1PHC1fgtKW3448F9X233Kd25Ra0jgzU+PXmUVoY110/Rv/twtymj60Tn0wVTvfMdr3sL1G0br6/oIeXmwsa0OuljL9PyVuU880A716qSfyenSBEj8VewkwIYH47v6OvdcPCc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=rJCFrejZ; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0864BC32782; Tue, 28 May 2024 15:06:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1716908796; bh=WW8C6Bc9G0Yfb3CfuxmEdX54sinQDMOYusd6wezRaW4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rJCFrejZ8h7jn7LQBqsHSkoosHWCqAdx9SAEEq26xBbw8w1j/qr8vwinxz/VhupPS aBLKEFm7aN/N47MatW0jKAJZhZDKT3Ah4dFSI+ZqIkDMPsej3xS6TRZgaflQ1C9u4g uE8HcoBYSSXI//rquJlBhTjBeF5UIrnIUnOv/Laai5LFY3DzKTpB46j5lsgljrErTl DsJOQlowXN7Z5yUHQ8TaLfthwG32J/zqo9beR4leCqRCC9LNWsN1/Om2+3rYh1/VFN 1sF2YhxnnsFsnlzUm5XjEdfeQEmEqTbvFi5sXs/phTLfKR9vuOtGDQ3a3WvtDtK9jg KCzoZKJyez3AQ== Date: Tue, 28 May 2024 10:06:33 -0500 From: Bjorn Andersson To: Dmitry Baryshkov Cc: Sebastian Reichel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Hans de Goede , Ilpo =?utf-8?B?SsOkcnZpbmVu?= , Bryan O'Donoghue , Heikki Krogerus , Greg Kroah-Hartman , Konrad Dybcio , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org, Nikita Travkin Subject: Re: [PATCH v3 6/6] arm64: dts: qcom: c630: Add Embedded Controller node Message-ID: References: <20240527-yoga-ec-driver-v3-0-327a9851dad5@linaro.org> <20240527-yoga-ec-driver-v3-6-327a9851dad5@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240527-yoga-ec-driver-v3-6-327a9851dad5@linaro.org> On Mon, May 27, 2024 at 01:03:51PM GMT, Dmitry Baryshkov wrote: > From: Bjorn Andersson Please align this with the S-o-b - feel free to use either form. > > The Embedded Controller in the Lenovo Yoga C630 is accessible on &i2c1 > and provides battery and adapter status, as well as altmode > notifications for the second USB Type-C port. > > Add a definition for the EC. > > Signed-off-by: Bjorn Andersson > Signed-off-by: Dmitry Baryshkov > --- > .../boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 76 ++++++++++++++++++++++ > 1 file changed, 76 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts > index 47dc42f6e936..d975f78eb3ab 100644 > --- a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts > +++ b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts > @@ -370,6 +370,66 @@ zap-shader { > &i2c1 { > status = "okay"; > clock-frequency = <400000>; > + > + embedded-controller@70 { > + compatible = "lenovo,yoga-c630-ec"; > + reg = <0x70>; > + > + interrupts-extended = <&tlmm 20 IRQ_TYPE_LEVEL_HIGH>; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&ec_int_state>; > + > + #address-cells = <1>; > + #size-cells = <0>; > + > + connector@0 { > + compatible = "usb-c-connector"; > + reg = <0>; > + power-role = "dual"; > + data-role = "host"; I was under the impression that this port is wired directly to the SoC and as such this would support data role switching as well. No concern with that, but just out of curiosity, is this not the case? Regards, Bjorn