Received-SPF: pass (google.com: domain of linux-kernel+bounces-192613-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Peng Fan <peng.fan@nxp.com>
To: Arnd Bergmann <arnd@kernel.org>, Vinod Koul <vkoul@kernel.org>, Frank Li
	<frank.li@nxp.com>
CC: Arnd Bergmann <arnd@arndb.de>, Fabio Estevam <festevam@denx.de>,
	"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] dmaengine: fsl-edma: avoid linking both modules
Thread-Topic: [PATCH] dmaengine: fsl-edma: avoid linking both modules
Thread-Index: AQHasPXbPAOa5CRUU0KFUL9aQ5g51bGsvqHA
Date: Tue, 28 May 2024 15:05:35 +0000
Message-ID:
 <DU0PR04MB94178374D1417FE6BC39DA8988F12@DU0PR04MB9417.eurprd04.prod.outlook.com>
References: <20240528115440.2965975-1-arnd@kernel.org>
In-Reply-To: <20240528115440.2965975-1-arnd@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?KGyMAdhoXjTQNBC4ITo97PJ+ysFQnQvdCrtHopiwax31J3OpRM1vJa/ZwyZz?=
 =?us-ascii?Q?+zp4uFaWbSZxzMfnx0RnwFJVAzT/+6mDpIWrjzsrYj7q6CfZOqdYBoa8UMGx?=
 =?us-ascii?Q?CGisVdWQQLvAn3U7k9pu6X/lc/DW3TKyUGzgRwETWXO293o86GkauHNmhgEP?=
 =?us-ascii?Q?TRgVFOZZQ9RNcFufJo+l5/CMfYuurbXyVJ5Q4Pf0MglgyNTU8mDRxsJz3UCQ?=
 =?us-ascii?Q?jUYSkYXEH3QzuWD2KVNhppOxVkt5X0XyPOFDvTFfX6EbUlXR2xP7irJB3KYp?=
 =?us-ascii?Q?Ibwxbg+hgnOF4O2GdZ2qoCN5Nwml1SpDI5axOVUNgsxbnB/q/0Ra7m/KiH1a?=
 =?us-ascii?Q?Fkn6STecQS0gGYqUFS9kN8ZnW3iBWW2oraaneuIF3YqTnDbtvTZ9HkhPDc83?=
 =?us-ascii?Q?M90co8DSqnSY9fMiaY3QYP9KJP3UsbSrL26F32Otzqi06WWOfXElaWvAF8ad?=
 =?us-ascii?Q?ZeWipKGnVEhJAB3gutwBMyluYrfW/56Y2wxxid0IxOES29BklVcT9kGtDB1m?=
 =?us-ascii?Q?ROWwLLrtWzvkxdtrFN8B/CfHCXz0QZ6eZ3bfGyGB9c27yMSVHqYLM9LucBeW?=
 =?us-ascii?Q?P0TP36jgnwwLCgbpOk5wUmoS4YtD/IFjkTTfSXUSglcraRrYdsUdvpkWlZ5C?=
 =?us-ascii?Q?vTc+omU2V3uF+ZQu3ySy01+nTiwQhUHp6vEapvmWYkQENE0G/P/OPjL7FiYJ?=
 =?us-ascii?Q?810V2rByH9KNtx5JxE4sx3TEvcb2N25siq2LMAE6PcwEzFiJIoQBYgxRgENY?=
 =?us-ascii?Q?vMQ/oDkOZ9g/4ITU8E2rJ2QbYRVhr+TPbDv9vdPdtzNzqUp3Ds/5j36sM+fv?=
 =?us-ascii?Q?INAZVi8B0hdtVeUiehYy+vAQkyMLyCPbhFOumQa5jIHBqXf2bRtT3dvOhuot?=
 =?us-ascii?Q?tmpo02JnvCWH3teei2N+JxP6bmBOJjlALLsca5l6oQjFE9Cz2TFy9ltRECW3?=
 =?us-ascii?Q?d+9u2hWq9ioR7Vsts5ea7zCeJUD3l20faujVLtluMkSzr39PByYtZl8QLJtx?=
 =?us-ascii?Q?LySsmF+9oK5LeR1KhGOYZPwRKgcrmqJRI27UVpK/Oe4l2FMulvx8BdctRW3C?=
 =?us-ascii?Q?osAprRXxohZIsa+0yio1Ks80FTQB2znUmzfv4jMC8HSitsAh2Br97wt6DPRV?=
 =?us-ascii?Q?Jf1Wp8rz+t/ubrUmFvQJhojazXuaOdQxXYAc4qPS9xpBlmTRGtue1bkFlagC?=
 =?us-ascii?Q?9Bb2N+v5r0GJLO2Gl2BLvp3KYXsVC536TlyBntN3FQomb77O91JeT2N3zRZL?=
 =?us-ascii?Q?nLpUZL/+rQnG6ZZ5AFqP3R1Zy7AX1bFPxr1ofvNVNo4+M7JeNoh4RD9iUCJT?=
 =?us-ascii?Q?D/dVUlOXhjaPvNW4j8hqLM40hzNH5+UAPiXQhuDFkITzoL45eJTHZbnrzOyi?=
 =?us-ascii?Q?VjYGXUcNx2EZdX7eJawTY+PoVD6kLLLjTBjIrdbtgbzmQNX530QGT3fZclvN?=
 =?us-ascii?Q?qs3TEx8gIMBaZTv2ZWyAbHoUvClKOC0a6YlUG//qE0RKpPjk3sPaolSbYSWP?=
 =?us-ascii?Q?BwX03aOXQ02WQXHpMCldRF/UEyth9w/AOsRNLEyA/06Gp+ZL7+YmhZKGDEOT?=
 =?us-ascii?Q?C53JUZdEhVkmdR1YMEg=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 80e1ff3e-a949-4fe8-91d4-08dc7f27a0db
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 May 2024 15:05:35.8405
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: lsLn7KNnfYoriCoBNqbFsbEhy/bkjZRcVs6SySTicj2IdkrgImqsXFmxSu4IMeaM+cxiK99ADgy6JJ6qSkvVJg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB7522

> Subject: [PATCH] dmaengine: fsl-edma: avoid linking both modules
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> Kbuild does not support having a source file compiled multiple times and
> linked into distinct modules, or built-in and modular at the same time. F=
or fs-
> edma, there are two common components that are linked into the fsl-
> edma.ko for Arm and PowerPC, plus the mcf-edma.ko module on Coldfire.
> This violates the rule for compile-testing:
>
> scripts/Makefile.build:236: drivers/dma/Makefile: fsl-edma-common.o is
> added to multiple modules: fsl-edma mcf-edma
> scripts/Makefile.build:236: drivers/dma/Makefile: fsl-edma-trace.o is add=
ed
> to multiple modules: fsl-edma mcf-edma
>
> I tried splitting out the common parts into a separate modules, but that =
adds
> back the complexity that a cleanup patch removed, and it gets harder with
> the addition of the tracepoints.
>
> As a minimal workaround, address it at the Kconfig level, by disallowing =
the
> broken configurations.
>
> Link:
> https://lore.ke/
> rnel.org%2Flkml%2F20240110232255.1099757-1-
> arnd%40kernel.org%2F&data=3D05%7C02%7Cpeng.fan%40nxp.com%7Cfb9b0e
> 6533054fee3d0d08dc7f0cfbe4%7C686ea1d3bc2b4c6fa92cd99c5c301635%7
> C0%7C0%7C638524940949353893%7CUnknown%7CTWFpbGZsb3d8eyJWIj
> oiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0
> %7C%7C%7C&sdata=3D88jDqMK7okvOsZaMXT02p7coSRTr2r%2FArF1rbAp9P4
> w%3D&reserved=3D0
> Fixes: 66aac8ea0a6c ("dmaengine: fsl-edma: clean up EXPORT_SYMBOL_GPL
> in fsl-edma-common.c")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Acked-by: Peng Fan <peng.fan@nxp.com>
> ---
>  drivers/dma/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig index
> 965fa49668ff..b3873d01a2ab 100644
> --- a/drivers/dma/Kconfig
> +++ b/drivers/dma/Kconfig
> @@ -394,7 +394,7 @@ config LS2X_APB_DMA
>
>  config MCF_EDMA
>       tristate "Freescale eDMA engine support, ColdFire mcf5441x SoCs"
> -     depends on M5441x || COMPILE_TEST
> +     depends on M5441x || (COMPILE_TEST && FSL_EDMA=3Dn)
>       select DMA_ENGINE
>       select DMA_VIRTUAL_CHANNELS
>       help
> --
> 2.39.2