Received-SPF: pass (google.com: domain of linux-kernel+bounces-192654-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
MIME-Version: 1.0
References: <20240524033819.1953587-1-yosryahmed@google.com> <20240524033819.1953587-4-yosryahmed@google.com>
In-Reply-To: <20240524033819.1953587-4-yosryahmed@google.com>
From: Nhat Pham <nphamcs@gmail.com>
Date: Tue, 28 May 2024 08:18:24 -0700
Message-ID: <CAKEwX=O9nUPwokH__KsT+M6H=6KougJfD1rm4=2G7zmyK0NA+A@mail.gmail.com>
Subject: Re: [PATCH 3/3] mm: zswap: make same_filled functions folio-friendly
To: Yosry Ahmed <yosryahmed@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, Johannes Weiner <hannes@cmpxchg.org>, 
	Chengming Zhou <chengming.zhou@linux.dev>, Matthew Wilcox <willy@infradead.org>, linux-mm@kvack.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, May 23, 2024 at 8:38=E2=80=AFPM Yosry Ahmed <yosryahmed@google.com>=
 wrote:
>
> A variable name 'page' is used in zswap_is_folio_same_filled() and
> zswap_fill_page() to point at the kmapped data in a folio. Use 'data'
> instead to avoid confusion and stop it from showing up when searching
> for 'page' references in mm/zswap.c.
>
> While we are at it, move the kmap/kunmap calls into zswap_fill_page(),
> make it take in a folio, and rename it to zswap_fill_folio().
>
> Signed-off-by: Yosry Ahmed <yosryahmed@google.com>

Seems reasonable to me.
Reviewed-by: Nhat Pham <nphamcs@gmail.com>