Received-SPF: pass (google.com: domain of linux-kernel+bounces-192656-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Tue, 28 May 2024 16:20:25 +0100
From: Conor Dooley <conor@kernel.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Naresh Solanki <naresh.solanki@9elements.com>,
	Jean Delvare <jdelvare@suse.com>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, linux-hwmon@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: hwmon: Add max6639
Message-ID: <20240528-deduct-juggle-4ff2e7fae06e@spud>
References: <20240528125122.1129986-1-naresh.solanki@9elements.com>
 <20240528-frame-liqueur-7f37ecc0dad1@spud>
 <c11900ec-dd03-43b7-916a-dc7315bb50b5@roeck-us.net>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="9sDXjxEizOp8NBIa"
Content-Disposition: inline
In-Reply-To: <c11900ec-dd03-43b7-916a-dc7315bb50b5@roeck-us.net>


--9sDXjxEizOp8NBIa
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, May 28, 2024 at 07:41:58AM -0700, Guenter Roeck wrote:
> On 5/28/24 07:26, Conor Dooley wrote:
> > On Tue, May 28, 2024 at 06:21:21PM +0530, Naresh Solanki wrote:
> > > Add Devicetree binding documentation for Maxim MAX6639 temperature
> > > monitor with PWM fan-speed controller.
> >=20
> > Other than unneeded |s where your descriptions don't have any
> > formatting, this patch looks fine. That said - where's your dts or your
> > driver? A binding on its own is unusual.
> >=20
>=20
> The driver is drivers/hwmon/max6639.c which needs other unrelated changes/
> cleanups. Holding those up until the bindings are accepted would not make
> sense, so my guess is that Naresh decided to pursue the other changes for=
 now
> and add devicetree support to the driver after the devicetree properties
> have been approved. On the other side, adding devicetree support does dep=
end
> on the other changes, so trying to do that before the other changes are
> complete would be difficult.
>=20
> That is just my guess, though, and I am ok with it.

Well, I think the binding is fine, so it is up to you whether you want
to merge the binding without having the driver implementation nailed
down.

Ideally with the |s removed,
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Thanks,
Conor.

--9sDXjxEizOp8NBIa
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZlX2OQAKCRB4tDGHoIJi
0uc8AQCzupW+/6KLITUMKXvrN3b4eLuQhtSXFtOOwZUsnzMPmQD+NOOPuU68KhXX
NAzkgBAfiRBk8yNzpli2gf+Ww7QvrAw=
=ySB5
-----END PGP SIGNATURE-----

--9sDXjxEizOp8NBIa--