Received-SPF: pass (google.com: domain of linux-kernel+bounces-192720-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <e3ec5070-abb7-4adc-9cd1-c459ca27b531@intel.com>
Date: Tue, 28 May 2024 09:08:09 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 0/3] dmaengine: ioatdma: Fix mem leakage series
To: n.shubin@yadro.com, Vinod Koul <vkoul@kernel.org>,
 Logan Gunthorpe <logang@deltatee.com>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
 Nikita Shubin <nikita.shubin@maquefel.me>, dmaengine@vger.kernel.org,
 linux-kernel@vger.kernel.org, linux@yadro.com
References: <20240528-ioatdma-fixes-v2-0-a9f2fbe26ab1@yadro.com>
Content-Language: en-US
From: Dave Jiang <dave.jiang@intel.com>
In-Reply-To: <20240528-ioatdma-fixes-v2-0-a9f2fbe26ab1@yadro.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


On 5/27/24 11:09 PM, Nikita Shubin via B4 Relay wrote:
> Started with observing leakage in patch 3, investigating revealed much
> more problems in probing error path.
> 
> Andy you are always welcome to review if you have a spare time.
> 
> Thank you Andy and Markus for your comments.
> 
> Signed-off-by: Nikita Shubin <n.shubin@yadro.com>
> ---
> Changes in v2:
> - dmaengine: ioatdma: Fix error path in ioat3_dma_probe():
>   Markus:
>     - fix typo
> 
> - dmaengine: ioatdma: Fix kmemleak in ioat_pci_probe()
>   Andy:
>     - s/int/unsigned int/
>     - fix spelling errors
>     - trimmed kmemleak reports
> 
> - Link to v1: https://lore.kernel.org/r/20240524-ioatdma-fixes-v1-0-b785f1f7accc@yadro.com
> 
> ---
> Nikita Shubin (3):
>       dmaengine: ioatdma: Fix leaking on version mismatch
>       dmaengine: ioatdma: Fix error path in ioat3_dma_probe()
>       dmaengine: ioatdma: Fix kmemleak in ioat_pci_probe()
> 
>  drivers/dma/ioat/init.c | 54 ++++++++++++++++++++++++++-----------------------
>  1 file changed, 29 insertions(+), 25 deletions(-)
> ---
> base-commit: 6d69b6c12fce479fde7bc06f686212451688a102
> change-id: 20240524-ioatdma-fixes-a8fccda9bd79

Thanks for the fixes. 

Reviewed-by: Dave Jiang <dave.jiang@intel.com> for the series

Would be nice if someone wants to move everything to the devm_* management APIs. Would make this a lot less messy. Probably not worth the effort though given how old the driver is and no more devices are being created to use this driver. 

> 
> Best regards,