Received: by 2002:a05:6500:1b8f:b0:1fa:5c73:8e2d with SMTP id df15csp81682lqb; Tue, 28 May 2024 09:21:16 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXAwGO76L8qvQfGcBzfMBIMOAgvm6d/B+H39CeE7DSBKMq0rEv5bkGklvf9nIw2JuyCHpwevSlETBx4IvbmzbEjXDlbdPZnkWvnJP/NSw== X-Google-Smtp-Source: AGHT+IGzy6oBjb26O/HyNMP4kjmzwIiMgHm9R+31Y0eCwIMf1Eq1tsoOFE6znK3FPSu/s0oDLFeD X-Received: by 2002:a19:8c1e:0:b0:520:9775:5d3f with SMTP id 2adb3069b0e04-529644ebeb8mr8337366e87.7.1716913276464; Tue, 28 May 2024 09:21:16 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716913276; cv=pass; d=google.com; s=arc-20160816; b=nJnuFki0GCFQ8EO4FIVClTBhP2HchB7Px7F/KnZ/WlIN/8s6JF922nYv7klRAPC02X QSKhHcm4+zpwlsfzfqeDCYtu7xtZSl/YXou9MoqmAmVboJouoUie8NB4Hk1D6uZ4YAII eWs/S4tvuKQg8vq/HFDZnNhsjZWOHOhpQnRJQ8u8y31lkew6+hdgPoHRbcqX/S9aea9w H8jFB7Bk6+YXcEaWlNkKUnFAXr8Sg4LA3gDvl00fdRp5QlPzwPRW5S7VgavPuLXAkooB 6KuTh58dODeO8JZtieL1ONIpIunQJpYrzV2MMxfFtXAQmRP5JVEGvV+anqDwVrVLdn3r oT5Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :references:message-id:subject:cc:to:from:date:dkim-signature; bh=kE86HA2Pl0WMSgmbtH/SqDoMVET8ixgS0B8pGBr9o2Y=; fh=UTwFoNoRPs5fVM5t32PDjtFy+0Je/E62EGomTFLzp10=; b=eyzOypL8VMbykGwtMu+LMSz7ngxakeM571kFx68DbmAFonmEXNcV6CDJFT01xe6TYV f2+ZBEu2hnU8uVUZL/URt4eSbHTNLocktksz2RGs5XPTtY5U4gRz4mKOwrwB1PDKcadl HhKbAfmXhW9F98HzLiDxnvDzou2UrHX2KbaZWWLRB000qhQRVRdTfk0G7ctlLxbAVw0z sAqJaVYbaWmPujZtdVcw/m6N4omHN9WpYS+XMPrvFag/wU8Emzt9JHwUv5SU2tm7uw4e bX5Nu4W3nyHen4NgpEFPeYUWdNcKadq5BzULk0uCYTbD16o4Vm8gx8rHEpaVJQvYMcF/ IYag==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=SxkxAFRw; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-192741-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-192741-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id 4fb4d7f45d1cf-579c5702445si3410992a12.593.2024.05.28.09.21.16 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 May 2024 09:21:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-192741-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=SxkxAFRw; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-192741-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-192741-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 03FFE1F24B3A for ; Tue, 28 May 2024 16:21:16 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 487D6172BAB; Tue, 28 May 2024 16:21:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="SxkxAFRw" Received: from out-173.mta0.migadu.com (out-173.mta0.migadu.com [91.218.175.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3020A172786 for ; Tue, 28 May 2024 16:21:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716913266; cv=none; b=tXPb+mj4MivMrIzo/rLZEbZYHS7mpFcDmzZTsTQp/efZBl4aXdCP651ggpMommSxC1pub+X5yVa0O5HXfH2R/shAZLSyKg/xcH6elebYkBqVMcY8aa8S/W+7bWad96LP3UHHwZ7i/hzAEYzOCID0kyvHBhN87ba4Hb0OFVUJkNM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716913266; c=relaxed/simple; bh=miDkAeIGeL8VtGuuCoBcxE9mF0TAA/w+xpazhCoV2j4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Lhv20YmM5mWgsooJ8ey7yphwwZ5XaGG/Mu88YBM+jtgUm3+VNTlFCV0tpJiaPw6eVLi34ZoL57A9Qqm3Q3gED7QuR62FAqn4u0M3ziRzC/7d06nhiJ6h/SJfhPkM1y2aoHwqXEebxGh6B8xqiSXJ6zZZTA7HJCZOj0+pymrsxVY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=SxkxAFRw; arc=none smtp.client-ip=91.218.175.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev X-Envelope-To: bigeasy@linutronix.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1716913261; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kE86HA2Pl0WMSgmbtH/SqDoMVET8ixgS0B8pGBr9o2Y=; b=SxkxAFRwvnEYce/S8woEfiSMwbGyG6lAcmE9c7Z6D8c18JY4ADn3/YM5h1L1Ij1S00/mkq D+D00IFcgn6vNp0+nM2jUOxqS/UQ1GEkAys9zesCfi/Clrx5rsC8yZowR8de1lrfqosZqv w8DlDj9bu4YZ1jjJc2KSMl3MHD3MgvE= X-Envelope-To: vbabka@kernel.org X-Envelope-To: akpm@linux-foundation.org X-Envelope-To: hannes@cmpxchg.org X-Envelope-To: mhocko@kernel.org X-Envelope-To: roman.gushchin@linux.dev X-Envelope-To: muchun.song@linux.dev X-Envelope-To: linux-mm@kvack.org X-Envelope-To: linux-kernel@vger.kernel.org X-Envelope-To: tglx@linutronix.de Date: Tue, 28 May 2024 09:20:56 -0700 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Sebastian Andrzej Siewior Cc: "Vlastimil Babka (SUSE)" , Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Thomas Gleixner Subject: Re: [PATCH v2] memcg: Remove the lockdep assert from __mod_objcg_mlstate(). Message-ID: References: <20240528121928.i-Gu7Jvg@linutronix.de> <09e085bb-f09e-4901-a2dd-a0b789bb8a4d@kernel.org> <20240528134027.OxDASsS3@linutronix.de> <20240528141341.rz_rytN_@linutronix.de> <20240528150856.u4rArjaq@linutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240528150856.u4rArjaq@linutronix.de> X-Migadu-Flow: FLOW_OUT On Tue, May 28, 2024 at 05:08:56PM GMT, Sebastian Andrzej Siewior wrote: > On 2024-05-28 07:59:57 [-0700], Shakeel Butt wrote: > > One question on VM_WARN_ON_IRQS_ENABLED() in __mod_memcg_lruvec_state(). > > On a PREEMPT_RT kernel with CONFIG_DEBUG_VM, will that > > VM_WARN_ON_IRQS_ENABLED() cause a splat or VM_WARN_ON_IRQS_ENABLED is > > special on PREEMPT_RT kernels? > > we have the following in the header file: > > | #ifdef CONFIG_DEBUG_VM_IRQSOFF > | #define VM_WARN_ON_IRQS_ENABLED() WARN_ON_ONCE(!irqs_disabled()) > | #else > | #define VM_WARN_ON_IRQS_ENABLED() do { } while (0) > | #endif > > and this in Kconfig: > | config DEBUG_VM_IRQSOFF > | def_bool DEBUG_VM && !PREEMPT_RT > | > > which means on PREEMPT_RT we end up with "do {…" Thanks for the explanation.