Received-SPF: pass (google.com: domain of linux-kernel+bounces-192745-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <a2036c46-0527-4ac3-a40b-c9c2cd3e185e@web.de>
Date: Tue, 28 May 2024 18:22:23 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: soundwire: fix usages of device_get_named_child_node()
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
 Bard Liao <yung-chuan.liao@linux.intel.com>, linux-sound@vger.kernel.org,
 Vinod Koul <vkoul@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Bard Liao <bard.liao@intel.com>,
 Vinod Koul <vinod.koul@linaro.org>
References: <20240528063533.26723-1-yung-chuan.liao@linux.intel.com>
 <0080bd18-58e1-4e82-96e0-e64d2fa978c9@web.de>
 <9d5f2625-f3e7-4212-8c9a-c22f137f39d9@linux.intel.com>
Content-Language: en-GB
From: Markus Elfring <Markus.Elfring@web.de>
In-Reply-To: <9d5f2625-f3e7-4212-8c9a-c22f137f39d9@linux.intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:js6plXQPR28=;NxkUglzSnCjMlmjBbGwe2TU+qT1
 dquw5HV3GSAdqaW4R1byAR1VsCQ+J8a7a//PThtcXar+f0cwLPhY7G0CtAO/ixp9bgaIzgwXe
 d7Quea9tMzGZmZr5KuwEsU/qDPhyGDnECcbGhsVHx4iNoDSBlm7sWwppy3PQCP3QTp7YZ/58j
 Fm4s/ctHoTzwRsokAuVLrDyd3h0wIn6dH7/E7ixjEVHj4IDmtHS6gENzkTLChmB1QxF9/4tUa
 VjPIiQgVEnhq9qKWTey4ZWQimLX6a4TMGFddeafb3/HqL6cvBED1Awhl2s6B62YQ+fb/Ebx+C
 6cZ7QOPPq8EhI5Qku5yqq5GJGkByHdYJnU04JE/5/W7zrMsSUnPUKhDzg53ID0p/Nxyx30zAx
 HSw3lvOyWD7U8jJjC9RqT8AaHN1DfRF324NmFtku0ITcz7RpQIp2EjGZkm2EwN7UZdSYm2wNF
 DlITDKxgVNgtfpQuS9QHPr3KTPaupIrcnwZ1MI9ZfnffNsPeq/DEB6XlJQOsmKog+63xQJWAJ
 xQfOSw66SIb1Pr5dZBAxxgtb109QuRsjfFWjc0HjKobbIAxNEm9Vrf5bZTB3p9vy/X8mkjTy/
 2cDVpQ9EYDov5hVxPNG3tYVt6Q2m0n/vxCkYNiNdX+FgT7okMzizN1Sq8x/tIya98ZrpdT2NB
 XDMXnVx5HyZycUoL4DrN5FbGkGRNJqwFNW2vLs5AhfjJtGjMh3ATN/okE4vZqybY1PwgQABHp
 51wcv4vIvspyJKfL8PemwDeZfHMjJxnl6WYaa60CT7pDUsQrQoCYhGSE0somERX1KlvE07f+B
 7pdvOyBytyk+J8ZcH94mcKzvn72dvG6nuKBhebxBb32ao=

>>> Add fwnode_handle_put() to avoid leaked references.
>>
>> Are you going to respond also to my previous patch review
>> in more constructive ways?
>> https://lore.kernel.org/lkml/eb15ab0a-e416-4ae9-98bb-610fdc04492c@web.d=
e/
>> https://lkml.org/lkml/2024/4/29/493
>
> Sorry about that, both Bard and I missed your comments.

How could this happen?


> On the Fixes tag: I made a deliberate choice to add all the fixes in one
> patch, to show that the usage was copy-pasted and done 'wrong' in
> multiple places. That makes it really hard to add a Fixes tag since the
> different uses were added in a time interval of about 5 years.

Is it interesting how the affected software components evolved in the mean=
time?


> We could split and have multiple patches if that was desired, but I
> would still not include a Fixes tag since the leaked references are not
> that bad, we read the Manager properties on probe, and the peripheral
> properties are generally not used by codec drivers, so it's unlikely
> that any user will ever see a problem that requires a backport in linux-=
stable.
=E2=80=A6

I became curious how the exception handling will be completed here.

* Do you still care for the usage of goto chains?
  https://wiki.sei.cmu.edu/confluence/display/c/MEM12-C.+Consider+using+a+=
goto+chain+when+leaving+a+function+on+error+when+using+and+releasing+resou=
rces

* How do you think about to increase the application of scope-based resour=
ce management?
  https://elixir.bootlin.com/linux/v6.10-rc1/source/include/linux/cleanup.=
h#L124


Regards,
Markus