Received: by 2002:a05:6500:1b8f:b0:1fa:5c73:8e2d with SMTP id df15csp95864lqb; Tue, 28 May 2024 09:44:44 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXFj8r2ByBS0P2PYWC7vpQUdpKB6B7jv1BzAjKK3CDg6nxmG6XP/mFuUqbN+8rvFYIemwgNqZXyPvQV5WO6X0Df7yMyfW3WSDKPQun16g== X-Google-Smtp-Source: AGHT+IEgo5Fm4WyO/rKjNdBFL5JZB6NGGnPdYBW435Oqdl2ncIMueJI6n5wcrGu8zNj896XX/+NP X-Received: by 2002:a67:ad13:0:b0:48b:90ea:451 with SMTP id ada2fe7eead31-48b90ea058amr2076635137.35.1716914684071; Tue, 28 May 2024 09:44:44 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716914684; cv=pass; d=google.com; s=arc-20160816; b=GLfZU5DRTA63/f3V1/LryFEzyPIFIYka+r07GZtHrJ9Dob/038cA8elWZCHXJ12g4q CzbinkiuS5FM/dFHThn2rZmxekZtwThEghYlR+nnuxuaXNC3OGSOkzab2W0pn5onEED2 QOf+zP6uFu2fd/0DUtJKMlcJeN6QjuQJ6cPdbkX2FKsYknfwjZdc/hP5oczoei8zl2W8 RisfGv3bPTOjtPEmWtDMJvh2ToC1KxJxeCcB7lsQlcLMBVPHWGKXNMMI8P6/MXpNy9vg iGKap0z2yAzL6YZlJisRmwk9x2mG91da/hHjwLGMkw6kptxgVf1dpZtePRzzk7aNmwoB jMSQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:user-agent:date :message-id:organization:from:references:cc:to:subject; bh=IOfp8cIr7A9lZBMsmHmzvmITeajz1pH6CHKPW9WdZpY=; fh=6J0mQSvL1R6IrgTiGMaCDMm/gQZugI0exFAhUzhS1Vg=; b=xBVzc/LBBKlJXPeVBZ9hwyQfLxxR9/Jm0sqtnxJSVxBO1HlBPp0NvSumVvXP27qTLc +w1NEQJmSGtZ/q/xzWZOQRnhvXWjB/0fp9vYfS08+cl4PABVu+BHCey82zIODADjBRSu sEKJtV/LG5tGO7gbP1bx69x3uXePk8L6q9/IOVkK5ksGcvdDKTA9NtEnODPqy43+yPfn HzrysvE77dWJWqH5mG63ISIlV4iVB10T255PsafYcLsHNkPrKO0E7LZbDDPuvUw9Qpnk H41Nz1fqbwcyuORLFokG/1zIscvhI6xF5dLvKbAm/74aNsPHgRYthgKvv145QFGg8zJv rOzw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=omp.ru); spf=pass (google.com: domain of linux-kernel+bounces-192771-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-192771-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id af79cd13be357-794abd4cbbesi1052733085a.572.2024.05.28.09.44.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 May 2024 09:44:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-192771-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=omp.ru); spf=pass (google.com: domain of linux-kernel+bounces-192771-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-192771-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id C885C1C22E65 for ; Tue, 28 May 2024 16:44:43 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 40C85173320; Tue, 28 May 2024 16:44:35 +0000 (UTC) Received: from mx01.omp.ru (mx01.omp.ru [90.154.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5AD0D172BB6; Tue, 28 May 2024 16:44:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.154.21.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716914674; cv=none; b=OhzN8Y6M79AWg3GDnD+KbirKbXC01BE6rpzX30gsCSX6Olj4mQOHQ0TWL3L4h8wK6aCSpMVazuhcABO2c2QyC1AgOX7Jm5xScqMxnOKOuBLm8JsnAO+KF/fuKnAr5gz4+5N8AZU3WUyTynLKJvatfX+O+XBcHbk++haNsLLTxBM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716914674; c=relaxed/simple; bh=wirEkR+pfwBItQse/OHEsogSAK2AfZ2DNuPaME/DHB4=; h=Subject:To:CC:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=MjL/7Wmy/MXnTjhbNHZisy9zylqqej/WXbXe8XK+LWP1CMu3qiSsktICMcbB/eMN0YZoIqzuKSeTyq5+zTWgivdGLpWi+x+rsrd8W+1HjmGBTFrTBJ1cDhM4us4qaSoB0v1CAhoEUp59FPVgVN6aA2q/R0SMERKxal81JZncSSM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=omp.ru; spf=pass smtp.mailfrom=omp.ru; arc=none smtp.client-ip=90.154.21.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=omp.ru Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=omp.ru Received: from [192.168.1.105] (178.176.78.2) by msexch01.omp.ru (10.188.4.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.1258.12; Tue, 28 May 2024 19:44:21 +0300 Subject: Re: [net-next PATCH v4 2/7] net: ravb: Consider busypolling status when re-enabling interrupts To: Paul Barker , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , =?UTF-8?Q?Niklas_S=c3=b6derlund?= CC: Biju Das , Claudiu Beznea , Yoshihiro Shimoda , , , References: <20240528150339.6791-1-paul.barker.ct@bp.renesas.com> <20240528150339.6791-3-paul.barker.ct@bp.renesas.com> From: Sergey Shtylyov Organization: Open Mobile Platform Message-ID: <669d3b51-d068-8816-37d1-dab2ffadb250@omp.ru> Date: Tue, 28 May 2024 19:44:21 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <20240528150339.6791-3-paul.barker.ct@bp.renesas.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: msexch01.omp.ru (10.188.4.12) To msexch01.omp.ru (10.188.4.12) X-KSE-ServerInfo: msexch01.omp.ru, 9 X-KSE-AntiSpam-Interceptor-Info: scan successful X-KSE-AntiSpam-Version: 6.1.0, Database issued on: 05/28/2024 16:25:02 X-KSE-AntiSpam-Status: KAS_STATUS_NOT_DETECTED X-KSE-AntiSpam-Method: none X-KSE-AntiSpam-Rate: 59 X-KSE-AntiSpam-Info: Lua profiles 185551 [May 28 2024] X-KSE-AntiSpam-Info: Version: 6.1.0.4 X-KSE-AntiSpam-Info: Envelope from: s.shtylyov@omp.ru X-KSE-AntiSpam-Info: LuaCore: 20 0.3.20 743589a8af6ec90b529f2124c2bbfc3ce1d2f20f X-KSE-AntiSpam-Info: {rep_avail} X-KSE-AntiSpam-Info: {Tracking_from_domain_doesnt_match_to} X-KSE-AntiSpam-Info: {relay has no DNS name} X-KSE-AntiSpam-Info: {SMTP from is not routable} X-KSE-AntiSpam-Info: {Found in DNSBL: 178.176.78.2 in (user) b.barracudacentral.org} X-KSE-AntiSpam-Info: 127.0.0.199:7.1.2;d41d8cd98f00b204e9800998ecf8427e.com:7.1.1;omp.ru:7.1.1 X-KSE-AntiSpam-Info: ApMailHostAddress: 178.176.78.2 X-KSE-AntiSpam-Info: {DNS response errors} X-KSE-AntiSpam-Info: Rate: 59 X-KSE-AntiSpam-Info: Status: not_detected X-KSE-AntiSpam-Info: Method: none X-KSE-AntiSpam-Info: Auth:dmarc=temperror header.from=omp.ru;spf=temperror smtp.mailfrom=omp.ru;dkim=none X-KSE-Antiphishing-Info: Clean X-KSE-Antiphishing-ScanningType: Heuristic X-KSE-Antiphishing-Method: None X-KSE-Antiphishing-Bases: 05/28/2024 16:28:00 X-KSE-Antivirus-Interceptor-Info: scan successful X-KSE-Antivirus-Info: Clean, bases: 5/28/2024 12:09:00 PM X-KSE-Attachment-Filter-Triggered-Rules: Clean X-KSE-Attachment-Filter-Triggered-Filters: Clean X-KSE-BulkMessagesFiltering-Scan-Result: InTheLimit On 5/28/24 6:03 PM, Paul Barker wrote: > Make use of the busypolling status returned from NAPI complete to decide My spellchecker/translator trip over "busypolling" -- consider using "busy-polling"? And did you actually mean napi_complete_done()? > if interrupts shall be re-enabled or not. This is useful to reduce the > interrupt overhead. > > While at it switch to using napi_complete_done() as it take into account Takes. > the work done when providing the busypolling status. Again, "busy-polling"? > Signed-off-by: Paul Barker [...] MBR, Sergey