Received-SPF: pass (google.com: domain of linux-kernel+bounces-192776-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Subject: Re: [net-next PATCH v4 2/7] net: ravb: Consider busypolling status
 when re-enabling interrupts
From: Sergey Shtylyov <s.shtylyov@omp.ru>
To: Paul Barker <paul.barker.ct@bp.renesas.com>, "David S. Miller"
	<davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski
	<kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	=?UTF-8?Q?Niklas_S=c3=b6derlund?= <niklas.soderlund+renesas@ragnatech.se>
CC: Biju Das <biju.das.jz@bp.renesas.com>, Claudiu Beznea
	<claudiu.beznea.uj@bp.renesas.com>, Yoshihiro Shimoda
	<yoshihiro.shimoda.uh@renesas.com>, <netdev@vger.kernel.org>,
	<linux-renesas-soc@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20240528150339.6791-1-paul.barker.ct@bp.renesas.com>
 <20240528150339.6791-3-paul.barker.ct@bp.renesas.com>
 <669d3b51-d068-8816-37d1-dab2ffadb250@omp.ru>
Organization: Open Mobile Platform
Message-ID: <6bf07bb1-76c5-db5b-423b-a4c94bdf1ee3@omp.ru>
Date: Tue, 28 May 2024 19:47:20 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.1
Precedence: bulk
MIME-Version: 1.0
In-Reply-To: <669d3b51-d068-8816-37d1-dab2ffadb250@omp.ru>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-KSE-Attachment-Filter-Triggered-Filters: Clean
X-KSE-BulkMessagesFiltering-Scan-Result: InTheLimit

On 5/28/24 7:44 PM, Sergey Shtylyov wrote:

>> Make use of the busypolling status returned from NAPI complete to decide
> 
>    My spellchecker/translator trip over "busypolling" -- consider using
> "busy-polling"?
>    And did you actually mean napi_complete_done()?

   Ah, napi_complete() also returns a result... maybe this should be reworded
as "NAPI completion"?

>> if interrupts shall be re-enabled or not. This is useful to reduce the
>> interrupt overhead.
>>
>> While at it switch to using napi_complete_done() as it take into account
> 
>    Takes.
> 
>> the work done when providing the busypolling status.
> 
>    Again, "busy-polling"?
>  
>> Signed-off-by: Paul Barker <paul.barker.ct@bp.renesas.com>

[...]

MBR, Sergey