Received-SPF: pass (google.com: domain of linux-kernel+bounces-192778-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: "Kasireddy, Vivek" <vivek.kasireddy@intel.com>
To: Arnd Bergmann <arnd@kernel.org>, Sumit Semwal <sumit.semwal@linaro.org>,
	=?iso-8859-1?Q?Christian_K=F6nig?= <christian.koenig@amd.com>, Dave Airlie
	<airlied@redhat.com>, David Hildenbrand <david@redhat.com>, Gerd Hoffmann
	<kraxel@redhat.com>, Andrew Morton <akpm@linux-foundation.org>
CC: Arnd Bergmann <arnd@arndb.de>, "linux-media@vger.kernel.org"
	<linux-media@vger.kernel.org>, "dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>, "linaro-mm-sig@lists.linaro.org"
	<linaro-mm-sig@lists.linaro.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] udmabuf: add CONFIG_MMU dependency
Thread-Topic: [PATCH] udmabuf: add CONFIG_MMU dependency
Thread-Index: AQHasQNqfd65vYC/LEW+sVy8jwjwCbGs2/aQ
Date: Tue, 28 May 2024 16:52:09 +0000
Message-ID: <IA0PR11MB7185AFC7F39C244665B6DAD6F8F12@IA0PR11MB7185.namprd11.prod.outlook.com>
References: <20240528133138.2237237-1-arnd@kernel.org>
In-Reply-To: <20240528133138.2237237-1-arnd@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?RCd/hCoTX/AFDVNTbux79nT879AX4kL52oppsubsKQTEzpTbySJHadrGV2?=
 =?iso-8859-1?Q?ORVXNgUKxhQhWJn1/tt7kkWTbbhIBCufmnPUlG/dlY/mhNaKhKleDGcCgR?=
 =?iso-8859-1?Q?HOu2Y1Aa2iJ19Ti99872KmdsHR0RxaLJWQsoM3jvqZ+ttbPbdO7SBJEIfo?=
 =?iso-8859-1?Q?UsIJF4E5p6BjH9V2+2fcRtpHop5mI7F/UB3inofn8wWV+K5VfMYaPRWBEW?=
 =?iso-8859-1?Q?pHafS7dEoH8tSNVOm7h3M+PiOMpC9LgX8nsNmbUCv6d+vorNO79hXGB0RT?=
 =?iso-8859-1?Q?2rqmai3DEWMuUXzFrOW5w2l9E7U917w20pwvSY1HnFoTgymu7h9J3m5WSp?=
 =?iso-8859-1?Q?ZnM6j9iY4ER2qQ7SfAUVbDYoW6VtUB2qPzj1mOhCDWI9kjlsmUHaJjzEt0?=
 =?iso-8859-1?Q?X3QRBAEesOXHW2SvIpgvUZ1PV6QttD650NwbGz26k+kK204S6XnfWcMjne?=
 =?iso-8859-1?Q?DWD4dTsbszkWH8eUh2f+TgnwOs11yfa1eCysuHSnMt/GuLIf+bUK7at8EM?=
 =?iso-8859-1?Q?tQCZu/93uUSVV5wDDve6wZOIQiV3Cgaj6+TB4jrJUvCs9sQU7gQxxNXM2W?=
 =?iso-8859-1?Q?b/0FTxTTgdF9suHJM41Np88cM+LDguvmLD/himp91emT9fIOe3t5HtS8tx?=
 =?iso-8859-1?Q?xFh6Eh8ZlDcYH6hMqHCzxD9noU5B9Jd4IqC1sn7aUmRkUhS/2Iq06RbKAJ?=
 =?iso-8859-1?Q?WYAYuugSZFMlRwGS6wDeJdqAxMdtThImvOSq4Y7V6WDs2cI+yPJZT9J/Ma?=
 =?iso-8859-1?Q?rssQNd6aXqAZrIljJgTRPiTsE8JMsWQLME1PbE4roOCvZmWYY0OWFgETx8?=
 =?iso-8859-1?Q?4czpszsFMLC40VC0yzKy5E805MDL0IUNW3prpYWzsww6i7CvbaOgD15Hhn?=
 =?iso-8859-1?Q?n85WkpqC/dHlcvDWtgkgAHzX667XWY7TEVtzEThbaV+AHxgXD2P1zQ52r+?=
 =?iso-8859-1?Q?xqGgL9rS/zcLsfSWI8xKJp2Pfra5ENkHrosYzbUDMuQ6I2wVjWd43XLOe3?=
 =?iso-8859-1?Q?0eChFu12LUVeXeqBSh35Hs8PINFYRdwjuPibHHCkqPY2QHFGKsaf9nrwJ1?=
 =?iso-8859-1?Q?srxr9zOLB0B6joG+dPkuVJ1lBJAnPiKN6udntem4BqkTNnGVAIMVXzmx4W?=
 =?iso-8859-1?Q?YtWlIufxj/w/chS12YfI1n4JO5obonCoro2gZq51OF3IPWylRzssZaoFop?=
 =?iso-8859-1?Q?xu9sa5niXOgX7xnH0VoWBBBE7hQLAEBT67WI7+F+cv96ruV1Pvc+WE5cEr?=
 =?iso-8859-1?Q?PBrJDe8uatOEq4uAHxh4w58gmdcAMbM0/tKh6/pbUu8a5jookd2Ch8gPrv?=
 =?iso-8859-1?Q?7PIUbXP8HqJJ08z/W0W53MQNVCw0gdOKzhm9b2KIK0Jbz//7210VbtW3As?=
 =?iso-8859-1?Q?06+B/0x/rUkK7UPWj5/rA9Pe+dZLIGKultXWkbKS01eeh/EcXQ9luN3dg9?=
 =?iso-8859-1?Q?IRuXfEO846rxlB7R6KK/O45yV1HTOZSCKEIRySChpuluBeZjP8Ecy/cn/t?=
 =?iso-8859-1?Q?i5e1T/wWLD+EAxeXLFFeWvHO9XBO9cqSyNEcPqicF8ua3Z+5aQ9Wd4aUPX?=
 =?iso-8859-1?Q?ZaJdz44fhqu5F9UqSIdagZrtiID/7tUhJt8i/T19LwlPgmCWa6krcoWYM2?=
 =?iso-8859-1?Q?e6k3GOZmVFGqZME3MmabmXnzbZYyZGUBiH?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: IA0PR11MB7185.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 00ad8f8d-7c19-4e05-4583-08dc7f368401
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 May 2024 16:52:09.9313
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: +ZiPpVvEXib+jN0ZUbTYxJh9ZNayO7HZ4BT/B63lCNhZbJPzX8i2Xly5N2p1oK21nQ3F+yNekQej4JH9UOCCzss+plVQXd3NAiGcqP3CeZ0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB6050
X-OriginatorOrg: intel.com

> From: Arnd Bergmann <arnd@arndb.de>
>=20
> There is no !CONFIG_MMU version of vmf_insert_pfn():
>=20
> arm-linux-gnueabi-ld: drivers/dma-buf/udmabuf.o: in function
> `udmabuf_vm_fault':
> udmabuf.c:(.text+0xaa): undefined reference to `vmf_insert_pfn'
>=20
> Fixes: f7254e043ff1 ("udmabuf: use vmf_insert_pfn and VM_PFNMAP for
> handling mmap")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/dma-buf/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git a/drivers/dma-buf/Kconfig b/drivers/dma-buf/Kconfig
> index e4dc53a36428..b46eb8a552d7 100644
> --- a/drivers/dma-buf/Kconfig
> +++ b/drivers/dma-buf/Kconfig
> @@ -35,6 +35,7 @@ config UDMABUF
>  	default n
>  	depends on DMA_SHARED_BUFFER
>  	depends on MEMFD_CREATE || COMPILE_TEST
> +	depends on MMU
Thank you for the fix!
Acked-by: Vivek Kasireddy <vivek.kasireddy@intel.com>

>  	help
>  	  A driver to let userspace turn memfd regions into dma-bufs.
>  	  Qemu can use this to create host dmabufs for guest framebuffers.
> --
> 2.39.2
>=20