Received-SPF: pass (google.com: domain of linux-kernel+bounces-192789-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Tue, 28 May 2024 12:00:00 -0500
From: Rob Herring <robh@kernel.org>
To: Alexandre Bailon <abailon@baylibre.com>
Cc: rafael@kernel.org, daniel.lezcano@linaro.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	rui.zhang@intel.com, lukasz.luba@arm.com, linux-pm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 4/6] dt-bindings: thermal: Add a property to select
 the aggregation type
Message-ID: <20240528170000.GA903992-robh@kernel.org>
References: <20240524143150.610949-1-abailon@baylibre.com>
 <20240524143150.610949-5-abailon@baylibre.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240524143150.610949-5-abailon@baylibre.com>

On Fri, May 24, 2024 at 04:31:48PM +0200, Alexandre Bailon wrote:
> This adds a new property named "aggregation" that could be used to
> select the aggregation type when there are multiple sensors assigned
> to a thermal zone.
> 
> Signed-off-by: Alexandre Bailon <abailon@baylibre.com>
> ---
>  .../devicetree/bindings/thermal/thermal-zones.yaml        | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/thermal/thermal-zones.yaml b/Documentation/devicetree/bindings/thermal/thermal-zones.yaml
> index fa7a72e2ba44..e6e4b46773e3 100644
> --- a/Documentation/devicetree/bindings/thermal/thermal-zones.yaml
> +++ b/Documentation/devicetree/bindings/thermal/thermal-zones.yaml
> @@ -111,6 +111,14 @@ patternProperties:
>            coefficients are ordered and are matched with sensors by means of the
>            sensor ID. Additional coefficients are interpreted as constant offset.
>  
> +      aggregation:
> +        $ref: /schemas/types.yaml#/definitions/string
> +        enum:
> +          - avg
> +          - max
> +        description:
> +          Aggregation type to use compute a temperature from multiple sensors.

This is optional, so what's the default? I suppose you could make it 
required if more than 1 sensor.

A boolean could work here as well unless you think there might be a 3rd 
algorithm.

> +
>        sustainable-power:
>          $ref: /schemas/types.yaml#/definitions/uint32
>          description:
> -- 
> 2.44.1
>