Received-SPF: pass (google.com: domain of linux-kernel+bounces-192837-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Feedback-ID: iad51458e:Fastmail
Date: Tue, 28 May 2024 11:00:18 -0700
From: Boqun Feng <boqun.feng@gmail.com>
To: Jeff Johnson <quic_jjohnson@quicinc.com>
Cc: Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>,
	Will Deacon <will@kernel.org>, Waiman Long <longman@redhat.com>,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] locking/ww_mutex/test: add MODULE_DESCRIPTION()
Message-ID: <ZlYbst1xppRKBxwm@boqun-archlinux>
References: <20240524-md-test-ww_mutex-v1-1-4fb8c106fe21@quicinc.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240524-md-test-ww_mutex-v1-1-4fb8c106fe21@quicinc.com>

On Fri, May 24, 2024 at 05:18:11PM -0700, Jeff Johnson wrote:
> Fix the 'make W=1' warning:
> WARNING: modpost: missing MODULE_DESCRIPTION() in kernel/locking/test-ww_mutex.o
> 
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> ---
>  kernel/locking/test-ww_mutex.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/kernel/locking/test-ww_mutex.c b/kernel/locking/test-ww_mutex.c
> index 78719e1ef1b1..0fab96137ddb 100644
> --- a/kernel/locking/test-ww_mutex.c
> +++ b/kernel/locking/test-ww_mutex.c
> @@ -695,5 +695,6 @@ static void __exit test_ww_mutex_exit(void)
>  module_init(test_ww_mutex_init);
>  module_exit(test_ww_mutex_exit);
>  
> +MODULE_DESCRIPTION("API test facility for ww_mutexes");


This looks good to me, but seems to me MODULE_DESCRIPTION() is usually
placed after MODULE_AUTHOR(), could you reorder it a bit? Thanks!

Regards,
Boqun

>  MODULE_LICENSE("GPL");
>  MODULE_AUTHOR("Intel Corporation");
> 
> ---
> base-commit: 07506d1011521a4a0deec1c69721c7405c40049b
> change-id: 20240524-md-test-ww_mutex-c18c263bc483
>