Received-SPF: pass (google.com: domain of linux-kernel+bounces-192883-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Tue, 28 May 2024 14:47:43 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: Ilkka =?UTF-8?B?TmF1bGFww6TDpA==?= <digirigawa@gmail.com>
Cc: "Linux regression tracking (Thorsten Leemhuis)"
 <regressions@leemhuis.info>, Linux regressions mailing list
 <regressions@lists.linux.dev>, stable@vger.kernel.org,
 linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org
Subject: Re: Bug in Kernel 6.8.x, 6.9.x Causing Trace/Panic During
 Shutdown/Reboot
Message-ID: <20240528144743.149e351b@rorschach.local.home>
In-Reply-To: <CAE4VaRHaijpV1CC9Jo_Lg4tNQb_+=LTHwygOp5Bm2z5ErVzeow@mail.gmail.com>
References: <CAE4VaREzY+a2PvQJYJbfh8DwB4OP7kucZG-e28H22xyWob1w_A@mail.gmail.com>
 <5b79732b-087c-411f-a477-9b837566673e@leemhuis.info>
 <20240527183139.42b6123c@rorschach.local.home>
 <CAE4VaRHaijpV1CC9Jo_Lg4tNQb_+=LTHwygOp5Bm2z5ErVzeow@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Tue, 28 May 2024 07:51:30 +0300
Ilkka Naulap=C3=A4=C3=A4 <digirigawa@gmail.com> wrote:

> yeah, the cache_from_obj tracing bug (without panic) has been
> displayed quite some time now - maybe even since 6.7.x or so. I could
> try checking a few versions back for this and try bisecting it if I
> can find when this started.
>=20

OK, so I don't think the commit your last bisect hit is the cause of
the bug. It added a delay (via RCU) and is causing the real bug to blow
up more.

Can you add this patch to v6.9.2 and hopefully it crashes in a better
location that we can find where the mixup happened.

You may need to add the other commit (too if this doesn't trigger.

Thanks,

-- Steve

diff --git a/fs/tracefs/inode.c b/fs/tracefs/inode.c
index 417c840e6403..7af3f696696d 100644
--- a/fs/tracefs/inode.c
+++ b/fs/tracefs/inode.c
@@ -50,6 +50,7 @@ static struct inode *tracefs_alloc_inode(struct super_blo=
ck *sb)
 	list_add_rcu(&ti->list, &tracefs_inodes);
 	spin_unlock_irqrestore(&tracefs_inode_lock, flags);
=20
+	ti->magic =3D 20240823;
 	return &ti->vfs_inode;
 }
=20
@@ -66,6 +67,7 @@ static void tracefs_free_inode(struct inode *inode)
 	struct tracefs_inode *ti =3D get_tracefs(inode);
 	unsigned long flags;
=20
+	BUG_ON(ti->magic !=3D 20240823);
 	spin_lock_irqsave(&tracefs_inode_lock, flags);
 	list_del_rcu(&ti->list);
 	spin_unlock_irqrestore(&tracefs_inode_lock, flags);
@@ -271,16 +273,6 @@ static const struct inode_operations tracefs_file_inod=
e_operations =3D {
 	.setattr	=3D tracefs_setattr,
 };
=20
-struct inode *tracefs_get_inode(struct super_block *sb)
-{
-	struct inode *inode =3D new_inode(sb);
-	if (inode) {
-		inode->i_ino =3D get_next_ino();
-		simple_inode_init_ts(inode);
-	}
-	return inode;
-}
-
 struct tracefs_mount_opts {
 	kuid_t uid;
 	kgid_t gid;
@@ -448,6 +440,17 @@ static const struct super_operations tracefs_super_ope=
rations =3D {
 	.show_options	=3D tracefs_show_options,
 };
=20
+struct inode *tracefs_get_inode(struct super_block *sb)
+{
+	struct inode *inode =3D new_inode(sb);
+	BUG_ON(sb->s_op !=3D &tracefs_super_operations);
+	if (inode) {
+		inode->i_ino =3D get_next_ino();
+		simple_inode_init_ts(inode);
+	}
+	return inode;
+}
+
 /*
  * It would be cleaner if eventfs had its own dentry ops.
  *
diff --git a/fs/tracefs/internal.h b/fs/tracefs/internal.h
index f704d8348357..dda7d2708e30 100644
--- a/fs/tracefs/internal.h
+++ b/fs/tracefs/internal.h
@@ -16,6 +16,7 @@ struct tracefs_inode {
 	};
 	/* The below gets initialized with memset_after(ti, 0, vfs_inode) */
 	struct list_head	list;
+	unsigned long		magic;
 	unsigned long           flags;
 	void                    *private;
 };