Received-SPF: pass (google.com: domain of linux-kernel+bounces-192896-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Tue, 28 May 2024 12:03:06 -0700
From: "Paul E. McKenney" <paulmck@kernel.org>
To: Zqiang <qiang.zhang1211@gmail.com>
Cc: frederic@kernel.org, neeraj.upadhyay@kernel.org, joel@joelfernandes.org,
	urezki@gmail.com, rcu@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rcutorture: Skip debug object testing for cur_ops
 without ->debug_objects set
Message-ID: <1195a9a3-db87-465d-a3b0-ee92d67da954@paulmck-laptop>
Reply-To: paulmck@kernel.org
References: <20240528030054.4525-1-qiang.zhang1211@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240528030054.4525-1-qiang.zhang1211@gmail.com>

On Tue, May 28, 2024 at 11:00:54AM +0800, Zqiang wrote:
> This commit make rcu_test_debug_objects() early return when the
> specified cur_ops not set the ->debug_objects.
> 
> Signed-off-by: Zqiang <qiang.zhang1211@gmail.com>
> ---
>  kernel/rcu/rcutorture.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/rcu/rcutorture.c b/kernel/rcu/rcutorture.c
> index 08bf7c669dd3..9b8c277ab91a 100644
> --- a/kernel/rcu/rcutorture.c
> +++ b/kernel/rcu/rcutorture.c
> @@ -3495,8 +3495,9 @@ static void rcu_test_debug_objects(void)
>  		return;
>  	}
>  
> -	if (WARN_ON_ONCE(cur_ops->debug_objects &&
> -			(!cur_ops->call || !cur_ops->cb_barrier)))
> +	if (!cur_ops->debug_objects ||
> +			WARN_ON_ONCE(cur_ops->debug_objects &&

You lost me here.  Given that we have "!cur_ops->debug_objects" before
that WARN_ON_ONCE(), why do we need "cur_ops->debug_objects" inside of it?

Also, we don't get here unless the rcutorture.object_debug kernel boot
parameter is specified, don't we really want to WARN_ON_ONCE if the
current flavor does not support that?

Or do you have a use case that needs to silence these warnings?

							Thanx, Paul

> +				(!cur_ops->call || !cur_ops->cb_barrier)))
>  		return;
>  
>  	struct rcu_head *rhp = kmalloc(sizeof(*rhp), GFP_KERNEL);
> -- 
> 2.17.1
>