Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936102AbYBCB6X (ORCPT ); Sat, 2 Feb 2008 20:58:23 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S934660AbYBCB6I (ORCPT ); Sat, 2 Feb 2008 20:58:08 -0500 Received: from cn.fujitsu.com ([222.73.24.84]:54869 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S933771AbYBCB6G (ORCPT ); Sat, 2 Feb 2008 20:58:06 -0500 Message-ID: <47A51F77.60509@cn.fujitsu.com> Date: Sun, 03 Feb 2008 09:57:11 +0800 From: Li Zefan User-Agent: Thunderbird 2.0.0.9 (X11/20071115) MIME-Version: 1.0 To: =?UTF-8?B?TWlndWVsIEJvdMOzbg==?= CC: LKML , netdev@vger.kernel.org, David Miller , zambrano@broadcom.com, linville@tuxdriver.com Subject: Re: linux-2.6.24 compile error in drivers/net/b44.c References: <47A3CC70.8090900@cn.fujitsu.com> <47A3F6DC.1000903@cn.fujitsu.com> <47A4CB7C.3010507@gmail.com> <47A51E86.8080305@cn.fujitsu.com> In-Reply-To: <47A51E86.8080305@cn.fujitsu.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1799 Lines: 69 Li Zefan wrote: > Miguel Botón 写道: >> Li Zefan wrote: >>> Add CCs: >>> >>> CC: mboton@gmail.com >>> CC: zambrano@broadcom.com >>> CC: linville@tuxdriver.com >>> >>> Li Zefan wrote: >>>> drivers/net/b44.c: In function 'b44_remove_one': >>>> drivers/net/b44.c:2231: error: implicit declaration of function 'ssb_pcihost_set_power_state' >>>> make[2]: *** [drivers/net/b44.o] Error 1 >>>> make[1]: *** [drivers/net] Error 2 >>>> >>>> I think it is caused by: >>>> >>>> CONFIG_SSB_PCIHOST=n >>>> CONFIG_B44=y >>>> >> This patch should fix b44 errors when 'SSB_PCIHOST' is not enabled. >> > > I tried the patch, but it does't work, same compile error. :( > > If .config is needed, tell me and I will attach it. > Sorry, I just made a mistake, actually the patch works. Thanks! >> Signed-off-by: Miguel Botón >> >> diff --git a/drivers/net/b44.c b/drivers/net/b44.c >> index ea2a2b5..d081234 100644 >> --- a/drivers/net/b44.c >> +++ b/drivers/net/b44.c >> @@ -2228,7 +2228,9 @@ static void __devexit b44_remove_one(struct ssb_device *sdev) >> unregister_netdev(dev); >> ssb_bus_may_powerdown(sdev->bus); >> free_netdev(dev); >> +#ifdef B44_PCI >> ssb_pcihost_set_power_state(sdev, PCI_D3hot); >> +#endif >> ssb_set_drvdata(sdev, NULL); >> } >> >> @@ -2257,7 +2259,9 @@ static int b44_suspend(struct ssb_device *sdev, pm_message_t state) >> b44_setup_wol(bp); >> } >> >> +#ifdef B44_PCI >> ssb_pcihost_set_power_state(sdev, PCI_D3hot); >> +#endif >> return 0; >> } >> >> -- >> Miguel Botón >> >> > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/