Received-SPF: pass (google.com: domain of linux-kernel+bounces-193002-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20240527051128.110091-1-Dhananjay.Ugwekar@amd.com> <929aec0d-690b-4277-90b0-d0b4adb437d3@amd.com>
In-Reply-To: <929aec0d-690b-4277-90b0-d0b4adb437d3@amd.com>
From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: Tue, 28 May 2024 22:05:29 +0200
Message-ID: <CAJZ5v0hz+RzrtD=JUvf_W7g0vSHTmtfiTcJC23fvVvb_N9AiHg@mail.gmail.com>
Subject: Re: [PATCH] cpufreq: amd-pstate: Fix the inconsistency in max
 frequency units
To: Mario Limonciello <mario.limonciello@amd.com>, 
	Dhananjay Ugwekar <dhananjay.ugwekar@amd.com>
Cc: rafael@kernel.org, ray.huang@amd.com, viresh.kumar@linaro.org, 
	gautham.shenoy@amd.com, ananth.narayan@amd.com, linux-pm@vger.kernel.org, 
	linux-kernel@vger.kernel.org, Perry.Yuan@amd.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, May 27, 2024 at 4:40=E2=80=AFPM Mario Limonciello
<mario.limonciello@amd.com> wrote:
>
> On 5/27/2024 00:11, Dhananjay Ugwekar wrote:
> > The nominal frequency in cpudata is maintained in MHz whereas all other
> > frequencies are in KHz. This means we have to convert nominal frequency
> > value to KHz before we do any interaction with other frequency values.
> >
> > In amd_pstate_set_boost(), this conversion from MHz to KHz is missed,
> > fix that.
> >
> > Tested on a AMD Zen4 EPYC server
> >
> > Before:
> > $ cat /sys/devices/system/cpu/cpufreq/policy*/scaling_max_freq | uniq
> > 2151
> > $ cat /sys/devices/system/cpu/cpufreq/policy*/cpuinfo_min_freq | uniq
> > 400000
> > $ cat /sys/devices/system/cpu/cpufreq/policy*/scaling_cur_freq | uniq
> > 2151
> > 409422
> >
> > After:
> > $ cat /sys/devices/system/cpu/cpufreq/policy*/scaling_max_freq | uniq
> > 2151000
> > $ cat /sys/devices/system/cpu/cpufreq/policy*/cpuinfo_min_freq | uniq
> > 400000
> > $ cat /sys/devices/system/cpu/cpufreq/policy*/scaling_cur_freq | uniq
> > 2151000
> > 1799527
> >
>
> Cc: stable@vger.kernel.org
>
> > Fixes: ec437d71db77 ("cpufreq: amd-pstate: Introduce a new AMD P-State =
driver to support future processors")
> > Signed-off-by: Dhananjay Ugwekar <Dhananjay.Ugwekar@amd.com>
>
> Acked-by: Mario Limonciello <mario.limonciello@amd.com>

Applied as 6.10-rc material, thanks!

> > ---
> >   drivers/cpufreq/amd-pstate.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.=
c
> > index 1b7e82a0ad2e..cde3b91b4422 100644
> > --- a/drivers/cpufreq/amd-pstate.c
> > +++ b/drivers/cpufreq/amd-pstate.c
> > @@ -669,7 +669,7 @@ static int amd_pstate_set_boost(struct cpufreq_poli=
cy *policy, int state)
> >       if (state)
> >               policy->cpuinfo.max_freq =3D cpudata->max_freq;
> >       else
> > -             policy->cpuinfo.max_freq =3D cpudata->nominal_freq;
> > +             policy->cpuinfo.max_freq =3D cpudata->nominal_freq * 1000=
;
> >
> >       policy->max =3D policy->cpuinfo.max_freq;
> >
>