Received-SPF: pass (google.com: domain of linux-kernel+bounces-193127-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <1a33c7a6-a04d-4c53-b8f2-02431a1073b3@amd.com>
Date: Tue, 28 May 2024 16:37:56 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 8/9] platform/x86: asus-wmi: add apu_mem setting
To: Luke Jones <luke@ljones.dev>, Hans de Goede <hdegoede@redhat.com>,
 =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Cc: corentin.chary@gmail.com, platform-driver-x86@vger.kernel.org,
 linux-kernel@vger.kernel.org, richard@hughsie.com
References: <20240528013626.14066-1-luke@ljones.dev>
 <20240528013626.14066-9-luke@ljones.dev>
 <6f4bc109-00d0-47b0-a581-b96a6152545c@amd.com>
 <4d6b9171-7248-4937-87de-7e921ed8e507@app.fastmail.com>
 <5f4799b1-0606-46a9-a347-5a03738db341@amd.com>
 <ac597520-fb5b-40e5-ae1f-de825450d2db@app.fastmail.com>
 <371d4109-a3bb-4c3b-802f-4ec27a945c99@amd.com>
 <6d4e7f1e-ccd0-4ac5-b450-f9c5f8d5c90e@app.fastmail.com>
Content-Language: en-US
From: Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <6d4e7f1e-ccd0-4ac5-b450-f9c5f8d5c90e@app.fastmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZmM3NmNDcmZhTDZnZlZXVlNsYiswVWV3YzFRUHJjMWlYWUlWdkpvWVhiT0k5?=
 =?utf-8?B?eWxlZDBqZHZscS9JZzJCZlMwWGhMVTYvTmhZVGRobGRDRy9VUWtKUzlVUGQw?=
 =?utf-8?B?a2I5d1doeHB1RGRNVEN1UFhHWWVrMzhucW9tUVNpOG5mNEg2S2VQeFIwV1J5?=
 =?utf-8?B?K3VUMmVsWXprdVpnR1pzZnpramZ0MnZWUWU3ZkZIeXpVbDNTRk5SWFNxKzNm?=
 =?utf-8?B?SWp3Q1RaWklSMktWNGNhVFhicXB0WmdGcGpva29TVDdQam5xUDUveVlNSURn?=
 =?utf-8?B?cjd4a0N2TWZYdTZ2dUFjc0UwdlJUL1lyRDFkNnoycW40cmxpcjVWZVppd2JJ?=
 =?utf-8?B?VW01cFhvMGlHZWdMWVVQYXI5NTZkMVRKTzUvUmRjOFZVRHlSVzJlUWJRZzlr?=
 =?utf-8?B?MTVvNk5KNzZmQzZhYlk3aXV2L0dyWnFWU0hvV3d5UjNvNW9ycTcyNWR4clpq?=
 =?utf-8?B?Nzl3OWRWYko0RVI3VnRZUmRqdFlnU3gyMExZd3NZTUVRMi9sWFhTSHdrZU1u?=
 =?utf-8?B?Z1NqdXRFR05xTWRiNWw2MzJHUGViZnFBQ1d4c284TEdLbzk4ZUZ3SGZ5Q0pB?=
 =?utf-8?B?dlpvM3kybnhZKzFzdFpTY25meHp0MkFuRVMvbHJybExNL0VTOVZOV3JCbS8y?=
 =?utf-8?B?WkxFUnBlWDFyaC9BRGxySFRLcXo2NFI1YTlOYkdRcjBISW1nd1dRdThzZXRz?=
 =?utf-8?B?dEJUVG9VYzJqbWhkYk1GZE5DUkNaMkVSYnhBNWFPQnN3V3VkeFhSeU5RWXRi?=
 =?utf-8?B?a0VaUndaQjh6NGNwM2lJdGo1em1KWkV6aUpHTWFGYlB5bFE4WFlSdW1LTzVB?=
 =?utf-8?B?azUwMUphRExtWW1QSjVERGsrZXpDR2txTG4xSitIQUhHK3ljcnlobGVzeEFC?=
 =?utf-8?B?ZEVSbktVSDVLOTA5S2JhNy9JYXBaL0JhUXBoaFZVNFAyUXlnd1NqK0lmSUU0?=
 =?utf-8?B?U3dQc0UyZDZuVHA4dGNMTkUyaFgvME1CNU9lT2lOTVVQMlgwQ21CR2FwbGJ2?=
 =?utf-8?B?MVIyVTJBUVpyQTgwUDBiWjJNUE8yOTE1cStKdnk0SkpuSlVHdDVCdHFPU0Fn?=
 =?utf-8?B?ZWpzbWlqZEJaRUV1bHcwcEFMZHpqdm1Xelo3T0wyWTUwdW5tQnlkRjltWGhP?=
 =?utf-8?B?Z1QxSkhRL1lyYkRHaDBqQ2pPZWY1ZnFhZlpRbkpOT2xHcDZ5NlovdW4zQkZZ?=
 =?utf-8?B?SFNlaGJWaGU3UEUwa2d1T21WZzRYWTZDSldXdWdqTFNvazBJYzVUSXV0QXk1?=
 =?utf-8?B?OEVyYko5V2JIYkVmcXQ3RDdXZXp1QnNiSS9ZVUs2bmNUcmo5OG10M1B0UUlu?=
 =?utf-8?B?cjBhcUd1VVNVVWt1STlONjlpek8xMXNDQ0FZRytZcUhiS3QwaEZ2WHMvd2JM?=
 =?utf-8?B?YWtuL0l3VFJ4MEhZNjVSTUZNbnFnbnFFWDJFSmUrMkRkQXRkQ3ZoNnV2L3g3?=
 =?utf-8?B?WGswelg5aVVIR2k5b3ZEK05oNDJlNEtqUS9nUFcxMlgwWjNpT3hrZkRwUThv?=
 =?utf-8?B?RDhoSGFVOURJNUZuL2piM2o1YVVlTkRkM0VEVG9PSXZzcVpRMXVlMDlINWV6?=
 =?utf-8?B?QkVnZ1BuUUx6cTlBcEJUejZuMGMrTlRpeEFWQUVpOG43akhwekFVMENDMVpt?=
 =?utf-8?B?OGs5MUZjUkh4V3d3VU9xd0lJVVFrSWVNT1pSWVZ5ZXNwTGptVXpzczZ5QnAx?=
 =?utf-8?B?elZObHlZWWdrelZOdlVjMjl5c0hZeUFxaGliQlRXcGFxdkhaZHdJeWhIcVBh?=
 =?utf-8?B?QlR4Tm95b0h0OGg5b3cxZUV5Qkt6MUN6NW5sb2YzV3JtemZYQi9NSlYzNnJY?=
 =?utf-8?B?NmNjb1QyNG9yY1lzZndqV2lyZDcxR1ptN0JEN25hdTcrSFpKek5LemhiUkxa?=
 =?utf-8?B?SDREZHA3TmZ5Yk1JaVR0aVJJTmpSSEJzbHoxdCttdUFPVkxGMEdtbWVCcSsx?=
 =?utf-8?B?MW1JeG1tcFQ0V0tXcDRiQWtMTHViQWpzckNUb210L3Y4TWc1Z2dVcTYrdzBH?=
 =?utf-8?B?Y3VQWHNPcFN3NVJhZ3JlRlMvS0lIZmxjVjFreGlPNUhuaWM2SFphdWcyMkVY?=
 =?utf-8?B?SjhSUWpRVXN3VkhvU0I0b1ZGTWE0ek9aSFV1QmFKYTk1MzdjVEVKNUVUSXRh?=
 =?utf-8?Q?ouP/wqgZmRAF99zspn3JW6R9c?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 32a3a304-d821-463d-9251-08dc7f5e7113
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 May 2024 21:37:58.1571
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9+30OgjTZDCEsx1GqtPZB6lAyMPXD6qJy+0lmOLjuk2Vjdi9Lt14SBzIESivsg0wSQ4MORc6dchUq00o4MYZUQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6220

On 5/28/2024 16:34, Luke Jones wrote:
> 
> 
> On Wed, 29 May 2024, at 9:16 AM, Mario Limonciello wrote:
>>>> For any "new" attributes it's better to put them in that API than code
>>>> duplication of the BIOS attributes API as well as a random sysfs file
>>>> API that you can never discard.
>>>
>>> Do you mean the firmware_attributes API? If so, I'm not opposed to adding all the existing ROG attributes to it also.
>>>
>>> If I'm understanding the docs correctly, for example this apu_mem attr would then become:
>>> - /sys/class/firmware-attributes/asus-bios/attributes/apu_mem/type
>>> - /sys/class/firmware-attributes/*/attributes/apu_mem/current_value
>>> - /sys/class/firmware-attributes/*/attributes/apu_mem/default_value
>>> - /sys/class/firmware-attributes/*/attributes/apu_mem/display_name
>>> - /sys/class/firmware-attributes/*/attributes/apu_mem/possible_values
>>> - ..etc
>>>
>>> That's absolutely much better than what I've been doing and I wish I'd known about it sooner.
>>
>> Yup!  And even better "fwupdmgr get-bios-setting" and "fwupdmgr
>> set-bios-setting" [1] will work with bash completion too.
>>
>> If you want to build a GUI around it, it could use the fwupd dbus
>> interface for getting those settings and manipulating them.
> 
> My existing GUI effort revolves around me adding these attrs to both kernel and a dbus interface. So if I can drop that then all the better

Awesome!  You can either use libfwupd or the dbus interface.  After 
you're done with the kernel work ping me or Richard if you have problems.

> 
>> The dbus
>> interface policy is protected by PK.
> 
> What is PK? And I'm guessing this restricts users to requiring permissions to change settings?
>   

Whoops forgot to respond to these.

PK = PolicyKit.